Skip to content

[HOLD for payment 2023-12-08] [TS migration] Migrate 'models' lib to TypeScript #24871

Closed

Description

@melvin-bot

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/models/BankAccount.js 5

Activity

  1. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    Author

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  2. fvlvte commented on Sep 18, 2023

    @fvlvte
    Contributor

    I am Kacper Fałat from Callstack - expert contributor group. I'd like to work on this job

  3. melvin-bot commented on Sep 18, 2023

    @melvin-bot
    Author

    📣 @fvlvte! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  4. 14 remaining items

  5. melvin-bot commented on Dec 1, 2023

    @melvin-bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-08. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  6. melvin-bot commented on Dec 11, 2023

    @melvin-bot
    Author

    @neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. melvin-bot commented on Dec 12, 2023

    @melvin-bot
    Author

    @neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. neil-marcellini commented on Dec 12, 2023

    @neil-marcellini
    Contributor

    Closing this out since I don't think payment is needed.

  9. thesahindia commented on Jan 9, 2024

    @thesahindia
    Member

    Closing this out since I don't think payment is needed.

    Hey @neil-marcellini. Actually payment for C+ review is due. I reviewed the PR.

    Can you please add a payment summary here? I will need to get the money request approved on New Dot. I think it's $250 for TS migration tickets.

  10. JmillsExpensify commented on Jan 9, 2024

    @JmillsExpensify
    Contributor

    Need a payment summary before I can approve the payment for @thesahindia. cc @neil-marcellini

  11. JmillsExpensify commented on Jan 22, 2024

    @JmillsExpensify
    Contributor

    Still waiting on a payment summary.

  12. neil-marcellini commented on Jan 22, 2024

    @neil-marcellini
    Contributor

    Payment summary:
    Please pay @thesahindia $250 for the PR review.

  13. JmillsExpensify commented on Jan 22, 2024

    @JmillsExpensify
    Contributor

    $250 payment approved for @thesahindia based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions