Skip to content

[HOLD for payment 2024-04-05] [$250] [TS migration] Migrate 'AttachmentPicker' component to TypeScript #25134

Closed

Description

@melvin-bot

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/AttachmentPicker/launchCamera.js 1
src/components/AttachmentPicker/launchCamera.ios.js 2
src/components/AttachmentPicker/launchCamera.android.js 2
src/components/AttachmentPicker/index.native.js 19
src/components/AttachmentPicker/index.js 3
src/components/AttachmentPicker/attachmentPickerPropTypes.js 2
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01289b646840dd95f2
  • Upwork Job ID: 1744724169501749248
  • Last Price Increase: 2024-01-24
  • Automatic offers:
    • 0xmiroslav | Reviewer | 28092368
    • neonbhai | Contributor | 28092369
    • situchan | Reviewer | 0
    • dukenv0307 | Contributor | 0
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    Author

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  2. melvin-bot commented on Nov 23, 2023

    @melvin-bot
    Author

    @melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  3. moved this from Done to Todo in Typescript migrationon Nov 29, 2023
  4. 94 remaining items

  5. situchan commented on Mar 13, 2024

    @situchan
    Contributor

    The PR is not yet approved by TS team but I will start review soon.

  6. slafortune commented on Mar 22, 2024

    @slafortune
    Contributor

    @situchan looks like it's ready for another review 🤞

  7. melvin-bot commented on Mar 25, 2024

    @melvin-bot
    Author

    Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 29, 2024
  9. changed the title [-][$250] [TS migration] Migrate 'AttachmentPicker' component to TypeScript[/-] [+][HOLD for payment 2024-04-05] [$250] [TS migration] Migrate 'AttachmentPicker' component to TypeScript[/+] on Mar 29, 2024
  10. melvin-bot commented on Mar 29, 2024

    @melvin-bot
    Author

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Mar 29, 2024

    @melvin-bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Mar 29, 2024

    @melvin-bot
    Author

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan / @dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  13. slafortune commented on Apr 5, 2024

    @slafortune
    Contributor

    No regression test needed
    @situchan @dukenv0307 paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.TaskTypescript MigrationWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions