Skip to content

[TS migration] Migrate 'PDFView' component to TypeScript #25151

New issue
New issue
Closed
Closed
[TS migration] Migrate 'PDFView' component to TypeScript#25151
Assignees
AndrewGableCortneyOfstad
Labels
NewFeatureSomething to build that is a new item.Not a priorityReviewingHas a PR in reviewTaskTypescript MigrationWeeklyKSv2

Description

@melvin-bot
melvin-bot
bot
opened on Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/PDFView/pdfViewPropTypes.js 3
src/components/PDFView/index.native.js 16
src/components/PDFView/index.js 19
src/components/PDFView/PDFPasswordForm.js 15
src/components/PDFView/PDFInfoMessage.js 10

Activity

  1. melvin-bot
    added
    Task
    Typescript Migration
    WeeklyKSv2
    on Aug 16, 2023
  2. github-project-automation
    added this to Typescript migrationon Aug 16, 2023
  3. melvin-bot
    added
    MonthlyKSv2
    and removed
    WeeklyKSv2
    on Sep 11, 2023

  4. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    melvin-botBot
    on Sep 11, 2023
    Author

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  5. roryabraham
    moved this to Todo in Typescript migrationon Sep 12, 2023
  6. melvin-bot
    closed this as completedon Nov 23, 2023

  7. melvin-bot commented on Nov 23, 2023

    @melvin-bot
    melvin-botBot
    on Nov 23, 2023 – with Melvin Bot
    Author

    @melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  8. melvin-bot
    added
    Not a priority
    on Nov 23, 2023
  9. github-project-automation
    moved this from Todo to Done in Typescript migrationon Nov 23, 2023
  10. melvin-bot
    reopened this on Nov 23, 2023
  11. roryabraham
    moved this from Done to Todo in Typescript migrationon Nov 29, 2023

  12. roryabraham commented on Feb 3, 2024

    @roryabraham
    roryabraham
    on Feb 3, 2024
    Contributor

    Looks like this component also need to be migrated to a functional component, not sure why it was missed.

    Once we do that, we'll have no further uses of withKeyboardState, and we can greatly simplify that to remove:

    • KeyboardStateContext
    • KeyboardStateProvdider, KeyboardStateConsumer
    • withKeyboardState

    and consolidate that all into a single useKeyboardState hook.

    Note: In #35270 we're considering adding https://kirillzyusko.github.io/react-native-keyboard-controller, in which case we can probably just use useKeyboardHandler hook directly.

  13. 8 remaining items

  14. melvin-bot
    added
    WeeklyKSv2
    and removed
    Overdue
    on Apr 3, 2024
  15. melvin-bot
    assigned
    AndrewGable
    on Apr 3, 2024

  16. melvin-bot commented on Apr 3, 2024

    @melvin-bot
    melvin-botBot
    on Apr 3, 2024 – with Melvin Bot
    Author

    Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  17. melvin-bot
    added
    NewFeatureSomething to build that is a new item.
    on Apr 4, 2024
  18. melvin-bot
    assigned
    CortneyOfstad
    on Apr 4, 2024

  19. melvin-bot commented on Apr 4, 2024

    @melvin-bot
    melvin-botBot
    on Apr 4, 2024 – with Melvin Bot
    Author

    Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

  20. CortneyOfstad commented on Apr 17, 2024

    @CortneyOfstad
    CortneyOfstad
    on Apr 17, 2024
    Contributor

    PR has been merged and no payment needed as it was through CS. Closing!

  21. CortneyOfstad
    closed this as completedon Apr 17, 2024
  22. github-project-automation
    moved this from Todo to Done in Typescript migrationon Apr 17, 2024

  23. ishpaul777 commented on May 14, 2024

    @ishpaul777
    ishpaul777
    on May 14, 2024
    Contributor

    Hey @CortneyOfstad I reviewed the PR for this #39011, Can we please reopen for payment : )

  24. roryabraham
    reopened this on May 15, 2024

  25. CortneyOfstad commented on May 15, 2024

    @CortneyOfstad
    CortneyOfstad
    on May 15, 2024
    Contributor

    @ishpaul777 — just sent over an offer link via Upwork (job post is here) — let me know once you accept and I can get that paid for you ASAP. Thanks!

  26. CortneyOfstad commented on May 20, 2024

    @CortneyOfstad
    CortneyOfstad
    on May 20, 2024
    Contributor

    Payment has been completed and this can be closed – thanks!

  27. CortneyOfstad
    closed this as completedon May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

NewFeatureSomething to build that is a new item.Not a priorityReviewingHas a PR in reviewTaskTypescript MigrationWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions