Skip to content

[HOLD for payment 2024-04-25] [TS migration] Migrate 'Sidebar' page to TypeScript #25220

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-25] [TS migration] Migrate 'Sidebar' page to TypeScript#25220
Assignees
AndrewGableslafortunestephanieelliottSanthosh-Sellavel
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.Not a priorityTaskTypescript Migration

Activity

  1. melvin-bot
    added
    Task
    Typescript Migration
    WeeklyKSv2
    on Aug 17, 2023
  2. github-project-automation
    added this to Typescript migrationon Aug 17, 2023
  3. melvin-bot
    removed
    WeeklyKSv2
    on Sep 11, 2023

  4. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    melvin-botBot
    on Sep 11, 2023
    Author

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  5. melvin-bot
    added
    MonthlyKSv2
    on Sep 11, 2023
  6. roryabraham
    moved this to Todo in Typescript migrationon Sep 12, 2023

  7. melvin-bot commented on Nov 23, 2023

    @melvin-bot
    melvin-botBot
    on Nov 23, 2023 – with Melvin Bot
    Author

    @melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  8. melvin-bot
    closed this as completedon Nov 23, 2023
  9. melvin-bot
    added
    Not a priority
    on Nov 23, 2023
  10. github-project-automation
    moved this from Todo to Done in Typescript migrationon Nov 23, 2023
  11. melvin-bot
    reopened this on Nov 23, 2023

  12. fabioh8010 commented on Nov 28, 2023

    @fabioh8010
    fabioh8010
    on Nov 28, 2023
    Contributor

    Updated List

    Files

    Path Dependencies
    src/pages/safeAreaInsetPropTypes.js 1
    src/pages/home/sidebar/SignInOrAvatarWithOptionalStatus.js 9
    src/pages/home/sidebar/SignInButton.js 8
    src/pages/home/sidebar/SidebarNavigationContext.js 0
    src/pages/home/sidebar/SidebarLinksData.js 18
    src/pages/home/sidebar/SidebarLinks.js 30
    src/pages/home/sidebar/PressableAvatarWithIndicator.js 16
    src/pages/home/sidebar/AvatarWithOptionalStatus.js 11
    src/pages/home/sidebar/SidebarScreen/sidebarPropTypes.js 1
    src/pages/home/sidebar/SidebarScreen/index.native.js 6
    src/pages/home/sidebar/SidebarScreen/index.js 6
    src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js 27
    src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.js 10
  13. roryabraham
    moved this from Done to Todo in Typescript migrationon Nov 29, 2023

  14. 46 remaining items

  15. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot
    Author

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Santhosh-Sellavel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  17. stephanieelliott
    added
    NewFeatureSomething to build that is a new item.
    and removed
    NewFeatureSomething to build that is a new item.
    on Apr 23, 2024
  18. melvin-bot
    assigned
    slafortune
    on Apr 23, 2024

  19. melvin-bot commented on Apr 23, 2024

    @melvin-bot
    melvin-botBot
    on Apr 23, 2024 – with Melvin Bot
    Author

    Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  20. stephanieelliott commented on Apr 23, 2024

    @stephanieelliott
    stephanieelliott
    on Apr 23, 2024
    Contributor

    Reapplying the New Feature label to get another BZ member on this while I am OOO til May 2. Thanks @slafortune, nothing to do here but issue payment to C+ on 4/25!

  21. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 24, 2024

  22. melvin-bot commented on Apr 25, 2024

    @melvin-bot
    melvin-botBot
    on Apr 25, 2024 – with Melvin Bot
    Author

    Payment Summary

    Upwork Job

    BugZero Checklist (@slafortune)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  23. slafortune commented on Apr 26, 2024

    @slafortune
    slafortune
    on Apr 26, 2024
    Contributor

    @Santhosh-Sellavel can you please accept the offer here and complete the checklist -

  24. Santhosh-Sellavel commented on Apr 27, 2024

    @Santhosh-Sellavel
    Santhosh-Sellavel
    on Apr 27, 2024
    Collaborator

    No Regression Steps needed here as its a migration

  25. Santhosh-Sellavel commented on Apr 27, 2024

    @Santhosh-Sellavel
    Santhosh-Sellavel
    on Apr 27, 2024
    Collaborator

    I'll collect this one on upwork, accepted the offer!

  26. slafortune commented on Apr 29, 2024

    @slafortune
    slafortune
    on Apr 29, 2024
    Contributor

    Paid

  27. slafortune
    closed this as completedon Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.Not a priorityTaskTypescript Migration

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions