[HOLD for payment 2023-08-30] [$1000] Date is incorrect after editing money request

@mountiny

cc @mountiny

Action Performed:

Request money from another user
Edit the money request date
Verify that the selected date is incorrect after you tap Save

Expected Result:

Date is correct

Actual Result:

Date is incorrect

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Screen.Recording.2023-08-17.at.5.05.01.PM.mov

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0154a57cff1cce910b
Upwork Job ID: 1692296957389250560
Last Price Increase: 2023-08-17
Automatic offers:

ShogunFire | Contributor | 26196211

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~0154a57cff1cce910b

@stephanieelliott

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

@ArekChr

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

After editing a money request the date is incorrect

What is the root cause of that problem?

The root cause is that we are using TransactionUtils.getCreated to get the date and in that function we transform the string representing the date to a date object using new Date(). In javascript using new Date without the time can make the date component not use the local timezone (the timezone depends of the format) which can result in having a day off.

What changes do you think we should make in order to solve the problem?

We can use the method parseISO of date-fns to parse the date like this

const createdDate = parseISO(created)

if (createdDate) {
    return format(createdDate, CONST.DATE.FNS_FORMAT_STRING);
}

What alternative solutions did you explore? (Optional)

We can add the time behind the date like this T00:00 to force it to use the local date

@ShogunFire

Wow nice @ShogunFire

We can also pass the date with a format that avoid this weird behaviour, for example we can transform our string like this yyyy/mm/dd by replacing - with /

I think this is interesting but just curios if there is anything else we can use without some special treatment. Is there some param we can pass to the Date() maybe? Or use something from the date-fns? cc @waterim

@JmillsExpensify

Friendly bump @JmillsExpensify

@JmillsExpensify

@JmillsExpensify, @ShogunFire, @ArekChr, @mountiny Eep! 4 days overdue now. Issues have feelings too...

@ShogunFire

Confirming that the payment due to @ShogunFire (Pierre M) is $1500 here, correct? @JmillsExpensify @mountiny?

@JmillsExpensify

@JmillsExpensify, @ShogunFire, @ArekChr, @mountiny Still overdue 6 days?! Let's take care of this!

@sophiepintoraetz

@sophiepintoraetz that is correct, thanks for helping

Payment done - is there anything else keeping this issue open?

Ah so sorry for the delay on this one. Don't hesitate to reach out to me via New Expensify DM.

@ArekChr

In any case, @ArekChr I don't see a BZ checklist completed for this issue? Do you mind completing one, including whether a regression test is required? Thank you!

Link to the PR: No bug identified.
Link to comment: n/a
Link to discussion: n/a
Determine if we should create a regression test for this bug: I don’t think we need to add a regression test here.

Great thank you! All done here.

Navigation Menu

Repository navigation

[HOLD for payment 2023-08-30] [$1000] Date is incorrect after editing money request #25441

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

50 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-08-30] [$1000] Date is incorrect after editing money request #25441

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 17, 2023

melvin-bot commented on Aug 17, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Aug 17, 2023

melvin-bot commented on Aug 17, 2023

melvin-bot commented on Aug 17, 2023

ShogunFire commented on Aug 17, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mountiny commented on Aug 17, 2023

50 remaining items

ShogunFire commented on Sep 12, 2023

melvin-bot commented on Sep 18, 2023

sophiepintoraetz commented on Sep 20, 2023

melvin-bot commented on Sep 20, 2023

mountiny commented on Sep 21, 2023

sophiepintoraetz commented on Sep 21, 2023

JmillsExpensify commented on Sep 21, 2023

JmillsExpensify commented on Sep 21, 2023

ArekChr commented on Sep 21, 2023

JmillsExpensify commented on Sep 25, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions