[HOLD for payment 2023-08-28] [$500] Request money - The app crashes when user deleted the request money

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Launch app
Tap Fab
Tap request money
Tap enter any amount
Tap next
Select any user
Tap Request money
Tap last transaction to open the last requested money page
Tap the money requested
In IOU details page, tap 3 dots to select "delete request"
Tap delete request

Expected Result:

The request money should be deleted

Actual Result:

The app crashes when user deleted the request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.55-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6168801_new_crash.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Ingernal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b8ef599b7ac8134d
Upwork Job ID: 1692480853057089536
Last Price Increase: 2023-08-18
Automatic offers:

abdulrahuman5196 | Reviewer | 26194635
pradeepmdk | Contributor | 26194639

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@robertjchen

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Request money - The app crashes when the user deleted the request money]

What is the root cause of that problem?

after delete request title is 0 here 0 is number

App/src/components/MenuItem.js

Line 134 in 404cefb

accessibilityLabel={props.title}

this PR add this https://github.com/Expensify/App/pull/20251/files accessibilityLabel

What changes do you think we should make in order to solve the problem?

we need fix the type to string here accessibilityLabel
possiblity to get title is null or undefined

                    accessibilityLabel={props.title ? props.title.toString() : ''}

we need fix below those as well. all should be an type error only.

result

Screen.Recording.2023-08-18.at.10.35.57.AM.mov

Job added to Upwork: https://www.upwork.com/jobs/~01b8ef599b7ac8134d

@flaviadefaria

Triggered auto assignment to @flaviadefaria (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@pradeepmdk

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP staging] Request money - The app crashes when user deleted the request money #25468

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@pradeepmdk requires payment offer (Contributor)
@abdulrahuman5196 requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@abdulrahuman5196

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify / @flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

I'm catching up from being OOO, I will prepare the payment steps.

@pradeepmdk

Here is the payment summary:

External issue reporter - N/A
Contributor that fixed the issue - @pradeepmdk $750
Contributor+ that helped on the issue and/or PR - @abdulrahuman5196 $750

Upwork Job: https://www.upwork.com/jobs/~01b8ef599b7ac8134d

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: The amount is less per @mountiny's feedback here but there is an urgency bonus. I'm calculating half of the base amount of $500 equals $250, so the final amount given would be $750.

Let me know if there is any feedback or else I will complete the payment tomorrow. Thanks!

@abdulrahuman5196

Everyone has been paid in Upwork. @abdulrahuman5196 please complete the checklist and we can close ou this GH. Thanks!

@abdulrahuman5196

@abdulrahuman5196 - we are waiting to close this GH until the checklist is complete, can we get an update soon? Thanks!

@alexpensify

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/20251/files#r1314735902

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. This is a minor fix and won't be beneficial to add regression test case.

@alexpensify Sorry for the delay. Completed the checklist

Thanks! I'm going to close now-- great work team.

Navigation Menu

Repository navigation

[HOLD for payment 2023-08-28] [$500] Request money - The app crashes when user deleted the request money #25451

Action Performed:

Expected Result:

Actual Result:

Workaround: