Skip to content

[HOLD for payment 2023-09-29] [Performance] Improve SidebarLinks by caching getOrderedReportIDs #25467

Closed

Description

@mountiny

Coming from here

[Performance] Improve SidebarLinks:

Problem

Now all the Records to show on LHN are being calculated multiple times and the logic to fill it is complex, this one is a bit trickier to solve but I think it worth it

Solution

Summary

getOrderedReportIDs is a complex function that would be good to re-architecture.
Applying just caching like I did, isn’t the full solution, it gives me a good number to know if worth taking the time to improve it, and even if we aim to get ~40% to ~50% of improvement will be awesome

Activity

  1. self-assigned this
    on Aug 18, 2023
  2. added and removed on Aug 21, 2023
  3. mountiny commented on Aug 21, 2023

    @mountiny
    ContributorAuthor

    Asking in callstack room who will take these on

  4. waterim commented on Aug 22, 2023

    @waterim
    Contributor

    Hello, Im Artem from Callstack and would like to help with this one

  5. added and removed on Aug 23, 2023
  6. mountiny commented on Aug 23, 2023

    @mountiny
    ContributorAuthor

    Making this daily as the getOrderedReportIDs is one of the main offenders when it comes to performance for accounts with thousands reports

  7. 33 remaining items

  8. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    @mountiny, @waterim Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2023
  10. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  11. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  12. mountiny commented on Oct 2, 2023

    @mountiny
    ContributorAuthor

    No checklist required, this is a performance improvement

    @parasharrajat is due $500 for internal review

  13. alexpensify commented on Oct 2, 2023

    @alexpensify
    Contributor

    Here is the payment summary:

    • External issue reporter - N/A
    • Contributor that fixed the issue - N/A
    • Contributor+ that helped on the issue and/or PR - @parasharrajat $500

    Upwork Job: N/A

    *If applicable, the bonuses will be applied on the final payment

    Extra Notes regarding payment: See the notes here - #25467 (comment)

    @parasharrajat please request a payment in Chat and then we can close this out. Thanks!

  14. alexpensify commented on Oct 4, 2023

    @alexpensify
    Contributor

    Ok, going to close out here.

  15. parasharrajat commented on Oct 8, 2023

    @parasharrajat
    Member

    Payment requested as per #25467 (comment)

  16. JmillsExpensify commented on Oct 9, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @parasharrajat based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions