You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-29] [Performance] Improve SidebarLinks by caching getOrderedReportIDs #25467
Now all the Records to show on LHN are being calculated multiple times and the logic to fill it is complex, this one is a bit trickier to solve but I think it worth it
Solution
Summary
getOrderedReportIDs is a complex function that would be good to re-architecture.
Applying just caching like I did, isn’t the full solution, it gives me a good number to know if worth taking the time to improve it, and even if we aim to get ~40% to ~50% of improvement will be awesome
Activity
mountiny commentedon Aug 21, 2023
Asking in callstack room who will take these on
waterim commentedon Aug 22, 2023
Hello, Im Artem from Callstack and would like to help with this one
mountiny commentedon Aug 23, 2023
Making this daily as the getOrderedReportIDs is one of the main offenders when it comes to performance for accounts with thousands reports
33 remaining items
melvin-bot commentedon Oct 2, 2023
@mountiny, @waterim Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)mountiny commentedon Oct 2, 2023
No checklist required, this is a performance improvement
@parasharrajat is due $500 for internal review
alexpensify commentedon Oct 2, 2023
Here is the payment summary:
Upwork Job: N/A
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: See the notes here - #25467 (comment)
@parasharrajat please request a payment in Chat and then we can close this out. Thanks!
alexpensify commentedon Oct 4, 2023
Ok, going to close out here.
parasharrajat commentedon Oct 8, 2023
Payment requested as per #25467 (comment)
JmillsExpensify commentedon Oct 9, 2023
$500 payment approved for @parasharrajat based on BZ summary.