Skip to content

[HOLD for payment 2023-09-27] [HOLD App#21664] [$500] Update the request description to be handled similarly as task description #25494

Closed

Description

@mountiny

Problem

When the description of a request is long, we only show one line in the details and in the edit input and we truncate what does not fit
image

Thats not ideal

### Solution

Lets mimic task description field for this one in both the moneyRequestView and in the edit form
image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0160a97b98c4b48f40
  • Upwork Job ID: 1692628331709181952
  • Last Price Increase: 2023-08-18
  • Automatic offers:
    • daordonez11 | Contributor | 26204376

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 18, 2023
  2. self-assigned this
    on Aug 18, 2023
  3. melvin-bot commented on Aug 18, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Aug 18, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. mountiny commented on Aug 18, 2023

    @mountiny
    ContributorAuthor

    Might handle it on my own

  6. daordonez11 commented on Aug 18, 2023

    @daordonez11
    Contributor

    Proposal based on desired experience by @mountiny

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    We should unify the experience in both Task and IOU

    What is the root cause of that problem?

    Even though both pages use practically the same components styles are different so user has a different experience in both components TaskView and MoneyRequestView

    What changes do you think we should make in order to solve the problem?

    Step 1 Report:
    In MoneyRequestViewinclude wrapperStyle={[styles.pv2, styles.taskDescriptionMenuItem]} in the description element copying the styles of TaskView

    Step 2 Edit Desc:
    In EditRequestDescriptionPage include this in the props of the TextInput emulating the style of TaskDescriptionPage

    autoGrowHeight
    containerStyles={[styles.autoGrowHeightMultilineInput]}
    textAlignVertical="top"

    Solution working:

    image

    What alternative solutions did you explore? (Optional)

    Maybe create an extension of MenuItemWithTopDescription specific for attributes that might be long so it can be reused in other components but not sure if it is a bit of overengineering for this case

  7. JmillsExpensify commented on Aug 18, 2023

    @JmillsExpensify
    Contributor

    Taking this as part of wave3

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 18, 2023
  9. changed the title [-]Update the request description to be handled similarly as task description[/-] [+][$1000] Update the request description to be handled similarly as task description[/+] on Aug 18, 2023
  10. 47 remaining items

  11. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-27. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@burczu] The PR that introduced the bug has been identified. Link to the PR:
    • [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@burczu] Determine if we should create a regression test for this bug.
    • [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. burczu commented on Sep 26, 2023

    @burczu
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@burczu] The PR that introduced the bug has been identified. Link to the PR: I think it worked this way from the beginning.
    • [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
    • [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
    • [@burczu] Determine if we should create a regression test for this bug.
    • [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    @JmillsExpensify, @burczu, @daordonez11, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. melvin-bot commented on Oct 3, 2023

    @melvin-bot

    @JmillsExpensify, @burczu, @daordonez11, @mountiny 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  17. mountiny commented on Oct 4, 2023

    @mountiny
    ContributorAuthor

    @JmillsExpensify bump on this one please. Its $500 to @daordonez11 only.

  18. JmillsExpensify commented on Oct 7, 2023

    @JmillsExpensify
    Contributor

    Payment summary: $500 payment to @daordonez11. Just sent an offer as well!

  19. JmillsExpensify commented on Oct 8, 2023

    @JmillsExpensify
    Contributor

    All paid out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions