You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-27] [HOLD App#21664] [$500] Update the request description to be handled similarly as task description #25494
Please re-state the problem that we are trying to solve in this issue.
We should unify the experience in both Task and IOU
What is the root cause of that problem?
Even though both pages use practically the same components styles are different so user has a different experience in both components TaskView and MoneyRequestView
What changes do you think we should make in order to solve the problem?
Step 1 Report:
In MoneyRequestViewinclude wrapperStyle={[styles.pv2, styles.taskDescriptionMenuItem]} in the description element copying the styles of TaskView
Step 2 Edit Desc:
In EditRequestDescriptionPage include this in the props of the TextInput emulating the style of TaskDescriptionPage
What alternative solutions did you explore? (Optional)
Maybe create an extension of MenuItemWithTopDescription specific for attributes that might be long so it can be reused in other components but not sure if it is a bit of overengineering for this case
changed the title [-]Update the request description to be handled similarly as task description[/-][+][$1000] Update the request description to be handled similarly as task description[/+]on Aug 18, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@burczu] The PR that introduced the bug has been identified. Link to the PR:
[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@burczu] The PR that introduced the bug has been identified. Link to the PR: I think it worked this way from the beginning.
[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Aug 18, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 18, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)mountiny commentedon Aug 18, 2023
Might handle it on my own
daordonez11 commentedon Aug 18, 2023
Proposal based on desired experience by @mountiny
Proposal
Please re-state the problem that we are trying to solve in this issue.
We should unify the experience in both Task and IOU
What is the root cause of that problem?
Even though both pages use practically the same components styles are different so user has a different experience in both components
TaskViewandMoneyRequestViewWhat changes do you think we should make in order to solve the problem?
Step 1 Report:
In
MoneyRequestViewincludewrapperStyle={[styles.pv2, styles.taskDescriptionMenuItem]}in the description element copying the styles ofTaskViewStep 2 Edit Desc:
In
EditRequestDescriptionPageinclude this in the props of the TextInput emulating the style ofTaskDescriptionPageSolution working:
What alternative solutions did you explore? (Optional)
Maybe create an extension of
MenuItemWithTopDescriptionspecific for attributes that might be long so it can be reused in other components but not sure if it is a bit of overengineering for this caseJmillsExpensify commentedon Aug 18, 2023
Taking this as part of wave3
[-]Update the request description to be handled similarly as task description[/-][+][$1000] Update the request description to be handled similarly as task description[/+]47 remaining items
melvin-bot commentedon Sep 20, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 20, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
burczu commentedon Sep 26, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Sep 29, 2023
@JmillsExpensify, @burczu, @daordonez11, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Oct 3, 2023
@JmillsExpensify, @burczu, @daordonez11, @mountiny 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
mountiny commentedon Oct 4, 2023
@JmillsExpensify bump on this one please. Its $500 to @daordonez11 only.
JmillsExpensify commentedon Oct 7, 2023
Payment summary: $500 payment to @daordonez11. Just sent an offer as well!
JmillsExpensify commentedon Oct 8, 2023
All paid out!