Skip to content

[HOLD for @0xmiroslav payment] [$2000] Request Money modal closed when selecting currency for new request or edit #25626

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. Click on FAB
  2. Request Money
  3. On the amount page, click the currency symbol to change the currency
  4. Select some other currency

Expected Result:

Describe what you think should've happened

You are back on the amount page with selected currency

Actual Result:

Describe what actually happened

The modal has closed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01732c4f8d4d117765
  • Upwork Job ID: 1694010840997621760
  • Last Price Increase: 2023-08-31
  • Automatic offers:
    • 0xmiroslav | Reviewer | 26452949
    • shubham1206agra | Contributor | 26452951

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 21, 2023
  2. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 21, 2023
  5. OSBotify commented on Aug 21, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. OSBotify commented on Aug 21, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 125 remaining items

  9. abekkala commented on Sep 11, 2023

    @abekkala
    Contributor

    @parasharrajat ah yes, I see now that you get paid via Expensify Chat

  10. abekkala commented on Sep 14, 2023

    @abekkala
    Contributor

    not overdue - waiting on further guidance on payment

  11. JmillsExpensify commented on Sep 21, 2023

    @JmillsExpensify
    Contributor

    $250 payment for @parasharrajat approved based on BZ summary.

  12. abekkala commented on Sep 29, 2023

    @abekkala
    Contributor

    STATUS:
    Waiting on @0xmiroslav.
    https://expensify.slack.com/archives/C01SKUP7QR0/p1695166357917099?thread_ts=1694206723.155449&cid=C01SKUP7QR0

    Please ping me here when you're able to accept payments in Upwork.

  13. changed the title [-][HOLD for payment 2023-09-11] [HOLD for payment 2023-09-08] [$2000] Request Money modal closed when selecting currency for new request or edit[/-] [+][HOLD for @0xmiroslav payment] [$2000] Request Money modal closed when selecting currency for new request or edit[/+] on Sep 29, 2023
  14. abekkala commented on Oct 31, 2023

    @abekkala
    Contributor

    @0xmiroslav are you ready to accept payments via Upwork yet?

  15. 0xmiroslav commented on Oct 31, 2023

    @0xmiroslav
    Contributor

    Let's close this for now. I am tracking locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions