Skip to content

[HOLD for payment 2023-09-04] [$1000] Split Bill - All user names are showing in IOU #25640

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access staging.new.epensify.com
  2. Sign into a valid account
  3. Split bill

Expected Result:

User expects that the preview shows the users images and not names

Actual Result:

All split bill user names and date is displayed in the IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6172869_On_Staging Bug6172869_On_PROD

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017a8059f6b6485a78
  • Upwork Job ID: 1693876610499690496
  • Last Price Increase: 2023-08-22
  • Automatic offers:
    • jjcoffee | Reviewer | 26263054
    • s-alves10 | Contributor | 26263056

Activity

  1. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. pradeepmdk commented on Aug 22, 2023

    @pradeepmdk
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Split Bill - All user names are showing in IOU

    What is the root cause of that problem?

    Screenshot 2023-08-22 at 7 09 38 AM

    merchant: TransactionUtils.getMerchant(transaction),

    based on its showing the merchant name
    this pr enabled the merchant https://github.com/Expensify/App/pull/25449/files

    What changes do you think we should make in order to solve the problem?

    `${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,

    here we are generating the merchant and pass

    merchant: merchant || CONST.REPORT.TYPE.IOU,

    and here we are using that

    {requestMerchant && (
    <View style={[styles.flexRow]}>
    <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh16]}>{requestMerchant}</Text>
    </View>
    )}

    !_.isEmpty(requestMerchant) && requestMerchant === CONST.REPORT.TYPE.IOU 

    we need to add a condition here it will show only CONST.REPORT.TYPE.IOU,

  4. dummy-1111 commented on Aug 22, 2023

    @dummy-1111
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    All user names appears in split bill

    What is the root cause of that problem?

    This is a regression from this PR

    We create merchant info optimistically when we create split bill here

    `${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,

    We show merchant info below

    {requestMerchant && (
    <View style={[styles.flexRow]}>
    <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh16]}>{requestMerchant}</Text>
    </View>
    )}

    This is the root cause

    What changes do you think we should make in order to solve the problem?

    I don't think we need to show merchant information in money request preview

    Replacing the merchant part in the MoneyRequestPreview will solve the issue

    with

     {!props.isBillSplit && requestMerchant && ( 
         <View style={[styles.flexRow]}> 
             <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh16]}>{requestMerchant}</Text> 
         </View> 
     )}
    

    This works as expected

    What alternative solutions did you explore? (Optional)

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 22, 2023
  6. changed the title [-]Split Bill - All user names are showing in IOU[/-] [+][$1000] Split Bill - All user names are showing in IOU[/+] on Aug 22, 2023
  7. melvin-bot commented on Aug 22, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 22, 2023
  9. 32 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 28, 2023
  11. changed the title [-][$1000] Split Bill - All user names are showing in IOU[/-] [+][HOLD for payment 2023-09-04] [$1000] Split Bill - All user names are showing in IOU[/+] on Aug 28, 2023
  12. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-04. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. jjcoffee commented on Sep 5, 2023

    @jjcoffee
    Contributor

    @michaelhaxhiu Gentle bump for payment on this. Thanks!

  15. michaelhaxhiu commented on Sep 6, 2023

    @michaelhaxhiu
    Contributor

    I apologize for the delay!

  16. michaelhaxhiu commented on Sep 6, 2023

    @michaelhaxhiu
    Contributor

    both paid, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions