You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-04] [$1000] Split Bill - All user names are showing in IOU #25640
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$1000] Split Bill - All user names are showing in IOU[/-][+][HOLD for payment 2023-09-04] [$1000] Split Bill - All user names are showing in IOU[/+]on Aug 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
Activity
OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.pradeepmdk commentedon Aug 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Split Bill - All user names are showing in IOU
What is the root cause of that problem?
App/src/libs/ReportUtils.js
Line 1249 in c053381
based on its showing the merchant name
this pr enabled the
merchanthttps://github.com/Expensify/App/pull/25449/filesWhat changes do you think we should make in order to solve the problem?
App/src/libs/actions/IOU.js
Line 627 in c053381
here we are generating the merchant and pass
App/src/libs/TransactionUtils.js
Line 69 in c053381
and here we are using that
App/src/components/ReportActionItem/MoneyRequestPreview.js
Lines 257 to 261 in 120bcbf
we need to add a condition here it will show only
CONST.REPORT.TYPE.IOU,dummy-1111 commentedon Aug 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
All user names appears in split bill
What is the root cause of that problem?
This is a regression from this PR
We create merchant info optimistically when we create split bill here
App/src/libs/actions/IOU.js
Line 627 in 120bcbf
We show merchant info below
App/src/components/ReportActionItem/MoneyRequestPreview.js
Lines 257 to 261 in 120bcbf
This is the root cause
What changes do you think we should make in order to solve the problem?
I don't think we need to show merchant information in money request preview
Replacing the merchant part in the MoneyRequestPreview will solve the issue
with
This works as expected
What alternative solutions did you explore? (Optional)
[-]Split Bill - All user names are showing in IOU[/-][+][$1000] Split Bill - All user names are showing in IOU[/+]melvin-bot commentedon Aug 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017a8059f6b6485a78
32 remaining items
[-][$1000] Split Bill - All user names are showing in IOU[/-][+][HOLD for payment 2023-09-04] [$1000] Split Bill - All user names are showing in IOU[/+]melvin-bot commentedon Aug 28, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
jjcoffee commentedon Sep 5, 2023
@michaelhaxhiu Gentle bump for payment on this. Thanks!
michaelhaxhiu commentedon Sep 6, 2023
I apologize for the delay!
michaelhaxhiu commentedon Sep 6, 2023
both paid, closing!