You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-07] [$1000] Web - Money Request - Dev - On money request page distance page user is able drag & drop file #25661
Please re-state the problem that we are trying to solve in this issue.
On money request page distance page user is able drag & drop file
What is the root cause of that problem?
The root cause is we are using <DragAndDropProvider> component on MoneyRequestSelectorPage which is where all 3 tabs are defined here we have handled disabled drag and drop for the manual tab and not handled for distance tab that makes the user allow drag on that tab
What changes do you think we should make in order to solve the problem?
option - 1
On the below line we can just add one more condition to check if the selected tab is CONST.TAB.DISTANCE then we should pass true on isDisabled props of DragAndDropProvider
isDisabled={props.selectedTab===CONST.TAB.MANUAL||props.selectedTab===CONST.TAB.DISTANCE}// example
On the below line we can add a condition whereby we enable drag & drop only if the tab selected is CONST.TAB.SCAN I believe only this tab needs to enable the drag & drop functionality
changed the title [-]Web - Money Request - Dev - On money request page distance page user is able drag & drop file[/-][+][$1000] Web - Money Request - Dev - On money request page distance page user is able drag & drop file[/+]on Aug 22, 2023
+1 to izarutskaya's proposal option 2. Proposal option 2 is better than option 1 since explicit whitelisting instead of blacklisting will prevent exactly this type of errors in the future. There just might be a typo in proposal option 2 as it should be: <DragAndDropProvider isDisabled={props.selectedTab !== CONST.TAB.SCAN}>
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)izarutskaya commentedon Aug 22, 2023
Proposal from @dhairyasenjaliya
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
<DragAndDropProvider>component onMoneyRequestSelectorPagewhich is where all 3 tabs are defined here we have handled disabled drag and drop for the manual tab and not handled for distance tab that makes the user allow drag on that tabWhat changes do you think we should make in order to solve the problem?
option - 1
CONST.TAB.DISTANCEthen we should pass true onisDisabledprops of DragAndDropProviderApp/src/pages/iou/MoneyRequestSelectorPage.js
Line 83 in a2096c8
option -2
CONST.TAB.SCANI believe only this tab needs to enable the drag & drop functionalityApp/src/pages/iou/MoneyRequestSelectorPage.js
Line 83 in a2096c8
What alternative solutions did you explore? (Optional)
———————
[-]Web - Money Request - Dev - On money request page distance page user is able drag & drop file[/-][+][$1000] Web - Money Request - Dev - On money request page distance page user is able drag & drop file[/+]melvin-bot commentedon Aug 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0106fe9a0ed877de3e
melvin-bot commentedon Aug 22, 2023
Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)garrettmknight commentedon Aug 22, 2023
Confirmed, seems like odd behavior.
MaciejSWM commentedon Aug 23, 2023
+1 to izarutskaya's proposal option 2. Proposal option 2 is better than option 1 since explicit whitelisting instead of blacklisting will prevent exactly this type of errors in the future. There just might be a typo in proposal option 2 as it should be:
<DragAndDropProvider isDisabled={props.selectedTab !== CONST.TAB.SCAN}>30 remaining items
melvin-bot commentedon Aug 31, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 31, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
fedirjh commentedon Sep 8, 2023
BugZero Checklist:
Regression Test Proposal
garrettmknight commentedon Sep 11, 2023
Summary of payments
garrettmknight commentedon Sep 11, 2023
@dhairyasenjaliya just realized that we didn't generate a contract for reporting. I just sent you another offer and will pay the $250 once you accept.
dhairyasenjaliya commentedon Sep 11, 2023
done @garrettmknight I think there was previous contract but will cancel that
garrettmknight commentedon Sep 12, 2023
Paid and canceled the duplicate contract.
dhairyasenjaliya commentedon Sep 12, 2023
@garrettmknight can you please close the contract as well thanx