Skip to content

[HOLD for payment 2023-09-07] [$1000] Web - Money Request - Dev - On money request page distance page user is able drag & drop file #25661

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to the money request page
  2. Select Distance tab
  3. Drag file to this tab
  4. Notice use is able to drag & drop file on distance page and can request money directly

Expected Result:

User should not be able to drag & drop files directly on Distance tab same as manually tab

Actual Result:

Describe what actually happened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.56-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-12.At.1.50.41.Am.1.mp4
Recording.2948.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhairyasenjaliya

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691785104348009

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0106fe9a0ed877de3e
  • Upwork Job ID: 1693995295563288576
  • Last Price Increase: 2023-08-22
  • Automatic offers:
    • fedirjh | Reviewer | 26292940
    • dhairyasenjaliya | Contributor | 26292941
    • dhairyasenjaliya | Reporter | 26292942

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2023
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. izarutskaya commented on Aug 22, 2023

    @izarutskaya
    Author

    Proposal from @dhairyasenjaliya

    Please re-state the problem that we are trying to solve in this issue.

    • On money request page distance page user is able drag & drop file

    What is the root cause of that problem?

    • The root cause is we are using <DragAndDropProvider> component on MoneyRequestSelectorPage which is where all 3 tabs are defined here we have handled disabled drag and drop for the manual tab and not handled for distance tab that makes the user allow drag on that tab

    What changes do you think we should make in order to solve the problem?

    option - 1

    • On the below line we can just add one more condition to check if the selected tab is CONST.TAB.DISTANCE then we should pass true on isDisabled props of DragAndDropProvider
    isDisabled={props.selectedTab === CONST.TAB.MANUAL || props.selectedTab === CONST.TAB.DISTANCE} // example

    <DragAndDropProvider isDisabled={props.selectedTab === CONST.TAB.MANUAL}>

    option -2

    • On the below line we can add a condition whereby we enable drag & drop only if the tab selected is CONST.TAB.SCAN I believe only this tab needs to enable the drag & drop functionality
      <DragAndDropProvider isDisabled={props.selectedTab === CONST.TAB.MANUAL}>

    What alternative solutions did you explore? (Optional)

    • N/A
      ———————
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 22, 2023
  6. changed the title [-]Web - Money Request - Dev - On money request page distance page user is able drag & drop file[/-] [+][$1000] Web - Money Request - Dev - On money request page distance page user is able drag & drop file[/+] on Aug 22, 2023
  7. melvin-bot commented on Aug 22, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 22, 2023
  9. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  11. garrettmknight commented on Aug 22, 2023

    @garrettmknight
    Contributor

    Confirmed, seems like odd behavior.

  12. MaciejSWM commented on Aug 23, 2023

    @MaciejSWM
    Contributor

    +1 to izarutskaya's proposal option 2. Proposal option 2 is better than option 1 since explicit whitelisting instead of blacklisting will prevent exactly this type of errors in the future. There just might be a typo in proposal option 2 as it should be: <DragAndDropProvider isDisabled={props.selectedTab !== CONST.TAB.SCAN}>

  13. 30 remaining items

  14. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. fedirjh commented on Sep 8, 2023

    @fedirjh
    Contributor

    BugZero Checklist:


    Regression Test Proposal

    1. Open App
    2. Navigate to the money request page
    3. Select the Distance tab
    4. Drag any file to this tab
    5. Verify that the user can't drag & drop a file on the distance page
    • Do we agree 👍 or 👎
  18. garrettmknight commented on Sep 11, 2023

    @garrettmknight
    Contributor

    Summary of payments

  19. garrettmknight commented on Sep 11, 2023

    @garrettmknight
    Contributor

    @dhairyasenjaliya just realized that we didn't generate a contract for reporting. I just sent you another offer and will pay the $250 once you accept.

  20. dhairyasenjaliya commented on Sep 11, 2023

    @dhairyasenjaliya
    Contributor

    done @garrettmknight I think there was previous contract but will cancel that

  21. garrettmknight commented on Sep 12, 2023

    @garrettmknight
    Contributor

    Paid and canceled the duplicate contract.

  22. dhairyasenjaliya commented on Sep 12, 2023

    @dhairyasenjaliya
    Contributor

    @garrettmknight can you please close the contract as well thanx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions