Skip to content

[HOLD for payment 2023-09-04] [$1000] System throws an error while requesting money if a long description & marchant value is given #25685

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open an existing chat
  2. Click on '+' icon
  3. Click on 'Request money' link
  4. Enter amount & click on 'Next' button
  5. Click on description > enter over 300 characters value > click on 'Save' button
  6. Click on 'Show more' button
  7. Click on Marchant > enter over 300 characters value > click on 'Save' button
  8. Click on 'Request' button

Expected Result:

Money requests should be successful

Actual Result:

System throws an error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

**Version Number:**1.3.56-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-08-22.09-20-48.mp4
Recording.381.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692686163590699

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016b3cd02197f18a6f
  • Upwork Job ID: 1694128412349935616
  • Last Price Increase: 2023-08-22
  • Automatic offers:
    • situchan | Contributor | 26273602
    • Natnael-Guchima | Reporter | 26273603
    • pradeepmdk | Contributor | 26273680

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2023
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. pradeepmdk commented on Aug 22, 2023

    @pradeepmdk
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    System throws an error while requesting money if a long description & marchant value is given

    What is the root cause of that problem?

    RequestMoney API this throwing size Exceeded
    Screenshot 2023-08-22 at 7 57 22 PM

    What changes do you think we should make in order to solve the problem?

    we need to limit the character length in the the UI


    maxLength

  7. 42 remaining items

  8. situchan commented on Aug 29, 2023

    @situchan
    Contributor

    PR was deployed to production on Aug 24

  9. isabelastisser commented on Sep 5, 2023

    @isabelastisser
    Contributor

    Offers sent in Upwork!

    @situchan, please complete the BZ checklist so we can close this issue. Thanks!

  10. isabelastisser commented on Sep 8, 2023

    @isabelastisser
    Contributor
  11. situchan commented on Sep 8, 2023

    @situchan
    Contributor

    No regression. Just missed this when implement merchant field.
    As this is rare case, I don't think regression test is needed.

  12. joelbettner commented on Sep 11, 2023

    @joelbettner
    Contributor

    Any news here?

  13. isabelastisser commented on Sep 11, 2023

    @isabelastisser
    Contributor

    Hey @situchan, can you please complete the rest of the checklist below? Thanks!

    [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

  14. situchan commented on Sep 11, 2023

    @situchan
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: N/A
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
  15. isabelastisser commented on Sep 11, 2023

    @isabelastisser
    Contributor

    All payments were made in Upwork.

    Payment summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions