You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-04] [$1000] System throws an error while requesting money if a long description & marchant value is given #25685
Click on description > enter over 300 characters value > click on 'Save' button
Click on 'Show more' button
Click on Marchant > enter over 300 characters value > click on 'Save' button
Click on 'Request' button
Expected Result:
Money requests should be successful
Actual Result:
System throws an error
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
**Version Number:**1.3.56-3 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Hey @situchan, can you please complete the rest of the checklist below? Thanks!
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Activity
melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @joelbettner (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.pradeepmdk commentedon Aug 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
System throws an error while requesting money if a long description & marchant value is given
What is the root cause of that problem?
RequestMoneyAPI this throwing size ExceededWhat changes do you think we should make in order to solve the problem?
we need to limit the character length in the the UI
App/src/pages/iou/MoneyRequestMerchantPage.js
Line 108 in c053381
maxLength42 remaining items
situchan commentedon Aug 29, 2023
PR was deployed to production on Aug 24
isabelastisser commentedon Sep 5, 2023
Offers sent in Upwork!
@situchan, please complete the BZ checklist so we can close this issue. Thanks!
isabelastisser commentedon Sep 8, 2023
Bump @situchan
situchan commentedon Sep 8, 2023
No regression. Just missed this when implement merchant field.
As this is rare case, I don't think regression test is needed.
joelbettner commentedon Sep 11, 2023
Any news here?
isabelastisser commentedon Sep 11, 2023
Hey @situchan, can you please complete the rest of the checklist below? Thanks!
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
situchan commentedon Sep 11, 2023
isabelastisser commentedon Sep 11, 2023
All payments were made in Upwork.
Payment summary: