Skip to content

[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee #25689

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch app
  2. Tap fab
  3. Tap assign task
  4. Enter title
  5. Tap next
  6. Select any user for Share somewhere
  7. Tap confirm task
  8. From the Confirmed Task screen
  9. Tap assignee
  10. Select any user - button unresponsive = you can't add an assignee

You can add an assignee by

Find a Task in the LHN > tap Assignee > you can assign one

Expected Result:

Tapping on any contact, user must be able to select assignee

Actual Result:

Tapping on any contact, user unable to select assignee

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173366_cache.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01198bfad5e1717772
  • Upwork Job ID: 1694077716312887296
  • Last Price Increase: 2023-08-29
  • Automatic offers:
    • shubham1206agra | Contributor | 26488545

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2023
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. akinwale commented on Aug 22, 2023

    @akinwale
    Contributor

    This looks like there is a long-running operation on the main thread which is blocking UI input for a few seconds before the tap to select a contact finally registers.

  5. changed the title [-]Assign task-Tapping on any contact, user unable to select assignee[/-] [+][Android] Assign task-Tapping on any contact, user unable to select assignee[/+] on Aug 22, 2023
  6. changed the title [-][Android] Assign task-Tapping on any contact, user unable to select assignee[/-] [+]Assign task-Tapping on any contact, user unable to select assignee[/+] on Aug 22, 2023
  7. Christinadobrzyn commented on Aug 22, 2023

    @Christinadobrzyn
    Contributor

    I can reproduce but this bug is inconsistent - but updated the OP to be as direct as possible on how to reproduce it. I think this can be External

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 22, 2023
  9. changed the title [-]Assign task-Tapping on any contact, user unable to select assignee[/-] [+][$1000] Assign task-Tapping on any contact, user unable to select assignee[/+] on Aug 22, 2023
  10. melvin-bot commented on Aug 22, 2023

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 22, 2023
  12. 56 remaining items

  13. changed the title [-][$1000] Assign task-Tapping on any contact, user unable to select assignee[/-] [+][HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee[/+] on Sep 14, 2023
  14. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
    • [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@robertKozik] Determine if we should create a regression test for this bug.
    • [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. Christinadobrzyn commented on Sep 15, 2023

    @Christinadobrzyn
    Contributor

    prepping for payment... @robertKozik should there be a regression test for this?

  18. Christinadobrzyn commented on Sep 22, 2023

    @Christinadobrzyn
    Contributor

    Also @cristipaval I see a merge freeze was involved in the PR merge, this might have affected the speed bonus. Do we think a speed bonus applies here?

  19. cristipaval commented on Sep 24, 2023

    @cristipaval
    Contributor

    Good point @Christinadobrzyn! Yes the speed bonus should apply, I checked the dates. I held the PR due to that merge freeze.

  20. robertKozik commented on Sep 25, 2023

    @robertKozik
    Contributor

    CC. @Christinadobrzyn

  21. Christinadobrzyn commented on Sep 26, 2023

    @Christinadobrzyn
    Contributor

    Payouts due:

    Issue Reporter: NA
    Contributor: $1000 +500 bonus @shubham1206agra in Upwork
    Contributor+: @robertKozik payment through contract

    Eligible for 50% #urgency bonus? Yes - #25689 (comment)

    Upwork job is here.

    @robertKozik let us know about the regression test so we can get this closed out -thanks!

  22. robertKozik commented on Sep 26, 2023

    @robertKozik
    Contributor

    I don't think we need regression test for it #25689 (comment)

  23. Christinadobrzyn commented on Sep 26, 2023

    @Christinadobrzyn
    Contributor

    Ah sorry I missed that note about the regression test. Thanks for clarifying! Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions