You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee #25689
This looks like there is a long-running operation on the main thread which is blocking UI input for a few seconds before the tap to select a contact finally registers.
changed the title [-]Assign task-Tapping on any contact, user unable to select assignee[/-][+][Android] Assign task-Tapping on any contact, user unable to select assignee[/+]on Aug 22, 2023
changed the title [-][Android] Assign task-Tapping on any contact, user unable to select assignee[/-][+]Assign task-Tapping on any contact, user unable to select assignee[/+]on Aug 22, 2023
changed the title [-]Assign task-Tapping on any contact, user unable to select assignee[/-][+][$1000] Assign task-Tapping on any contact, user unable to select assignee[/+]on Aug 22, 2023
changed the title [-][$1000] Assign task-Tapping on any contact, user unable to select assignee[/-][+][HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee[/+]on Sep 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@robertKozik] Determine if we should create a regression test for this bug.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@robertKozik] Determine if we should create a regression test for this bug. I think we don't need regression test here. It's rather edge-case scenario, which can be fixed with re-accessing the screen.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
Activity
melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)akinwale commentedon Aug 22, 2023
This looks like there is a long-running operation on the main thread which is blocking UI input for a few seconds before the tap to select a contact finally registers.
[-]Assign task-Tapping on any contact, user unable to select assignee[/-][+][Android] Assign task-Tapping on any contact, user unable to select assignee[/+][-][Android] Assign task-Tapping on any contact, user unable to select assignee[/-][+]Assign task-Tapping on any contact, user unable to select assignee[/+]Christinadobrzyn commentedon Aug 22, 2023
I can reproduce but this bug is inconsistent - but updated the OP to be as direct as possible on how to reproduce it. I think this can be External
[-]Assign task-Tapping on any contact, user unable to select assignee[/-][+][$1000] Assign task-Tapping on any contact, user unable to select assignee[/+]melvin-bot commentedon Aug 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01198bfad5e1717772
56 remaining items
[-][$1000] Assign task-Tapping on any contact, user unable to select assignee[/-][+][HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee[/+]melvin-bot commentedon Sep 14, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Sep 15, 2023
prepping for payment... @robertKozik should there be a regression test for this?
Christinadobrzyn commentedon Sep 22, 2023
Also @cristipaval I see a merge freeze was involved in the PR merge, this might have affected the speed bonus. Do we think a speed bonus applies here?
cristipaval commentedon Sep 24, 2023
Good point @Christinadobrzyn! Yes the speed bonus should apply, I checked the dates. I held the PR due to that merge freeze.
robertKozik commentedon Sep 25, 2023
CC. @Christinadobrzyn
Christinadobrzyn commentedon Sep 26, 2023
Payouts due:
Issue Reporter: NA
Contributor: $1000 +500 bonus @shubham1206agra in Upwork
Contributor+: @robertKozik payment through contract
Eligible for 50% #urgency bonus? Yes - #25689 (comment)
Upwork job is here.
@robertKozik let us know about the regression test so we can get this closed out -thanks!
robertKozik commentedon Sep 26, 2023
I don't think we need regression test for it #25689 (comment)
Christinadobrzyn commentedon Sep 26, 2023
Ah sorry I missed that note about the regression test. Thanks for clarifying! Closing this out.