You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [HOLD for payment 2023-09-04] Cleared Statement Reappears Briefly When Deleting Comment Changes #25690
Hover over the message and click on the edit icon.
Clear the message and click on the save changes icon.
Observe that the delete page popup appears, click on the delete button.
Notice that the cleared statement briefly reappears before being deleted.
Expected Result:
When clearing and deleting a comment, the cleared statement should not reappear even briefly.
Actual Result:
The cleared statement reappears briefly when deleting comment changes.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.56-3 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Excuse me, @johncschuster. I apologize for my mistake earlier. I was on the bus and didn't read carefully. I noticed that you had sent me two offers, but this issue was created before August 31st, which means the offer should be $250. However, you had offered $50 instead. Could you please clarify? Thank you
I noticed that you had sent me two offers, but this issue was created before August 31st, which means the offer should be $250. However, you had offered $50 instead. Could you please clarify? Thank you
I sure can! The Upwork job was created automatically, and reflects the current amounts for newly created jobs. That said, I will manually adjust the reporter amount to $250, since this was reported before the change was made.
Activity
melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.shubham1206agra commentedon Aug 22, 2023
Unable to repro in DEV
AndrewGable commentedon Aug 22, 2023
I can reproduce on staging, cannot reproduce on production. Not sure if it's a deploy blocker, but looking into possible offending PRs.
AndrewGable commentedon Aug 22, 2023
I can reproduce on Dev too.
46 remaining items
0xmiroslav commentedon Sep 18, 2023
I am also eligible payment for C+ review.
ref: #25690 (comment)
johncschuster commentedon Sep 18, 2023
Oh! I missed that too. Thanks @0xmiroslav!
0xmiroslav commentedon Sep 18, 2023
Also, PR was merged before price drop announcement so original base price applies here which is flatten 1k.
johncschuster commentedon Sep 18, 2023
Ah yes, I see the merge date was Aug 28, which is 2 days before the change was made (Slack announcement here).
johncschuster commentedon Sep 18, 2023
@tewodrosGirmaA it looks like you've accepted the
Contributorjob, which is incorrect. Can you please accept theReportjob instead?tewodrosGirmaA commentedon Sep 18, 2023
Excuse me, @johncschuster. I apologize for my mistake earlier. I was on the bus and didn't read carefully. I noticed that you had sent me two offers, but this issue was created before August 31st, which means the offer should be $250. However, you had offered $50 instead. Could you please clarify? Thank you
johncschuster commentedon Sep 18, 2023
I sure can! The Upwork job was created automatically, and reflects the current amounts for newly created jobs. That said, I will manually adjust the reporter amount to $250, since this was reported before the change was made.
johncschuster commentedon Sep 18, 2023
@tewodrosGirmaA I've extended an offer for $250. Can you accept that one when you get a moment? I'll get that payment issued right away.
tewodrosGirmaA commentedon Sep 18, 2023
@johncschuster , I accept it , Thank you 😊
johncschuster commentedon Sep 18, 2023
Payment issued! Thanks, @tewodrosGirmaA!
johncschuster commentedon Sep 18, 2023
Summary of payments:
Reporter: @tewodrosGirmaA - $250
Reviewer: @0xmiroslav - $1000
Both paid via Upwork
melvin-bot commentedon Sep 18, 2023
@AndrewGable @johncschuster Be sure to fill out the Contact List!
tewodrosGirmaA commentedon Sep 18, 2023
Thank you 😊