Skip to content

[$500] [HOLD for payment 2023-09-04] Cleared Statement Reappears Briefly When Deleting Comment Changes #25690

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access the staging Expensify website.
  2. Open any chat and write a message.
  3. Hover over the message and click on the edit icon.
  4. Clear the message and click on the save changes icon.
  5. Observe that the delete page popup appears, click on the delete button.
  6. Notice that the cleared statement briefly reappears before being deleted.

Expected Result:

When clearing and deleting a comment, the cleared statement should not reappear even briefly.

Actual Result:

The cleared statement reappears briefly when deleting comment changes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.56-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-08-22T012713.550.mp4
Recording.383.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692693288512319

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0163bb21b363fde22a
  • Upwork Job ID: 1703770694266941440
  • Last Price Increase: 2023-09-18
  • Automatic offers:
    • 0xmiroslav | Reviewer | 26732815
    • tewodrosGirmaA | Contributor | 26732817
    • tewodrosGirmaA | Reporter | 26732820

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2023
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Unable to repro in DEV

  7. AndrewGable commented on Aug 22, 2023

    @AndrewGable
    Contributor

    I can reproduce on staging, cannot reproduce on production. Not sure if it's a deploy blocker, but looking into possible offending PRs.

  8. AndrewGable commented on Aug 22, 2023

    @AndrewGable
    Contributor

    I can reproduce on Dev too.

  9. 46 remaining items

  10. 0xmiroslav commented on Sep 18, 2023

    @0xmiroslav
    Contributor

    I am also eligible payment for C+ review.
    ref: #25690 (comment)

  11. johncschuster commented on Sep 18, 2023

    @johncschuster
    Contributor

    Oh! I missed that too. Thanks @0xmiroslav!

  12. 0xmiroslav commented on Sep 18, 2023

    @0xmiroslav
    Contributor

    Also, PR was merged before price drop announcement so original base price applies here which is flatten 1k.

  13. johncschuster commented on Sep 18, 2023

    @johncschuster
    Contributor

    Ah yes, I see the merge date was Aug 28, which is 2 days before the change was made (Slack announcement here).

  14. johncschuster commented on Sep 18, 2023

    @johncschuster
    Contributor

    @tewodrosGirmaA it looks like you've accepted the Contributor job, which is incorrect. Can you please accept the Report job instead?

  15. tewodrosGirmaA commented on Sep 18, 2023

    @tewodrosGirmaA

    Excuse me, @johncschuster. I apologize for my mistake earlier. I was on the bus and didn't read carefully. I noticed that you had sent me two offers, but this issue was created before August 31st, which means the offer should be $250. However, you had offered $50 instead. Could you please clarify? Thank you

  16. johncschuster commented on Sep 18, 2023

    @johncschuster
    Contributor

    I noticed that you had sent me two offers, but this issue was created before August 31st, which means the offer should be $250. However, you had offered $50 instead. Could you please clarify? Thank you

    I sure can! The Upwork job was created automatically, and reflects the current amounts for newly created jobs. That said, I will manually adjust the reporter amount to $250, since this was reported before the change was made.

  17. johncschuster commented on Sep 18, 2023

    @johncschuster
    Contributor

    @tewodrosGirmaA I've extended an offer for $250. Can you accept that one when you get a moment? I'll get that payment issued right away.

  18. tewodrosGirmaA commented on Sep 18, 2023

    @tewodrosGirmaA

    @johncschuster , I accept it , Thank you 😊

  19. johncschuster commented on Sep 18, 2023

    @johncschuster
    Contributor

    Payment issued! Thanks, @tewodrosGirmaA!

  20. johncschuster commented on Sep 18, 2023

    @johncschuster
    Contributor

    Summary of payments:

    Reporter: @tewodrosGirmaA - $250
    Reviewer: @0xmiroslav - $1000

    Both paid via Upwork

  21. melvin-bot commented on Sep 18, 2023

    @melvin-bot

    @AndrewGable @johncschuster Be sure to fill out the Contact List!

  22. tewodrosGirmaA commented on Sep 18, 2023

    @tewodrosGirmaA

    Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions