Skip to content

[HOLD for payment 2023-09-07] [$500] Redirect icon is not highlighted on hover #25692

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to the staging Expensify website.
  2. Click on the plus sign and select "Request Money".
  3. Add a desired amount and an email address.
  4. Click on the requested money.
  5. Observe that the redirect icon

Expected Result:

The redirect icon should be highlighted on hover

Actual Result:

The redirect icon is not highlighted on hover

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.56-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-08-21T233549.020.mp4
Recording.385.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692685377725719

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0138f9abcf1acbfcc9
  • Upwork Job ID: 1694124812688658432
  • Last Price Increase: 2023-08-22
  • Automatic offers:
    • dhairyasenjaliya | Contributor | 26374116
    • tewodrosGirmaA | Reporter | 26374119

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2023
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. dhairyasenjaliya commented on Aug 22, 2023

    @dhairyasenjaliya
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • Redirect icon is not highlighted on hover

    What is the root cause of that problem?

    • The root cause is we are have not added hover state to check colour of icon

    What changes do you think we should make in order to solve the problem?

    • We should add fill props to Icon component of arrorRight on ReportPreview.js and MoneyRequestPreview.js

    • We should add fill={StyleUtils.getIconFillColor(getButtonState(props.isHovered))} to check hovers state

    What alternative solutions did you explore? (Optional)

    • N/A
      ———————

    Result

    Screen.Recording.2023-08-22.at.9.13.32.PM.mov
  7. 36 remaining items

  8. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  9. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts] Determine if we should create a regression test for this bug.
    • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  10. added and removed on Sep 12, 2023
  11. sakluger commented on Sep 12, 2023

    @sakluger
    Contributor

    Summarizing payouts for this issue:

    Reporter: @tewodrosGirmaA $250 (paid on Upwork
    Contributor: @dhairyasenjaliya $750 (paid on Upwork)
    Contributor+: @allroundexperts $750 (payable via Manual Request after BZ checklist is completed)

    Above payments include efficiency bonus 🎉
    Upwork job: https://www.upwork.com/jobs/~0138f9abcf1acbfcc9

  12. sakluger commented on Sep 12, 2023

    @sakluger
    Contributor

    @allroundexperts please let me know once you have finished the BZ checklist and requested payment via NewDot so that I can close the issue, thanks!

  13. allroundexperts commented on Sep 13, 2023

    @allroundexperts
    Contributor

    Requested payment. Onto the checklist.

  14. sakluger commented on Sep 14, 2023

    @sakluger
    Contributor

    @allroundexperts any updates on the checklist?

  15. allroundexperts commented on Sep 17, 2023

    @allroundexperts
    Contributor

    Checklist

    1. Display receipts in chat #24235
    2. https://github.com/Expensify/App/pull/24235/files#r1328152348
    3. Slack discussion is not needed here. This was a small UI issue which could have been caught earlier by better testing.
    4. Regression test might not be needed here as this was really a very minor UI issue. If however, we feel like a test is necessary, then the following are the steps.

    Regression Test Steps

    1. Request money manually and open the chat where the IOU Preview is visible.
    2. Hover over the IOUPreview component.
    3. Verify that the right arrow icon changes colour to white.

    Do we 👍 or 👎 ?

  16. sakluger commented on Sep 18, 2023

    @sakluger
    Contributor

    Looks good to me! @allroundexperts please feel free to request the payment, and thanks again!

  17. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $750 payment for @allroundexperts approved based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions