You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-07] [$500] Redirect icon is not highlighted on hover #25692
Click on the plus sign and select "Request Money".
Add a desired amount and an email address.
Click on the requested money.
Observe that the redirect icon
Expected Result:
The redirect icon should be highlighted on hover
Actual Result:
The redirect icon is not highlighted on hover
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.56-4 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@allroundexpertsdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Reporter: @tewodrosGirmaA $250 (paid on Upwork
Contributor: @dhairyasenjaliya $750 (paid on Upwork)
Contributor+: @allroundexperts $750 (payable via Manual Request after BZ checklist is completed)
Slack discussion is not needed here. This was a small UI issue which could have been caught earlier by better testing.
Regression test might not be needed here as this was really a very minor UI issue. If however, we feel like a test is necessary, then the following are the steps.
Regression Test Steps
Request money manually and open the chat where the IOU Preview is visible.
Hover over the IOUPreview component.
Verify that the right arrow icon changes colour to white.
Activity
melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @thienlnam (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.dhairyasenjaliya commentedon Aug 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
We should add
fillprops toIconcomponent ofarrorRightonReportPreview.jsandMoneyRequestPreview.jsWe should add
fill={StyleUtils.getIconFillColor(getButtonState(props.isHovered))}to check hovers stateWhat alternative solutions did you explore? (Optional)
———————
Result
Screen.Recording.2023-08-22.at.9.13.32.PM.mov
36 remaining items
melvin-bot commentedon Aug 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 31, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sakluger commentedon Sep 12, 2023
Summarizing payouts for this issue:
Reporter: @tewodrosGirmaA $250 (paid on Upwork
Contributor: @dhairyasenjaliya $750 (paid on Upwork)
Contributor+: @allroundexperts $750 (payable via Manual Request after BZ checklist is completed)
Above payments include efficiency bonus 🎉
Upwork job: https://www.upwork.com/jobs/~0138f9abcf1acbfcc9
sakluger commentedon Sep 12, 2023
@allroundexperts please let me know once you have finished the BZ checklist and requested payment via NewDot so that I can close the issue, thanks!
allroundexperts commentedon Sep 13, 2023
Requested payment. Onto the checklist.
sakluger commentedon Sep 14, 2023
@allroundexperts any updates on the checklist?
allroundexperts commentedon Sep 17, 2023
Checklist
Regression Test Steps
IOUPreviewcomponent.Do we 👍 or 👎 ?
sakluger commentedon Sep 18, 2023
Looks good to me! @allroundexperts please feel free to request the payment, and thanks again!
JmillsExpensify commentedon Oct 5, 2023
$750 payment for @allroundexperts approved based on BZ summary.