You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] IOU - IOU is displayed as Merchant in IOU details page when IOU is created without a Merchant #25694
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue
IOU - IOU is displayed as Merchant in IOU details page when IOU is created without a Merchant
What is the root cause of that problem?
This is due to during requestMoney call we are using buildOptimisticTransaction to create optimistic report data
And we use CONST.REPORT.TYPE.IOU as the default value for merchant in the places
Activity
OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @deetergp (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.shubham1206agra commentedon Aug 22, 2023
@deetergp Looks like its coming from here
App/src/libs/TransactionUtils.js
Line 46 in 999ed93
shubham1206agra commentedon Aug 22, 2023
Is it necessary to have merchant or we can leave it blank?
shubham1206agra commentedon Aug 22, 2023
Now its showing
Requestas merchantLooks like its getting overridden from BE
shubham1206agra commentedon Aug 22, 2023
Confirmed it
IOU is coming due to optimistic transaction data
And now for blank merchant BE will pass Request as merchant
shubham1206agra commentedon Aug 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
IOU - IOU is displayed as Merchant in IOU details page when IOU is created without a Merchant
What is the root cause of that problem?
This is due to during
requestMoneycall we are usingbuildOptimisticTransactionto create optimistic report dataAnd we use
CONST.REPORT.TYPE.IOUas the default value for merchant in the placesApp/src/libs/TransactionUtils.js
Line 46 in 999ed93
and
App/src/libs/TransactionUtils.js
Line 69 in 999ed93
And for merchant becoming
Request. This is coming from BE only.What changes do you think we should make in order to solve the problem?
Replace
CONST.REPORT.TYPE.IOUwith empty strings inbuildOptimisticTransaction.For
Request, this needs to be checked from the backend.What alternative solutions did you explore? (Optional)
5 remaining items
melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @kadiealexander (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)deetergp commentedon Aug 22, 2023
I don't think this issue is big enough to consider it a blocker—it is pretty minor.
shubham1206agra commentedon Aug 23, 2023
@rushatgabhane Can you review my proposal?
rushatgabhane commentedon Aug 23, 2023
@mountiny is this an issue? If yes, is it being internally tracked?
I think the deafult merchant should be
Request, and that the backend is correct.rushatgabhane commentedon Aug 23, 2023
@mountiny should we fix this in your follow-up PRs because this is really minor and it happened because API wasn't ready when we merged
merchantPR.tewodrosGirmaA commentedon Aug 23, 2023
Hey guys! I reported this bug in Slack before this issue was created. Could you please change the reporter's name? Thanks! Here's the link to the bug report: Bug Report Slack Link (https://expensify.slack.com/archives/C049HHMV9SM/p1692687129320969)
luacmartins commentedon Aug 23, 2023
This is not an issue, all requests should have a default merchant name. We're updating it to the correct merchant name in this PR
luacmartins commentedon Aug 23, 2023
Gonna close this one.