Skip to content

[$1000] IOU - IOU is displayed as Merchant in IOU details page when IOU is created without a Merchant #25694

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify,com
  2. Create money request without selecting a merchant
  3. Open the money request report
  4. Click on the IOU preview

Expected Result:

Merchant is not stated because money request is created without selecting a merchant

Actual Result:

IOU (or sometimes, Request) is shown for Merchant when money request is created without selecting a merchant

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome
  • MacOS / Desktop

**Version Number:**1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173403_20230822_131014.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019d6df5b1911e3c11
  • Upwork Job ID: 1694136380885807104
  • Last Price Increase: 2023-08-22

Activity

  1. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    @deetergp Looks like its coming from here

    merchant = CONST.REPORT.TYPE.IOU,

  4. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Is it necessary to have merchant or we can leave it blank?

  5. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Now its showing Request as merchant
    Looks like its getting overridden from BE

  6. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Confirmed it
    IOU is coming due to optimistic transaction data
    And now for blank merchant BE will pass Request as merchant

  7. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue

    IOU - IOU is displayed as Merchant in IOU details page when IOU is created without a Merchant

    What is the root cause of that problem?

    This is due to during requestMoney call we are using buildOptimisticTransaction to create optimistic report data
    And we use CONST.REPORT.TYPE.IOU as the default value for merchant in the places

    merchant = CONST.REPORT.TYPE.IOU,

    and
    merchant: merchant || CONST.REPORT.TYPE.IOU,

    And for merchant becoming Request. This is coming from BE only.

    What changes do you think we should make in order to solve the problem?

    Replace CONST.REPORT.TYPE.IOU with empty strings in buildOptimisticTransaction.
    For Request, this needs to be checked from the backend.

    What alternative solutions did you explore? (Optional)

  8. 5 remaining items

  9. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  10. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  11. deetergp commented on Aug 22, 2023

    @deetergp
    Contributor

    I don't think this issue is big enough to consider it a blocker—it is pretty minor.

  12. added and removed on Aug 23, 2023
  13. shubham1206agra commented on Aug 23, 2023

    @shubham1206agra
    Contributor

    @rushatgabhane Can you review my proposal?

  14. rushatgabhane commented on Aug 23, 2023

    @rushatgabhane
    Member

    @mountiny is this an issue? If yes, is it being internally tracked?

    I think the deafult merchant should be Request, and that the backend is correct.

  15. rushatgabhane commented on Aug 23, 2023

    @rushatgabhane
    Member

    @mountiny should we fix this in your follow-up PRs because this is really minor and it happened because API wasn't ready when we merged merchant PR.

  16. tewodrosGirmaA commented on Aug 23, 2023

    @tewodrosGirmaA

    Hey guys! I reported this bug in Slack before this issue was created. Could you please change the reporter's name? Thanks! Here's the link to the bug report: Bug Report Slack Link (https://expensify.slack.com/archives/C049HHMV9SM/p1692687129320969)

  17. luacmartins commented on Aug 23, 2023

    @luacmartins
    Contributor

    This is not an issue, all requests should have a default merchant name. We're updating it to the correct merchant name in this PR

  18. self-assigned this
    on Aug 23, 2023
  19. luacmartins commented on Aug 23, 2023

    @luacmartins
    Contributor

    Gonna close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions