Skip to content

Map not showing in DistanceRequest tab of MoneyRequest page #25696

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify,com
  2. Go to + > Request money
  3. Go to Distance tab

Expected Result:

Map is displayed in Distance tab

Actual Result:

Map is not displayed in Distance tab. The site does not ask for location permission. It is not possible to set 'allow' for location permission on web browser as it reverts to 'ask' in the site settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome
  • MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173422_mweb

Bug6173422_Android

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. arosiclair commented on Aug 22, 2023

    @arosiclair
    Contributor
    • iOS ✅
    • Android ✅
    • Android Web ❌
    • iOS Web ❌
    • Desktop web ❌

    @hayata-suenaga is this supposed to work on web at this point? The map doesn't seem to load on web platforms on staging

  4. hayata-suenaga commented on Aug 22, 2023

    @hayata-suenaga
    Contributor

    I'm checking now

  5. hayata-suenaga commented on Aug 22, 2023

    @hayata-suenaga
    Contributor

    that will be solved when this PR is deployed to staging. I don't know if it's worth cherry pick though because this feature is behind beta anyway.

  6. 4 remaining items

  7. hayata-suenaga commented on Aug 22, 2023

    @hayata-suenaga
    Contributor

    @arosiclair I gonna assign myself to this issue and see if the PR actually gonna fix the issue. But this is not a deploy blocker so removing the label.

  8. hayata-suenaga commented on Aug 22, 2023

    @hayata-suenaga
    Contributor

    yep the map is working on main

    Screenshot 2023-08-22 at 3 18 23 PM
  9. hayata-suenaga commented on Aug 25, 2023

    @hayata-suenaga
    Contributor

    being handled here: https://github.com/Expensify/Expensify/issues/311387 (internal)

    UPDATE: ⬆️ this turned out not to be the cause of the issue

  10. changed the title [-]Request money - Map does not show up in Distance tab[/-] [+]Map not showing in `DistanceRequest` tab of `MoneyRequest` page[/+] on Aug 27, 2023
  11. hayata-suenaga commented on Aug 27, 2023

    @hayata-suenaga
    Contributor

    Opened a PR in the Cloudflare-Workers repo

  12. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. hayata-suenaga commented on Sep 1, 2023

    @hayata-suenaga
    Contributor

    The fix has been deployed and it's working now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions