You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-04] Login - Can't sign in with Apple #25697
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This is odd. I tried on staging and the response is that the idToken param is missing:
{"code":666,"jsonCode":666,"type":"Expensify\\Libs\\Error\\ExpError","UUID":"b2609074-dcf5-4513-86f1-575c3e51e90e","message":"Missing idToken when attempting to sign in via Apple.","title":"","data":[],"htmlMessage":"","onyxData":[],"requestID":"7faca0af19c72819-SEA"}
Currently spinning up an Android build (need to grab a token from Android to make the local web test work) so I can re-test locally to see if the error is occurring there.
At the upper level, we're trying to get the id_token from the object detail, but it seems we'd need to get it from detail.authorization.id_token@lindboe
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @yuwenmemon (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.yuwenmemon commentedon Aug 22, 2023
@marcochavezf Can you take a look?
lindboe commentedon Aug 22, 2023
This is odd. I tried on staging and the response is that the idToken param is missing:
I'm not sure how that's happening. The idToken param is clearly in the
API.writecall: https://github.com/Expensify/App/blob/main/src/libs/actions/Session/index.js#L271, and we've had this working for a while locally now.Currently spinning up an Android build (need to grab a token from Android to make the local web test work) so I can re-test locally to see if the error is occurring there.
marcochavezf commentedon Aug 22, 2023
Yeah this is weird, for some reason, the
idTokenis not included in the payload:marcochavezf commentedon Aug 22, 2023
Looking at the bundle file, seems the param in
beginAppleSignInis undefined:marcochavezf commentedon Aug 22, 2023
At the upper level, we're trying to get the id_token from the object
detail, but it seems we'd need to get it fromdetail.authorization.id_token@lindboemarcochavezf commentedon Aug 22, 2023
I suppose it's coming from here, would be possible that the structure of the object changes in dev mode?
I think we should create some helper function to get the
id_token, something like:At least to fix the deploy blocker and we can check out later why the structure changes, what do you think @lindboe?
amyevans commentedon Aug 23, 2023
QA'ed the fix on staging and it passes ✅
Going to remove the deploy blocker label
amyevans commentedon Aug 23, 2023
Actually I guess we are all set to close
[-]Login - Can't sign in with Apple[/-][+][HOLD for payment 2023-09-04] Login - Can't sign in with Apple[/+]melvin-bot commentedon Aug 28, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 29, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.