Skip to content

[HOLD for payment 2023-09-04] Login - Can't sign in with Apple #25697

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #23673

Action Performed:

  1. Go to staging.new.expensify.com
  2. Click on Apple icon logo
  3. Enter valid Apple ID and password
  4. If prompted, validate with 2 factor authentication
  5. Select "Share my email" and click on "Continue"

Expected Result:

he user should be able to log in with their Apple account

Actual Result:

The user is unable to log in with their Apple account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.56-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173525_bandicam_2023-08-21_23-12-12-379.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. yuwenmemon commented on Aug 22, 2023

    @yuwenmemon
    Contributor

    @marcochavezf Can you take a look?

  4. lindboe commented on Aug 22, 2023

    @lindboe
    Contributor

    This is odd. I tried on staging and the response is that the idToken param is missing:

    {"code":666,"jsonCode":666,"type":"Expensify\\Libs\\Error\\ExpError","UUID":"b2609074-dcf5-4513-86f1-575c3e51e90e","message":"Missing idToken when attempting to sign in via Apple.","title":"","data":[],"htmlMessage":"","onyxData":[],"requestID":"7faca0af19c72819-SEA"}
    

    I'm not sure how that's happening. The idToken param is clearly in the API.write call: https://github.com/Expensify/App/blob/main/src/libs/actions/Session/index.js#L271, and we've had this working for a while locally now.

    Currently spinning up an Android build (need to grab a token from Android to make the local web test work) so I can re-test locally to see if the error is occurring there.

    Screenshot 2023-08-22 at 9 58 18 AM
  5. marcochavezf commented on Aug 22, 2023

    @marcochavezf
    Contributor

    Yeah this is weird, for some reason, the idToken is not included in the payload:

    Screenshot 2023-08-22 at 11 08 03
  6. marcochavezf commented on Aug 22, 2023

    @marcochavezf
    Contributor

    Looking at the bundle file, seems the param in beginAppleSignIn is undefined:

    Screenshot 2023-08-22 at 11 10 54
  7. marcochavezf commented on Aug 22, 2023

    @marcochavezf
    Contributor

    At the upper level, we're trying to get the id_token from the object detail, but it seems we'd need to get it from detail.authorization.id_token @lindboe

    Screenshot 2023-08-22 at 11 13 16
  8. marcochavezf commented on Aug 22, 2023

    @marcochavezf
    Contributor

    I suppose it's coming from here, would be possible that the structure of the object changes in dev mode?

    I think we should create some helper function to get the id_token, something like:

    function getIDToken(event){
       return lodashGet(event.detail, 'authorization') ?  lodashGet(event.detail.authorization, 'id_token') : lodashGet(event.detail, 'id_token');
    }

    At least to fix the deploy blocker and we can check out later why the structure changes, what do you think @lindboe?

  9. amyevans commented on Aug 23, 2023

    @amyevans
    Contributor

    QA'ed the fix on staging and it passes ✅

    Going to remove the deploy blocker label

  10. amyevans commented on Aug 23, 2023

    @amyevans
    Contributor

    Actually I guess we are all set to close

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 28, 2023
  12. changed the title [-]Login - Can't sign in with Apple[/-] [+][HOLD for payment 2023-09-04] Login - Can't sign in with Apple[/+] on Aug 28, 2023
  13. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-04. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions