You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Web - Console error shows up when creating room and opening room chat #25717
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
We are trying to parse the URL and relative href can't be parsed and that's why it jumps to the catch block where we are consoling the error. I think we can just remove console line here as it makes sense that some relative paths will fall down into the catch block for the AnchorRenderer.
I don't think this is a bug or a blocker as this console.log seems to have been added for debugging purposes. We can decide to remove it if we want, and do so in any of the PRs submitted for this repo, but I suggest we close this
It looks like this is failing in the constructor, and maybe instead of deleting that log line, we should update it to also log the url we're passing to the method
It is because we are trying to parse links such as /settings/profile/display-name, which causes URL to fail as it requires a proper format (i.e., including origin).
What changes do you think we should make in order to solve the problem?
We should use tryResolveUrlFromApiRoot to append the correct origin to the url if needed here
It is because we are trying to parse links such as /settings/profile/display-name, which causes URL to fail as it requires a proper format (i.e., including origin).
What changes do you think we should make in order to solve the problem?
We should use tryResolveUrlFromApiRoot to append the correct origin to the url if needed here
@Ollyws can you please review @shubham1206agra 's proposal? I think it looks good but I think we should fix the URL with tryResolveUrlFromApiRoot and not remove the console.error since that's what surfaced this issue. What do you think? cc @roryabraham
changed the title [-][$500] Web - Console error shows up when creating room and opening room chat[/-][+][$250] Web - Console error shows up when creating room and opening room chat[/+]on Oct 27, 2023
Activity
OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @cead22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Pujan92 commentedon Aug 22, 2023
We are trying to parse the URL and relative href can't be parsed and that's why it jumps to the catch block where we are consoling the error. I think we can just remove console line here as it makes sense that some relative paths will fall down into the catch block for the
AnchorRenderer.App/src/libs/Url.js
Line 25 in 44eb88a
cead22 commentedon Aug 22, 2023
I don't think this is a bug or a blocker as this console.log seems to have been added for debugging purposes. We can decide to remove it if we want, and do so in any of the PRs submitted for this repo, but I suggest we close this
cead22 commentedon Aug 22, 2023
It looks like this is failing in the constructor, and maybe instead of deleting that log line, we should update it to also log the
urlwe're passing to the methodroryabraham commentedon Aug 23, 2023
Agreed that this doesn't seem like a bug, and certainly not a deploy blocker. It makes sense to me to remove the
console.errorthere.shubham1206agra commentedon Aug 23, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
Web - Console error shows up when creating room and opening room chat
What is the root cause of that problem?
This is due to console.error being present in the places
App/src/libs/Url.js
Line 25 in 44eb88a
and
App/src/libs/Url.js
Line 45 in 44eb88a
Why did
new URL(url)fails?It is because we are trying to parse links such as
/settings/profile/display-name, which causesURLto fail as it requires a proper format (i.e., including origin).What changes do you think we should make in order to solve the problem?
We should use
tryResolveUrlFromApiRootto append the correct origin to the url if needed hereApp/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js
Line 26 in 44eb88a
to
And remove
console.errorOR change toconsole.warnMaybe Optional
In
CONFIG.jsApp/src/CONFIG.js
Line 23 in 44eb88a
can be changed to get no problem with link rendering in the DEV server.
What alternative solutions did you explore? (Optional)
22 remaining items
cead22 commentedon Oct 27, 2023
@Ollyws can you please review @shubham1206agra 's proposal? I think it looks good but I think we should fix the URL with tryResolveUrlFromApiRoot and not remove the console.error since that's what surfaced this issue. What do you think? cc @roryabraham
[-][$500] Web - Console error shows up when creating room and opening room chat[/-][+][$250] Web - Console error shows up when creating room and opening room chat[/+]melvin-bot commentedon Oct 27, 2023
Upwork job price has been updated to $250
Ollyws commentedon Oct 30, 2023
I'm not seeing any console errors when creating or navigating to a public room on the latest main. Is this reproducible for anyone else?
melvin-bot commentedon Nov 3, 2023
@cead22, @Ollyws Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Nov 3, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
cead22 commentedon Nov 6, 2023
@lanitochka17 can you re-test and see if you can still reproduce please?
lanitochka17 commentedon Nov 7, 2023
Issue is not reproduced on latest build 1.3.96-5
Windows10/Chrome
Recording.385.mp4