You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web - New line marker on Task does not disappear when sending or receiving a message #25776
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What changes do you think we should make in order to solve the problem?
We should update the isUnread function to lastReadTime <= lastVisibleActionCreated or when we add a comment we can set lastReadTime less than lastVisibleActionCreated some milliseconds.
Ah, yes. That looks to be it. I haven't been familiar with this code in a long time. I am concerned that the solution that you propose could have other potential side-effects that we don't know about.
What is your gauge on how risky of a change it is to do lastReadTime <= lastVisibleActionCreated and that it could lead to more regressions?
I'm also considering that we should revert that refactoring PR as it seemed tied to several regressions.
Yeah, I mostly agree with you. It sounds like there have been a couple of follow-up PRs to fix other blockers from it that would also need to be reverted, so we are evaluating now what kind of a mess we are in and how best to get out of it.
Activity
melvin-bot commentedon Aug 23, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 23, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Aug 23, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 23, 2023
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.dukenv0307 commentedon Aug 23, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
New line marker on Task does not disappear when sending or receiving a message
What is the root cause of that problem?
Let's see the optimistic report here, we set
lastVisibleActionCreatedandlastReadTimeequalApp/src/libs/actions/Report.js
Lines 259 to 265 in ebb6d33
That makes
isUnreadfunction here return false soreadNewestActionAPI isn't called and then new line marker doesn't appearApp/src/pages/home/report/ReportActionsList.js
Line 147 in 5d1d5f1
What changes do you think we should make in order to solve the problem?
We should update the
isUnreadfunction tolastReadTime <= lastVisibleActionCreatedor when we add a comment we can setlastReadTimeless thanlastVisibleActionCreatedsome milliseconds.App/src/libs/ReportUtils.js
Line 2466 in 5d1d5f1
What alternative solutions did you explore? (Optional)
tgolen commentedon Aug 23, 2023
@dukenv0307 Thank you so much for looking into this. Were you by any chance able to find what caused this regression to happen?
dukenv0307 commentedon Aug 23, 2023
@tgolen I think this happens after we refactor unread marker here https://github.com/Expensify/App/pull/18637/files
dukenv0307 commentedon Aug 23, 2023
Before refactoring, if we add a comment we will clear the unread marker and scroll to bottom.
tgolen commentedon Aug 23, 2023
Ah, yes. That looks to be it. I haven't been familiar with this code in a long time. I am concerned that the solution that you propose could have other potential side-effects that we don't know about.
What is your gauge on how risky of a change it is to do
lastReadTime <= lastVisibleActionCreatedand that it could lead to more regressions?I'm also considering that we should revert that refactoring PR as it seemed tied to several regressions.
dummy-1111 commentedon Aug 23, 2023
I think we should revert the PR
tgolen commentedon Aug 23, 2023
Yeah, I mostly agree with you. It sounds like there have been a couple of follow-up PRs to fix other blockers from it that would also need to be reverted, so we are evaluating now what kind of a mess we are in and how best to get out of it.
tgolen commentedon Aug 23, 2023
All right, we have decided to revert the original PR for now. It turned out there were no other post-fixes that needed reverting.
tgolen commentedon Aug 23, 2023
Discussion was in slack
melvin-bot commentedon Aug 23, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
roryabraham commentedon Aug 23, 2023
According to @MonilBhavsar, this is expected behavior, not a 🐛
Closing this out.
melvin-bot commentedon Aug 23, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.