Skip to content

[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Invite member - Incorrect selection of member using Tab key #25883

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify,com
  2. Go to Settings > Workspace > Members > Invite.
  3. Press Tab on keyboard to navigate to the checkbox next to the member (not the first member) and press Enter.
  4. Repeat Step 3 but navigate to the member row instead of the checkbox.

Expected Result:

In Step 3 and 4, only the selected member is selected.

Actual Result:

In Step 3, only the member in green highlight is selected, not the one selected by checkbox
In Step 4, the first member in green highlight is selected and also the member selected via Tab key

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.57-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6175878_20230825_020830.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 24, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 24, 2023

    @melvin-bot

    Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. thienlnam commented on Aug 24, 2023

    @thienlnam
    Contributor

    This appears to be caused by #22622

  4. thienlnam commented on Aug 24, 2023

    @thienlnam
    Contributor

    There seems to be a few focus issues from the above - cc @thiagobrez do you have the chance to take a look here?

    Also seems somewhat similar to this bug #25884

  5. thiagobrez commented on Aug 25, 2023

    @thiagobrez
    Contributor

    @thienlnam Yeah, taking a look right now!

  6. mountiny commented on Aug 25, 2023

    @mountiny
    Contributor

    confirmed this si fixed in staging, no reporting bonus, closing

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 28, 2023
  8. changed the title [-]Invite member - Incorrect selection of member using Tab key[/-] [+][HOLD for payment 2023-09-04] Invite member - Incorrect selection of member using Tab key[/+] on Aug 28, 2023
  9. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-04. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  10. changed the title [-][HOLD for payment 2023-09-04] Invite member - Incorrect selection of member using Tab key[/-] [+][HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Invite member - Incorrect selection of member using Tab key[/+] on Aug 30, 2023
  11. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-06. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions