Skip to content

[HOLD for payment 2023-09-07] [W4 Scan Receipts] LOW: Report preview shows more than 3 thumbnails #25970

Closed

Description

@luacmartins

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Request money from another user using the Scan option
  2. Repeat the process 5 times
  3. Notice that the report preview shows more than 3 thumbnails

Expected Result:

Report preview should show a maximum of 3 thumbnails

Actual Result:

Report preview shows more than 3 thumbnails

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

bug.mov
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016d0855b65bc06680
  • Upwork Job ID: 1695151138460545024
  • Last Price Increase: 2023-08-25

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 25, 2023
  2. self-assigned this
    on Aug 25, 2023
  3. melvin-bot commented on Aug 25, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Aug 25, 2023

    @melvin-bot
  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Aug 25, 2023
  6. melvin-bot commented on Aug 25, 2023

    @melvin-bot
  7. melvin-bot commented on Aug 25, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

  8. 2 remaining items

  9. changed the title [-][W4 Scan Receipts] LOW: Report preview shows more than 3 thumbnails[/-] [+][HOLD for payment 2023-09-07] [W4 Scan Receipts] LOW: Report preview shows more than 3 thumbnails[/+] on Aug 31, 2023
  10. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
    • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ntdiary] Determine if we should create a regression test for this bug.
    • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. sophiepintoraetz commented on Aug 31, 2023

    @sophiepintoraetz
    Contributor

    @luacmartins - how much is due here? Is this a $250 payment?

  14. luacmartins commented on Aug 31, 2023

    @luacmartins
    ContributorAuthor

    @sophiepintoraetz this is a payment for PR review - so I believe it's still $1000 given the PR was reviewed before Aug 30

  15. sophiepintoraetz commented on Sep 1, 2023

    @sophiepintoraetz
    Contributor

    Offer sent @ntdiary! I'll release payment on 07 Sep. One thing that would be helpful is if you could include your first name in your GH profile? Helps me to know who you are in Upwork (ntdiary doesn't return anything.)

  16. ntdiary commented on Sep 1, 2023

    @ntdiary
    Contributor

    @sophiepintoraetz, ah, very sorry for the confusion, is this okay? 😂
    image

  17. sophiepintoraetz commented on Sep 6, 2023

    @sophiepintoraetz
    Contributor

    @ntdiary - mind filling out the regression steps then I can release payment today? :D

  18. ntdiary commented on Sep 7, 2023

    @ntdiary
    Contributor

    @sophiepintoraetz Sure. 😄

    [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:

    #24235

    [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    https://github.com/Expensify/App/pull/24235/files#r1317967618

    [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Polish new feature, this step is not needed.

    [@ntdiary] Determine if we should create a regression test for this bug.

    Regression testing is not needed.

    [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Not needed

  19. sophiepintoraetz commented on Sep 7, 2023

    @sophiepintoraetz
    Contributor

    All paid, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions