Skip to content

User is unable to authenticate with magic link #25979

Closed as not planned
Closed as not planned

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to sig-up page
  2. Enter email & click on 'Continue' button
  3. Open email > copy magic link > open new tab
  4. Paste to browser address bar & prefix the link with dev link in the following format: http://localhost:8082/v/15361796/136890
  5. Press enter
  6. Switch to the tab where user was trying to sign in

Expected Result:

User should be signed in

Actual Result:

User is not signed in until the user refreshes the page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692948638904319

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 25, 2023
  2. melvin-bot commented on Aug 25, 2023

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 25, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Aug 25, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 25, 2023

    @melvin-bot

    Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. roryabraham commented on Aug 25, 2023

    @roryabraham
    Contributor

    I know @tgolen is out for the rest of the day, grabbing this

  7. 18 remaining items

  8. added and removed on Aug 28, 2023
  9. Natnael-Guchima commented on Aug 28, 2023

    @Natnael-Guchima

    @tgolen

    Response to the request:
    {
    "httpCode": 200,
    "jsonCode": 200,
    "authResponseMessage": "200 OK",
    "requestID": "7fdee47cc8ef11ac-MRS"
    }

    Console log:

    Screenshot from 2023-08-28 22-20-42

    Now the issue is reproducible on staging:

    Screencast.from.2023-08-28.22-12-36.mp4

    And it works fine on prod:

    Screencast.from.2023-08-28.22-14-14.mp4
  10. tgolen commented on Aug 28, 2023

    @tgolen
    Contributor

    OK, thank you! @johnmlee101 or @NikkiWines Do either of you might know what's going on here?

  11. johnmlee101 commented on Aug 28, 2023

    @johnmlee101
    Contributor

    Has this always worked on staging? Some random part in the back of my subconscious thinks this flow only worked on prod but I can't for the life of me remember why. However the fact that the page just kind of sticks is very odd. Let me test and see

  12. johnmlee101 commented on Aug 28, 2023

    @johnmlee101
    Contributor

    Okay I couldn't reproduce on staging but it was realllllllly slow. Which honestly feels like a performance regression. It took like 10 seconds to load the page, and another 5 seconds after to actually update the original sign in page with the code

  13. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    and removed on Aug 29, 2023
  15. Natnael-Guchima commented on Aug 30, 2023

    @Natnael-Guchima

    @tgolen this issue is now reported by applause as a deploy blocker here

  16. tgolen commented on Aug 30, 2023

    @tgolen
    Contributor

    I'm going to close this issue as a duplicate.

  17. Natnael-Guchima commented on Aug 30, 2023

    @Natnael-Guchima

    @tgolen my report came first. The duplicate one is the one reported by applause. Can you please add my name on the other issue as a reporter?

  18. tgolen commented on Aug 30, 2023

    @tgolen
    Contributor

    Sure, updated 👍

  19. Natnael-Guchima commented on Aug 30, 2023

    @Natnael-Guchima

    Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions