Skip to content

[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time #26027

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open any chat and request money
  2. Open the IOU report room
  3. Now open the cash amount page for the request in the first step
  4. Click on the Avatar at the top of the cash amount page

Expected Result:

Should display one result,

  • the money request participants.
  • maybe the details of the request

Actual Result:

The results are different and buggy

  • Opening for the first time open a blank members page
  • leaving the cash amount page and returning > now click on the
    avatar again > this opens a member page contains just your profile
  • Now close the page and open it again > this opens your profile page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.57.5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.27-08-23.03_21_41.webm
Recording.4048.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693097210141829

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 27, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 27, 2023

    @melvin-bot

    Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. hungvu193 commented on Aug 27, 2023

    @hungvu193
    Contributor

    Proposal

    Fee like regression from #24624 where we tried to open pariticipant page when there's no member in a report.

    Please re-state the problem that we are trying to solve in this issue.

    Web - Blank members page displayed when open the cash amount page header for the first time

    What is the root cause of that problem?

    Problem came from this function:

    const showActorDetails = (report) => {
    if (ReportUtils.isExpenseReport(report)) {
    Navigation.navigate(ROUTES.getProfileRoute(report.ownerAccountID));
    return;
    }
    if (!ReportUtils.isIOUReport(report) && report.participantAccountIDs.length === 1) {
    Navigation.navigate(ROUTES.getProfileRoute(report.participantAccountIDs[0]));
    return;
    }
    Navigation.navigate(ROUTES.getReportParticipantsRoute(report.reportID));

    We checked for case report.participantAccountIDs.length === 1 but we didn't have check when participantAccountIDs is empty which caused the issue.

    What changes do you think we should make in order to solve the problem?

    I think we should also handle case when participantAccountIDs is empty.

        if (report.participantAccountIDs.length === 0) { 
              Navigation.navigate(ROUTES.getProfileRoute(report.ownerAccountID));
             return; 
         } 

    What alternative solutions did you explore? (Optional)

    N/A

  4. b4s36t4 commented on Aug 27, 2023

    @b4s36t4
    Contributor

    @hungvu193 Have you checked your solution?? I'm getting Notfound page with your solution.

  5. hungvu193 commented on Aug 27, 2023

    @hungvu193
    Contributor

    @hungvu193 Have you checked your solution?? I'm getting Notfound page with your solution.

    yeah, my mistake, we should use ownerAccountID incase participantAccountIDs is empty.

  6. spcheema commented on Aug 28, 2023

    @spcheema
    Contributor

    Checking this and will open PR to fix it shortly.

    There are 3 types of reports expected here:

    • iou
    • chat
    • expense

    The profile should be displayed for chat and expense reports when the report header avatar is clicked whereas iou report should display a list of participants (owner & manager)

    Ideally, there should not be any other case but I have added report detail navigation as a fallback route to prevent unexpected behavior.

    • if actionActorID is 0 or -1
    • Somebody mistakenly changed the logic to include any other report.

    Thanks @hungvu193 @b4s36t4 for your input.

    Here is PR: #26055

    CC: @youssef-lr

  7. 9 remaining items

  8. changed the title [-][HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time[/-] [+][HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time[/+] on Aug 30, 2023
  9. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-06. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  10. luacmartins commented on Sep 11, 2023

    @luacmartins
    Contributor

    This issue had the same root cause as #24389. So no payments are due here. Closing.

  11. Ahmed-Abdella commented on Sep 11, 2023

    @Ahmed-Abdella
    Contributor

    Sorry, @luacmartins but this is completely diiferent issue here this issue occurs after openeing the page from the amount page header, the other one (#24389) was about opening the page from the avatars in the chat, this wouldn't be fixed without this report. they had been fixed in the same PR but they are different. Shouldn't I be eligable for reporting bonus here?

  12. luacmartins commented on Sep 12, 2023

    @luacmartins
    Contributor

    Thanks for raising that @Ahmed-Abdella. I still think the root cause is the same and we usually compensate to fix root causes not every instance of a bug that comes from the same root cause.

  13. Ahmed-Abdella commented on Sep 12, 2023

    @Ahmed-Abdella
    Contributor

    @luacmartins No problem, what matters most is that all bugs was resolved, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions