You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time #26027
Now open the cash amount page for the request in the first step
Click on the Avatar at the top of the cash amount page
Expected Result:
Should display one result,
the money request participants.
maybe the details of the request
Actual Result:
The results are different and buggy
Opening for the first time open a blank members page
leaving the cash amount page and returning > now click on the
avatar again > this opens a member page contains just your profile
Now close the page and open it again > this opens your profile page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.57.5 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The profile should be displayed for chat and expense reports when the report header avatar is clicked whereas iou report should display a list of participants (owner & manager)
Ideally, there should not be any other case but I have added report detail navigation as a fallback route to prevent unexpected behavior.
if actionActorID is 0 or -1
Somebody mistakenly changed the logic to include any other report.
changed the title [-][HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time[/-][+][HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time[/+]on Aug 30, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
Sorry, @luacmartins but this is completely diiferent issue here this issue occurs after openeing the page from the amount page header, the other one (#24389) was about opening the page from the avatars in the chat, this wouldn't be fixed without this report. they had been fixed in the same PR but they are different. Shouldn't I be eligable for reporting bonus here?
Thanks for raising that @Ahmed-Abdella. I still think the root cause is the same and we usually compensate to fix root causes not every instance of a bug that comes from the same root cause.
Activity
OSBotify commentedon Aug 27, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 27, 2023
Triggered auto assignment to @youssef-lr (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.hungvu193 commentedon Aug 27, 2023
Proposal
Fee like regression from #24624 where we tried to open pariticipant page when there's no member in a report.
Please re-state the problem that we are trying to solve in this issue.
Web - Blank members page displayed when open the cash amount page header for the first time
What is the root cause of that problem?
Problem came from this function:
App/src/components/AvatarWithDisplayName.js
Lines 56 to 67 in c029dc5
We checked for case
report.participantAccountIDs.length === 1but we didn't have check whenparticipantAccountIDsis empty which caused the issue.What changes do you think we should make in order to solve the problem?
I think we should also handle case when
participantAccountIDsis empty.What alternative solutions did you explore? (Optional)
N/A
b4s36t4 commentedon Aug 27, 2023
@hungvu193 Have you checked your solution?? I'm getting Notfound page with your solution.
hungvu193 commentedon Aug 27, 2023
yeah, my mistake, we should use
ownerAccountIDincaseparticipantAccountIDsis empty.spcheema commentedon Aug 28, 2023
Checking this and will open PR to fix it shortly.
There are 3 types of reports expected here:
The profile should be displayed for
chatandexpensereports when the report header avatar is clicked whereasioureport should display a list of participants (owner & manager)Ideally, there should not be any other case but I have added report detail navigation as a fallback route to prevent unexpected behavior.
0or-1Thanks @hungvu193 @b4s36t4 for your input.
Here is PR: #26055
CC: @youssef-lr
9 remaining items
[-][HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time[/-][+][HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time[/+]melvin-bot commentedon Aug 30, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
luacmartins commentedon Sep 11, 2023
This issue had the same root cause as #24389. So no payments are due here. Closing.
Ahmed-Abdella commentedon Sep 11, 2023
Sorry, @luacmartins but this is completely diiferent issue here this issue occurs after openeing the page from the amount page header, the other one (#24389) was about opening the page from the avatars in the chat, this wouldn't be fixed without this report. they had been fixed in the same PR but they are different. Shouldn't I be eligable for reporting bonus here?
luacmartins commentedon Sep 12, 2023
Thanks for raising that @Ahmed-Abdella. I still think the root cause is the same and we usually compensate to fix root causes not every instance of a bug that comes from the same root cause.
Ahmed-Abdella commentedon Sep 12, 2023
@luacmartins No problem, what matters most is that all bugs was resolved, Thanks!