You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-29] [$1000] Android - Sign in background image is missing #26069
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.57-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@mananjadhavdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mananjadhav / @hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav / @hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav / @hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav / @hoangzinh] Determine if we should create a regression test for this bug.
[@mananjadhav / @hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Aug 28, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hoangzinh commentedon Aug 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Sign in background image is missing
What is the root cause of that problem?
In the Background image for Android platform, we just export a SVG component
App/src/pages/signin/SignInPageLayout/BackgroundImage/index.android.js
Lines 1 to 3 in bd81e8c
We haven't added
width/stylefor it as same as other platformsApp/src/pages/signin/SignInPageLayout/BackgroundImage/index.js
Lines 18 to 22 in bd81e8c
What changes do you think we should make in order to solve the problem?
We need to add
width & style & pointerEventsprops same as other platforms for this SVG component of Android platformApp/src/pages/signin/SignInPageLayout/BackgroundImage/index.android.js
Lines 1 to 3 in bd81e8c
Results:

jliexpensify commentedon Aug 29, 2023
I can't repro this on Android Chrome (v57-3):

jliexpensify commentedon Aug 29, 2023
Android app is on 58-1, and I can reproduce!
jliexpensify commentedon Aug 29, 2023
Also, on the Android app, you can scroll down - this definitely looks off. Not sure what's happening here, I've never seen this before:
[-] Android - Sign in background image is missing[/-][+][$1000] Android - Sign in background image is missing[/+]melvin-bot commentedon Aug 29, 2023
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam
melvin-bot commentedon Aug 29, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ad21987d10429685
49 remaining items
melvin-bot commentedon Sep 22, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jliexpensify commentedon Sep 25, 2023
Payment Summary:
Upwork job
@roryabraham - we're not penalising anyone due to the merge freeze right?
roryabraham commentedon Sep 26, 2023
Correct, no penalties here
jliexpensify commentedon Oct 2, 2023
Sorry everyone! I was OOO, paying now.
jliexpensify commentedon Oct 2, 2023
Paid out in Upworks and closed the job.
@mananjadhav still awaiting for you to complete the checklist, thanks!
add component with desktop and mobile backgrounds
mananjadhav commentedon Oct 2, 2023
We added the component in this PR. I've added a comment here.
But I don't think we need a regression test here.
jliexpensify commentedon Oct 3, 2023
Cool, closing this one - @mananjadhav here is the payment summary
JmillsExpensify commentedon Oct 5, 2023
$1,000 payment approved for @mananjadhav based on BZ summary.