Skip to content

[HOLD for payment 2023-09-29] [$1000] Android - Sign in background image is missing #26069

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign out if you are signed in

Expected Result:

There is a background image

Actual Result:

No background image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.57-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshot_1692336848

0-02-01-cf6e67ca431b3629d763c0a1ca4406c405616e076cd67231faa69c96c42d7bfc_c413990cbea152b7.mp4

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692337365083379

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ad21987d10429685
  • Upwork Job ID: 1696343238604079104
  • Last Price Increase: 2023-09-05
  • Automatic offers:
    • hoangzinh | Contributor | 26515059
    • bernhardoj | Reporter | 26515062

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 28, 2023
  2. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. hoangzinh commented on Aug 28, 2023

    @hoangzinh
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Android - Sign in background image is missing

    What is the root cause of that problem?

    In the Background image for Android platform, we just export a SVG component

    import backgroundImage from '../../../../../assets/images/home-background--android.svg';
    export default backgroundImage;

    We haven't added width/style for it as same as other platforms

    <MobileBackgroundImage
    pointerEvents={props.pointerEvents}
    width={props.width}
    style={styles.signInBackground}
    />

    What changes do you think we should make in order to solve the problem?

    We need to add width & style & pointerEvents props same as other platforms for this SVG component of Android platform

    import backgroundImage from '../../../../../assets/images/home-background--android.svg';
    export default backgroundImage;

    Results:
    Screenshot 2023-08-28 at 22 42 49

  5. jliexpensify commented on Aug 29, 2023

    @jliexpensify
    Contributor

    I can't repro this on Android Chrome (v57-3):
    Screenshot_20230829-115546

  6. jliexpensify commented on Aug 29, 2023

    @jliexpensify
    Contributor

    Android app is on 58-1, and I can reproduce!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 29, 2023
  8. jliexpensify commented on Aug 29, 2023

    @jliexpensify
    Contributor

    Also, on the Android app, you can scroll down - this definitely looks off. Not sure what's happening here, I've never seen this before:

    Screenshot_20230829-115954

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 29, 2023
  10. changed the title [-] Android - Sign in background image is missing[/-] [+][$1000] Android - Sign in background image is missing[/+] on Aug 29, 2023
  11. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

  12. melvin-bot commented on Aug 29, 2023

    @melvin-bot
  13. 49 remaining items

  14. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-29. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav / @hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
    • [@mananjadhav / @hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mananjadhav / @hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mananjadhav / @hoangzinh] Determine if we should create a regression test for this bug.
    • [@mananjadhav / @hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. jliexpensify commented on Sep 25, 2023

    @jliexpensify
    Contributor

    Payment Summary:

    Upwork job

    @roryabraham - we're not penalising anyone due to the merge freeze right?

  18. roryabraham commented on Sep 26, 2023

    @roryabraham
    Contributor

    Correct, no penalties here

  19. jliexpensify commented on Oct 2, 2023

    @jliexpensify
    Contributor

    Sorry everyone! I was OOO, paying now.

  20. jliexpensify commented on Oct 2, 2023

    @jliexpensify
    Contributor

    Paid out in Upworks and closed the job.

    @mananjadhav still awaiting for you to complete the checklist, thanks!

  21. mananjadhav commented on Oct 2, 2023

    @mananjadhav
    Collaborator

    We added the component in this PR. I've added a comment here.

    But I don't think we need a regression test here.

  22. jliexpensify commented on Oct 3, 2023

    @jliexpensify
    Contributor

    Cool, closing this one - @mananjadhav here is the payment summary

  23. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $1,000 payment approved for @mananjadhav based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions