You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-16] [$500] Add payment method popover has wrong position #26070
On report header, click pay button and then click arrow button
Observe popover positions
Expected Result:
Popover should show below button
Actual Result:
Popover overlaps with button
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.57-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. This is minor visual bug which doesn't affect user payment flow at all so no need regression test
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
Activity
melvin-bot commentedon Aug 28, 2023
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)StevenKKC commentedon Aug 28, 2023
Proposal
Please state again the problem we are trying to solve in this issue.
Add payment method popover has wrong position.
What is the cause of this issue?
We does not pass
anchorAlignmenttoPopoverMenuinAddPaymentMethodMenu.App/src/components/SettlementButton.js
Line 173 in 08c2f5d
App/src/components/KYCWall/BaseKYCWall.js
Line 137 in 08c2f5d
App/src/components/AddPaymentMethodMenu.js
Line 53 in 08c2f5d
And after redesign money request report, calculating anchor position in
getAnchorPositiondoes not updated.App/src/components/KYCWall/BaseKYCWall.js
Lines 64 to 76 in 08c2f5d
What changes do you think we should make to solve the problem?
First, we should pass
anchorAlignmenttoKYCWall,AddPaymentMethodMenuandPopoverMenu.SettlementButton.jsBaseKYCWall.jsAddPaymentMethodMenu.jsSecond, we should update anchor position calculating in
getAnchorPositionfunction.We can modify calculating like drop down menu.
What alternative solutions have you investigated? (Optional)
None.
aimane-chnaif commentedon Aug 28, 2023
@alexpensify as a bug reporter, I'd like to review this as C+ as I already have context while reviewing another PR
alexpensify commentedon Aug 30, 2023
I'm catching up from being OOO, I will test soon.
[-]Add payment method popover has wrong position[/-][+][$500] Add payment method popover has wrong position[/+]melvin-bot commentedon Aug 31, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a94242021f694c9e
melvin-bot commentedon Aug 31, 2023
Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Aug 31, 2023
Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.
76 remaining items
melvin-bot commentedon Oct 9, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 9, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
alexpensify commentedon Oct 17, 2023
I will work on the payment process today
alexpensify commentedon Oct 18, 2023
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~01a94242021f694c9e
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment:
This issue was created before August 30, so it will follow the old payment structure. I need to update @Nikhil-Vats' payment and will do so now.
[HOLD for payment 2023-10-16] [$500] Add payment method popover has wrong position #26070 (comment) there is an urgency bonus and no regression. I'm going to factor these into the final payments.
alexpensify commentedon Oct 18, 2023
@aimane-chnaif - I need you to accept the remaining payment for C+ in Upwork. Also, please complete the checklist so we can close this GH. Thanks!
alexpensify commentedon Oct 18, 2023
Alright, @aimane-chnaif you've been paid via Upwork for reporting and C+. Please complete the checklist, thanks! I want to close this GH asap.
aimane-chnaif commentedon Oct 19, 2023
alexpensify commentedon Oct 19, 2023
Thanks! Closing this GH since all actions have been completed here.