You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page #26178
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page[/-][+][HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page[/+]on Sep 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Hey @maddylewis this GH was created on Aug 29, thus prior to the bounty decrease announcement. The right amount for reporting bonus should be $250 not $50. Thanks :)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: N/A
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Send any message on any chat A
Switch to another chat B
Click browser back button to go back to A
On A, hover message and click delete icon
Verify that delete confirmation popover shows
Click browser forward button to go forward to B
Verify that delete confirmation popover disappears
Activity
melvin-bot commentedon Aug 29, 2023
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 29, 2023
OSBotify commentedon Aug 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 29, 2023
Triggered auto assignment to @youssef-lr (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mkarkachov commentedon Aug 29, 2023
Same issue as #25598
Nathan-Mulugeta commentedon Aug 29, 2023
I don't think it is the same issue, this is found only on staging which means it has been introduced yesterday when the new release was pushed.
luacmartins commentedon Aug 29, 2023
@youssef-lr what's the latest here?
53 remaining items
[-][HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page[/-][+][HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page[/+]melvin-bot commentedon Sep 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 25, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 2, 2023
@youssef-lr, @maddylewis, @aimane-chnaif, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
maddylewis commentedon Oct 2, 2023
Payments:
maddylewis commentedon Oct 2, 2023
@aimane-chnaif - will you review this checklist when you have a chance? thanks #26178 (comment)
Nathan-Mulugeta commentedon Oct 2, 2023
Hey @maddylewis this GH was created on Aug 29, thus prior to the bounty decrease announcement. The right amount for reporting bonus should be $250 not $50. Thanks :)
aimane-chnaif commentedon Oct 2, 2023
Regression Test Proposal
maddylewis commentedon Oct 4, 2023
updated reporting payment for @Nathan-Mulugeta - everyone is paid / closing