Skip to content

[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page #26178

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat
  2. Send a message
  3. Reply in thread of the message sent
  4. Hold on the last sent message inside the thread
  5. Click on the back button

Expected Result:

The context menu should close after user goes back to the previous page

Actual Result:

The context menu remains open after user goes back to the previous page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.58-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230829_113536_Chrome.mp4
Screen.Recording.20230829.140012.Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693298251936699

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b3a9d92fe2b1c968
  • Upwork Job ID: 1701151842381410304
  • Last Price Increase: 2023-09-11
  • Automatic offers:
    • tienifr | Contributor | 26629317
    • Nathan-Mulugeta | Reporter | 26629320
    • aimane-chnaif | Contributor | 26629407

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 29, 2023
  2. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 29, 2023

    @melvin-bot
  4. OSBotify commented on Aug 29, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. mkarkachov commented on Aug 29, 2023

    @mkarkachov
    Contributor

    Same issue as #25598

  7. Nathan-Mulugeta commented on Aug 29, 2023

    @Nathan-Mulugeta

    I don't think it is the same issue, this is found only on staging which means it has been introduced yesterday when the new release was pushed.

  8. luacmartins commented on Aug 29, 2023

    @luacmartins
    Contributor

    @youssef-lr what's the latest here?

  9. 53 remaining items

  10. changed the title [-][HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page[/-] [+][HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page[/+] on Sep 25, 2023
  11. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-02. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    @youssef-lr, @maddylewis, @aimane-chnaif, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. maddylewis commented on Oct 2, 2023

    @maddylewis
    Contributor

    Payments:

  15. maddylewis commented on Oct 2, 2023

    @maddylewis
    Contributor

    @aimane-chnaif - will you review this checklist when you have a chance? thanks #26178 (comment)

  16. Nathan-Mulugeta commented on Oct 2, 2023

    @Nathan-Mulugeta

    Hey @maddylewis this GH was created on Aug 29, thus prior to the bounty decrease announcement. The right amount for reporting bonus should be $250 not $50. Thanks :)

  17. aimane-chnaif commented on Oct 2, 2023

    @aimane-chnaif
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: N/A
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Send any message on any chat A
    2. Switch to another chat B
    3. Click browser back button to go back to A
    4. On A, hover message and click delete icon
    5. Verify that delete confirmation popover shows
    6. Click browser forward button to go forward to B
    7. Verify that delete confirmation popover disappears
  18. maddylewis commented on Oct 4, 2023

    @maddylewis
    Contributor

    updated reporting payment for @Nathan-Mulugeta - everyone is paid / closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions