You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-09] [$500] IOU - Content in IOU thread and details page has different shade of gray when created offline #26235
Click on the IOU preview in 1:1 DM to open IOU report
Click on the IOU preview in IOU report to open IOU details page
Expected Result:
The content in the IOU details page should be the same opacity as the IOU report page which is 50% (not 25% which is happening because we're 50% opacity is being applied twice)
Actual Result:
The content in both IOU report and IOU details page has different shade of gray when created offline.
IOU details page has lighter gray than IOU report
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome
MacOS / Desktop
Version Number: 1.3.58-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Please re-state the problem that we are trying to solve in this issue.
IOU - Content in IOU thread and details page has different shade of gray when created offline
What is the root cause of that problem?
MoneyRequestView content is wrapped by two OfflineWithFeedback here and here.
When creating a request for money in offline mode, both will have opacity. This makes that content has a different grayless level. TaskView content has the same issue.
What changes do you think we should make in order to solve the problem?
We should remove OfflineWithFeedback in ReportActionItemhere and here.
We also need to wrap the receipt image here into OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingAction')}.
changed the title [-][$500] IOU - Content in IOU thread and details page has different shade of gray when created offline[/-][+][HOLD for payment 2023-10-09] [$500] IOU - Content in IOU thread and details page has different shade of gray when created offline[/+]on Oct 2, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
[@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cubuspl42] Determine if we should create a regression test for this bug.
[@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
No need for additional discussion
Determine if we should create a regression test for this bug.
Up to the QA team
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Be offline.
Plus > Request money.
Open the IOU details page.
Verify that the level of grey is as usual (50%).
Be online.
Verify that there is no grey in the content.
Be offline again.
Update the Amount, Description, Date, and Merchant.
Verify again that the level of grey is as usual (50%).
Activity
melvin-bot commentedon Aug 29, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)StevenKKC commentedon Aug 29, 2023
Proposal
Please state again the problem we are trying to solve in this issue.
Content in IOU thread and details page has different shade of gray when created offline.
What is the cause of this issue?
MoneyReportViewandMoneyRequestVieware wrapped withOfflineWithFeedback.App/src/pages/home/report/ReportActionItem.js
Lines 509 to 514 in 0a7aabd
App/src/pages/home/report/ReportActionItem.js
Lines 488 to 493 in 0a7aabd
And "Amount Cash", "Description", "Date" and "Merchant" in
MoneyRequestVieware also wrapped withOfflineWithFeedbackagain.App/src/components/ReportActionItem/MoneyRequestView.js
Lines 113 to 154 in 0a7aabd
So
MoneyRequestViewhas more gray thanMoneyReportView.What changes do you think we should make to solve the problem?
We can remove
OfflineWithFeedbackfor "Amount Cash", "Description", "Date" and "Merchant" inMoneyRequestView.What alternative solutions have you investigated? (Optional)
None.
ginsuma commentedon Aug 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU - Content in IOU thread and details page has different shade of gray when created offline
What is the root cause of that problem?
MoneyRequestViewcontent is wrapped by two OfflineWithFeedback here and here.When creating a request for money in offline mode, both will have opacity. This makes that content has a different grayless level.
TaskViewcontent has the same issue.What changes do you think we should make in order to solve the problem?
We should remove
OfflineWithFeedbackinReportActionItemhere and here.We also need to wrap the receipt image here into
OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingAction')}.mallenexpensify commentedon Sep 4, 2023
Was able to reproduce


isn't the same as
Gonna tag design for quick 👀 to ensure we're following the proper design guidelines since I'm not 100% we want the latter to be similar to the former.
melvin-bot commentedon Sep 4, 2023
Triggered auto assignment to @dannymcclain (
Design), see these Stack Overflow questions for more details.55 remaining items
[-][$500] IOU - Content in IOU thread and details page has different shade of gray when created offline[/-][+][HOLD for payment 2023-10-09] [$500] IOU - Content in IOU thread and details page has different shade of gray when created offline[/+]melvin-bot commentedon Oct 2, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 2, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 2, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jakub-trzebiatowski commentedon Oct 6, 2023
mallenexpensify commentedon Oct 9, 2023
Issue reporter: Applause
Contributor: @ginsuma paid $500 via Upwork
Contributor+: @cubuspl42 paid $500 via Upwork.
Thanks @cubuspl42 , I created the TestRail GH, we def won't check this on every regression test, maybe monthly?
jakub-trzebiatowski commentedon Oct 9, 2023
@mallenexpensify As I shared in the other thread, I don't have a good intuition here! Monthly sounds fine for me