Skip to content

[HOLD for payment 2023-10-09] [$500] IOU - Content in IOU thread and details page has different shade of gray when created offline #26235

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify,com
  2. Go offline
  3. Request money from another use
  4. Click on the IOU preview in 1:1 DM to open IOU report
  5. Click on the IOU preview in IOU report to open IOU details page

Expected Result:

The content in the IOU details page should be the same opacity as the IOU report page which is 50% (not 25% which is happening because we're 50% opacity is being applied twice)

Actual Result:

The content in both IOU report and IOU details page has different shade of gray when created offline.
IOU details page has lighter gray than IOU report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome
  • MacOS / Desktop

Version Number: 1.3.58-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

20230829_132043.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018e8fb9fd0bfc8897
  • Upwork Job ID: 1702212936758927360
  • Last Price Increase: 2023-09-14
  • Automatic offers:
    • cubuspl42 | Reviewer | 26770276
    • ginsuma | Contributor | 26770278

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 29, 2023
  2. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. StevenKKC commented on Aug 29, 2023

    @StevenKKC
    Contributor

    Proposal

    Please state again the problem we are trying to solve in this issue.

    Content in IOU thread and details page has different shade of gray when created offline.

    What is the cause of this issue?

    MoneyReportView and MoneyRequestView are wrapped with OfflineWithFeedback.

    <OfflineWithFeedback pendingAction={props.action.pendingAction}>
    <MoneyReportView
    report={props.report}
    shouldShowHorizontalRule={!props.shouldHideThreadDividerLine}
    />
    </OfflineWithFeedback>

    <OfflineWithFeedback pendingAction={props.action.pendingAction}>
    <MoneyRequestView
    report={props.report}
    shouldShowHorizontalRule={!props.shouldHideThreadDividerLine}
    />
    </OfflineWithFeedback>

    And "Amount Cash", "Description", "Date" and "Merchant" in MoneyRequestView are also wrapped with OfflineWithFeedback again.
    <OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingFields.amount') || lodashGet(transaction, 'pendingAction')}>
    <MenuItemWithTopDescription
    title={formattedTransactionAmount ? formattedTransactionAmount.toString() : ''}
    shouldShowTitleIcon={isSettled}
    titleIcon={Expensicons.Checkmark}
    description={description}
    titleStyle={styles.newKansasLarge}
    disabled={isSettled || !canEdit}
    shouldShowRightIcon={canEdit}
    onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.AMOUNT))}
    />
    </OfflineWithFeedback>
    <OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingFields.comment') || lodashGet(transaction, 'pendingAction')}>
    <MenuItemWithTopDescription
    description={translate('common.description')}
    title={transactionDescription}
    disabled={isSettled || !canEdit}
    shouldShowRightIcon={canEdit}
    titleStyle={styles.flex1}
    onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.DESCRIPTION))}
    />
    </OfflineWithFeedback>
    <OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingFields.created') || lodashGet(transaction, 'pendingAction')}>
    <MenuItemWithTopDescription
    description={translate('common.date')}
    title={transactionDate}
    disabled={isSettled || !canEdit}
    shouldShowRightIcon={canEdit}
    titleStyle={styles.flex1}
    onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.DATE))}
    />
    </OfflineWithFeedback>
    <OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingFields.merchant') || lodashGet(transaction, 'pendingAction')}>
    <MenuItemWithTopDescription
    description={isDistanceRequest ? translate('common.distance') : translate('common.merchant')}
    title={transactionMerchant}
    disabled={isSettled || !canEdit}
    shouldShowRightIcon={canEdit}
    titleStyle={styles.flex1}
    onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.MERCHANT))}
    />
    </OfflineWithFeedback>

    So MoneyRequestView has more gray than MoneyReportView.

    What changes do you think we should make to solve the problem?

    We can remove OfflineWithFeedback for "Amount Cash", "Description", "Date" and "Merchant" in MoneyRequestView.

    What alternative solutions have you investigated? (Optional)

    None.

  5. ginsuma commented on Aug 29, 2023

    @ginsuma
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    IOU - Content in IOU thread and details page has different shade of gray when created offline

    What is the root cause of that problem?

    MoneyRequestView content is wrapped by two OfflineWithFeedback here and here.
    When creating a request for money in offline mode, both will have opacity. This makes that content has a different grayless level.
    TaskView content has the same issue.

    What changes do you think we should make in order to solve the problem?

    We should remove OfflineWithFeedback in ReportActionItem here and here.
    We also need to wrap the receipt image here into OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingAction')}.

  6. mallenexpensify commented on Sep 4, 2023

    @mallenexpensify
    Contributor

    Was able to reproduce
    image
    isn't the same as
    image

    Gonna tag design for quick 👀 to ensure we're following the proper design guidelines since I'm not 100% we want the latter to be similar to the former.

  7. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

  8. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 4, 2023
  9. removed their assignment
    on Sep 4, 2023
  10. 55 remaining items

  11. changed the title [-][$500] IOU - Content in IOU thread and details page has different shade of gray when created offline[/-] [+][HOLD for payment 2023-10-09] [$500] IOU - Content in IOU thread and details page has different shade of gray when created offline[/+] on Oct 2, 2023
  12. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-09. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
    • [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@cubuspl42] Determine if we should create a regression test for this bug.
    • [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. jakub-trzebiatowski commented on Oct 6, 2023

    @jakub-trzebiatowski
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
      • No need for additional discussion
    • Determine if we should create a regression test for this bug.
      • Up to the QA team
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
      • Be offline.
      • Plus > Request money.
      • Open the IOU details page.
      • Verify that the level of grey is as usual (50%).
      • Be online.
      • Verify that there is no grey in the content.
      • Be offline again.
      • Update the Amount, Description, Date, and Merchant.
      • Verify again that the level of grey is as usual (50%).
      • Be online again.
      • Verify that there is no grey in the content.
  16. mallenexpensify commented on Oct 9, 2023

    @mallenexpensify
    Contributor

    Issue reporter: Applause
    Contributor: @ginsuma paid $500 via Upwork
    Contributor+: @cubuspl42 paid $500 via Upwork.

    Thanks @cubuspl42 , I created the TestRail GH, we def won't check this on every regression test, maybe monthly?

  17. jakub-trzebiatowski commented on Oct 9, 2023

    @jakub-trzebiatowski
    Contributor

    @mallenexpensify As I shared in the other thread, I don't have a good intuition here! Monthly sounds fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions