[HOLD Safari 17.4][$1000] [mWeb/Safari] Fix safari unfocused selection prop

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Break down in numbered steps

We have a bug that is specific to mWeb/Safari that causes us to continue making safari specific updates in our code

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 120 to 122 in bb2386b

    
           // For mobile Safari, updating the selection prop on an unfocused input will cause it to automatically gain focus 
        
           // and subsequent programmatic focus shifts (e.g., modal focus trap) to show the blue frame (:focus-visible style), 
        
           // so we need to ensure that it is only updated after focus.

f74dbb1

To reduce the amount of platform specific code in our repo - let's aim to get this fixed upstream. Creating this issue to track for when we can do this

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b2f48b6c5a3887bd
Upwork Job ID: 1700115117826949120
Last Price Increase: 2024-06-05
Automatic offers:

getusha | Contributor | 102518816

@michaelhaxhiu

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Adding monthly as an upstream fix might take a while

Job added to Upwork: https://www.upwork.com/jobs/~01b2f48b6c5a3887bd

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

I've reviewed the summary again and realized that I based it off the PR creation date. My mistake, the updated summary is here:

#26239 (comment)

Upwork job price has been updated to $1000

@ntdiary

@ntdiary - Here is the update from April 4 regarding the changes to the job prices:

https://expensify.slack.com/archives/C01GTK53T8Q/p1712256409152489

@alexpensify, Thank you! BTW, I have received the first payment through ND yesterday, and will start this issue request later. 😄

@ntdiary

$1,000 approved for @ntdiary

@getusha

@getusha, are you set up for payments, so we can close out this issue? Thanks!

@getusha

@getusha, are you set up for payments, so we can close out this issue? Thanks!

@alexpensify not yet, i received an invitation last week. I think the process is yet to begin.

Thanks for the update!

@alexpensify

@alexpensify since i was assigned before 2024-05-25 can we process the payment via upwork?

@getusha

@getusha ok, I sent over a new offer in Upwork. Please accept here: https://www.upwork.com/jobs/~019cb418da52a59d59

I can complete the next steps after you accept this new offer. Thanks!

@alexpensify

@alexpensify, Accepted, thank you!

@getusha

All set here, I've completed the payment process to @getusha. Everyone has been paid accordingly: #26239 (comment).

Navigation Menu

Repository navigation

[HOLD Safari 17.4][$1000] [mWeb/Safari] Fix safari unfocused selection prop #26239

Action Performed:

Platforms:

Bug0 Triage Checklist (Main S/O)

173 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// For mobile Safari, updating the selection prop on an unfocused input will cause it to automatically gain focus
	// and subsequent programmatic focus shifts (e.g., modal focus trap) to show the blue frame (:focus-visible style),
	// so we need to ensure that it is only updated after focus.

[HOLD Safari 17.4][$1000] [mWeb/Safari] Fix safari unfocused selection prop #26239

Description

Action Performed:

Platforms:

Activity

melvin-bot commented on Aug 29, 2023

melvin-bot commented on Aug 29, 2023

Bug0 Triage Checklist (Main S/O)

thienlnam commented on Aug 29, 2023

melvin-bot commented on Sep 8, 2023

melvin-bot commented on Sep 8, 2023

173 remaining items

alexpensify commented on Jun 5, 2024

melvin-bot commented on Jun 5, 2024

ntdiary commented on Jun 11, 2024

JmillsExpensify commented on Jun 11, 2024

alexpensify commented on Jun 12, 2024

getusha commented on Jun 13, 2024

alexpensify commented on Jun 13, 2024

getusha commented on Jul 9, 2024

alexpensify commented on Jul 9, 2024

getusha commented on Jul 9, 2024

alexpensify commented on Jul 9, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions