You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-02] [$500] Workspace - In Invite new members the "Contacts" caption does not disappear when scrolling #26243
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
On Invite new members page, "Contacts" header is overlapped when scrolling
What is the root cause of that problem?
stickySectionHeadersEnabled prop is set to true as default in SectionList. And in BaseSelectionList, this prop isn't set.
The issue didn't exist before because this page used BaseOptionsList where this prop is set to false
What changes do you think we should make in order to solve the problem?
Solution 1: set stickySectionHeadersEnabled to false to be consistent
Solution 2: if we wanna keep sticky header, set header background color same as page background color
@mkhutornyi@situchan sent you both offers in Upwork for the bonus amount. Please let me know once you accept and I can get those paid. Thanks for your patience with this!
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
No need regression test as this is super minor UI bug and not affect users.
Activity
OSBotify commentedon Aug 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 29, 2023
Triggered auto assignment to @hayata-suenaga (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mkhutornyi commentedon Aug 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
On Invite new members page, "Contacts" header is overlapped when scrolling
What is the root cause of that problem?
stickySectionHeadersEnabledprop is set to true as default in SectionList. And in BaseSelectionList, this prop isn't set.The issue didn't exist before because this page used BaseOptionsList where this prop is set to false
What changes do you think we should make in order to solve the problem?
Solution 1: set
stickySectionHeadersEnabledto false to be consistentSolution 2: if we wanna keep sticky header, set header background color same as page background color
situchan commentedon Aug 29, 2023
This is not a deploy blocker. This came from #22622 which was deployed to production yesterday.
luacmartins commentedon Aug 29, 2023
This is reproducible in production, so NAB. Removing the label.
situchan commentedon Aug 30, 2023
@mkhutornyi's proposal looks good. I think we should disable iOS sticky behavior in SelectionList to be consistent with OptionsList.
43 remaining items
mkhutornyi commentedon Oct 3, 2023
This is eligible for bonus as delay was just from merge freeze
CortneyOfstad commentedon Oct 3, 2023
@hayata-suenaga can you confirm if that qualifies for the bonus?
CortneyOfstad commentedon Oct 4, 2023
@hayata-suenaga bump on the above — thanks!
hayata-suenaga commentedon Oct 5, 2023
ops sorry I missed this 😓
@mkhutornyi can you provide the summary of dates so that we can check?
mkhutornyi commentedon Oct 5, 2023
Assign: Sep 6 10:34 AM CST
PR approval: Sep 7 3:04 PM CST
CortneyOfstad commentedon Oct 5, 2023
@mkhutornyi @situchan sent you both offers in Upwork for the bonus amount. Please let me know once you accept and I can get those paid. Thanks for your patience with this!
CortneyOfstad commentedon Oct 6, 2023
Both payments have been made! @situchan where are we at with the checklist above? Thanks!
situchan commentedon Oct 6, 2023
No need regression test as this is super minor UI bug and not affect users.
CortneyOfstad commentedon Oct 6, 2023
Perfect! Thanks @situchan! Closing this!