Skip to content

[HOLD for payment 2023-10-02] [$500] Workspace - In Invite new members the "Contacts" caption does not disappear when scrolling #26243

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Prerequisites:
Log in to HT account.
Steps:

  1. Open New Expensify app
  2. Go to Settings
  3. Go to WorkSpace
  4. Open or create a WS
  5. Go to Members
  6. Tap the "Invite" button
  7. Scroll up the contact list

Expected Result:

The caption "Contacts" should be above the list of contacts and when scrolling go up and disappear

Actual Result:

The "Contacts" caption remains in place when scrolling through the contact list and is displayed at the top of the contact list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.58-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6181692_RPReplay_Final1693323937.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010f0f40876a997e8c
  • Upwork Job ID: 1696980437682036736
  • Last Price Increase: 2023-09-06
  • Automatic offers:
    • situchan | Reviewer | 26529846
    • mkhutornyi | Contributor | 26529849

Activity

  1. OSBotify commented on Aug 29, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. mkhutornyi commented on Aug 29, 2023

    @mkhutornyi
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On Invite new members page, "Contacts" header is overlapped when scrolling

    What is the root cause of that problem?

    stickySectionHeadersEnabled prop is set to true as default in SectionList. And in BaseSelectionList, this prop isn't set.
    The issue didn't exist before because this page used BaseOptionsList where this prop is set to false

    What changes do you think we should make in order to solve the problem?

    Solution 1: set stickySectionHeadersEnabled to false to be consistent
    Solution 2: if we wanna keep sticky header, set header background color same as page background color

  4. situchan commented on Aug 29, 2023

    @situchan
    Contributor

    This is not a deploy blocker. This came from #22622 which was deployed to production yesterday.

  5. luacmartins commented on Aug 29, 2023

    @luacmartins
    Contributor

    This is reproducible in production, so NAB. Removing the label.

  6. situchan commented on Aug 30, 2023

    @situchan
    Contributor

    @mkhutornyi's proposal looks good. I think we should disable iOS sticky behavior in SelectionList to be consistent with OptionsList.

  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed on Aug 30, 2023
  8. 43 remaining items

  9. mkhutornyi commented on Oct 3, 2023

    @mkhutornyi
    Contributor

    This is eligible for bonus as delay was just from merge freeze

  10. CortneyOfstad commented on Oct 3, 2023

    @CortneyOfstad
    Contributor

    @hayata-suenaga can you confirm if that qualifies for the bonus?

  11. CortneyOfstad commented on Oct 4, 2023

    @CortneyOfstad
    Contributor

    @hayata-suenaga bump on the above — thanks!

  12. hayata-suenaga commented on Oct 5, 2023

    @hayata-suenaga
    Contributor

    ops sorry I missed this 😓

    @mkhutornyi can you provide the summary of dates so that we can check?

  13. mkhutornyi commented on Oct 5, 2023

    @mkhutornyi
    Contributor

    Assign: Sep 6 10:34 AM CST
    PR approval: Sep 7 3:04 PM CST

  14. CortneyOfstad commented on Oct 5, 2023

    @CortneyOfstad
    Contributor

    @mkhutornyi @situchan sent you both offers in Upwork for the bonus amount. Please let me know once you accept and I can get those paid. Thanks for your patience with this!

  15. CortneyOfstad commented on Oct 6, 2023

    @CortneyOfstad
    Contributor

    Both payments have been made! @situchan where are we at with the checklist above? Thanks!

  16. situchan commented on Oct 6, 2023

    @situchan
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: refactor: SelectionList multiple selection #22622
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22622/files#r1348750497
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug.
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    No need regression test as this is super minor UI bug and not affect users.

  17. CortneyOfstad commented on Oct 6, 2023

    @CortneyOfstad
    Contributor

    Perfect! Thanks @situchan! Closing this!

  18. added
    ReviewingHas a PR in review
    and removed on Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions