Skip to content

[HOLD for payment 2023-09-07] [$500] [HOLD for payment 2023-09-06] Web - App crashes for user B when user A deletes IOU request while both users opens the same request #26251

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Action Performed:

  1. Click on FAB on user A
  2. Click on request money and send request to user B
  3. Open the same request on both user A and user B
  4. Delete the request from user A side

Expected Result:

The app should handle the deleted request by showing the "Hmm...it's not here" message

Actual Result:

The app crashes on user B side

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.58-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-08-29.22-36-24.mp4

Screenshot 2023-08-29 230106

Recording.4069.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jo-ui
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693338346189599

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012f5cb1b3e1c47695
  • Upwork Job ID: 1696999715134431232
  • Last Price Increase: 2023-08-30

Activity

  1. OSBotify commented on Aug 29, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. luacmartins commented on Aug 29, 2023

    @luacmartins
    Contributor

    I can't reproduce this issue

    bug.mov
  4. luacmartins commented on Aug 29, 2023

    @luacmartins
    Contributor

    Fix is merged and being CPed. Removing blocker label. Gonna add Bug label to process report bonus payment.

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 29, 2023
  6. melvin-bot commented on Aug 29, 2023

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. 22 remaining items

  8. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 30, 2023
  9. kevinksullivan commented on Aug 30, 2023

    @kevinksullivan
    Contributor

    Hi @jo-ui can you submit an app for this job so I can pay out reporting?

    https://www.upwork.com/jobs/~012f5cb1b3e1c47695

  10. changed the title [-][$500] [HOLD for payment 2023-09-06] Web - App crashes for user B when user A deletes IOU request while both users opens the same request[/-] [+][HOLD for payment 2023-09-07] [$500] [HOLD for payment 2023-09-06] Web - App crashes for user B when user A deletes IOU request while both users opens the same request[/+] on Aug 31, 2023
  11. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
    • [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@luacmartins] Determine if we should create a regression test for this bug.
    • [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. jo-ui commented on Aug 31, 2023

    @jo-ui

    @kevinksullivan I've applied for the job on upwork.

  14. kevinksullivan commented on Sep 6, 2023

    @kevinksullivan
    Contributor

    accepted offer @jo-ui . Let me know when you've accepted and I'll pay this out.

  15. jo-ui commented on Sep 7, 2023

    @jo-ui

    @kevinksullivan I've accepted the offer.

  16. kevinksullivan commented on Sep 7, 2023

    @kevinksullivan
    Contributor

    All set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions