[HOLD for payment 2023-10-09] [$500] A new tab opens when downloading offline

@daveSeife

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

From user A, Send an attachment to user B.
Be offline for user B before opening the attachment
Click on the attachment sent from User A
Click on the download button at the top

Expected Result:

the inactive download button is shown.

Actual Result:

A new tab is opened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.58-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

T117-1.mp4

Recording.1530.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692409444867919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0159b5b921ce8fa955
Upwork Job ID: 1699136998481727488
Last Price Increase: 2023-09-19
Automatic offers:

fedirjh | Reviewer | 26848952
daveSeife | Reporter | 26848953

@tjferriss

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hello, my idea is to make the download button inactive when the user is offline. We could make an event listener when the pop-up is injected in the code to get the network status of the user.

@jjmilad

📣 @jjmilad! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Proposal

Please re-state the problem that we are trying to solve in this issue.

A new tab opens when downloading offline

What is the root cause of that problem?

Download button is not hidden & we open external link of the attachment when download fails.

App/src/libs/fileDownload/index.js

Lines 40 to 44 in 10ad0cb

    
           .catch(() => { 
        
               // file could not be downloaded, open sourceURL in new tab 
        
               Link.openExternalLink(url); 
        
               return resolve(); 
        
           });

What changes do you think we should make in order to solve the problem?

We can hide or disable the download button when user is offline, using isOffline state.
const {isOffline} = useNetwork();

App/src/components/AttachmentModal.js

Line 342 in 6e17b64

shouldShowDownloadButton={props.allowDownload && shouldShowDownloadButton}

And update this line to:
shouldShowDownloadButton={props.allowDownload && shouldShowDownloadButton && !isOffline}

Result:

Monosnap.screencast.2023-08-30.17-55-58.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user is offline, the "Download Attachment" button should be disabled instead of opening a new tab.

What is the root cause of that problem?

We do not handle the user's network status.

What changes do you think we should make in order to solve the problem?

For HeaderWithBackButton, along with shouldShowDownloadButton, add a boolean property shouldDisableDownloadButton

App/src/components/HeaderWithBackButton/headerWithBackButtonPropTypes.js

Line 29 in 6e17b64

shouldShowDownloadButton: PropTypes.bool,
In HeaderWithBackButton, while rendering the PressableWithoutFeedback, pass the disabled property:

App/src/components/HeaderWithBackButton/index.js

Line 95 in 6e17b64

<PressableWithoutFeedback

<PressableWithoutFeedback
    ...
    disabled={shouldDisableDownloadButton}
>

Compose the AttachmentModal using withNetwork() and render <HeaderWithBackButton> with shouldDisableDownloadButton={props.network.isOffline}

download-button-disabled.mov

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user is offline, the "Download Attachment" button should be disabled instead of opening a new tab.

What is the root cause of that problem?

We do not handle the user's network status.
But this is not correct problem.
We have to allow user to download images that he received before.

What changes do you think we should make in order to solve the problem?

add a boolean property shouldDisableDownloadButton under shouldShowDownloadButton on HeaderWithBackButton

App/src/components/HeaderWithBackButton/headerWithBackButtonPropTypes.js

Line 29 in 6e17b64

shouldShowDownloadButton: PropTypes.bool,
On HeaderWithBackButton, we need to add PressableWithoutFeedback as disable

App/src/components/HeaderWithBackButton/index.js

Line 95 in 6e17b64

<PressableWithoutFeedback

<PressableWithoutFeedback
    ...
    disabled={shouldDisableDownloadButton}
>

We don't need to check network status (because we have allow user to download old images without network).

shouldDisableDownloadButton = {_.isEmpty(props.source)}

Need to add this code to under components

App/src/components/AttachmentModal.js

Line 339 in 4675db5

<HeaderWithBackButton

What alternative solutions did you explore? (Optional)

@tjferriss

@tjferriss Eep! 4 days overdue now. Issues have feelings too...

I'm able to reproduce. If we're able to download the attachment then we should. If not, then we'd want to somehow tell the user they need to go online to access the attachment.

Reviewing label has been removed, please complete the "BugZero Checklist".

@fedirjh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix new tab opens when downloading offline #28114

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment offer (Reviewer)
@StevenKKC requires payment
@daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@fedirjh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@daveSeife

Payment summary:

Issue reporter @daveSeife $250
Contributor @StevenKKC $750
Contributor+ reviewer @fedirjh $750

Eligible for 50% speed bonus

@tjferriss

@tjferriss I am afraid to let you know that My Upwork account is suspended so I couldn't get paid with my account. May I send proposal with my friend's account?

@StevenKKC

@StevenKKC that's fine. They can apply for the posting here: https://www.upwork.com/jobs/~0159b5b921ce8fa955.

Please comment here with their name once they've applied.

@tjferriss

Thank you @tjferriss I submit proposal with my friend's account.
This is profile link: https://www.upwork.com/freelancers/~0188155b8a5d85a491

@StevenKKC

@StevenKKC I just sent an offer to your friend.

BugZero Checklist:

Link to the PR: This doesn’t seem to be a recent regression, The code for opening the new tab was present for over 2 years.
Link to discussion: N/A, There is Nothing we can add to the checklist, we should require a regression test for this bug.
Determine if we should create a regression test for this bug:

Regression Test Proposal

From user A, Send an attachment to user B.
Be offline for user B before opening the attachment
Hover over the attachment and open the context menu
Verify that there is no download option in the context menu
Click on the attachment to open it
Verify that there is no download button at the attachment header
Go online
Verify that you can download the attachment from the context menu and from the attachment header

Do we agree 👍 or 👎

All payments have been sent via Upworks and the regression test has been proposed.

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-09] [$500] A new tab opens when downloading offline #26258

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

47 remaining items

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	.catch(() => {
	// file could not be downloaded, open sourceURL in new tab
	Link.openExternalLink(url);
	return resolve();
	});

[HOLD for payment 2023-10-09] [$500] A new tab opens when downloading offline #26258

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 29, 2023

melvin-bot commented on Aug 29, 2023

Bug0 Triage Checklist (Main S/O)

jjmilad commented on Aug 29, 2023

melvin-bot commented on Aug 29, 2023

Krishna2323 commented on Aug 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

paultsimura commented on Aug 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

yh-0218 commented on Aug 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 4, 2023

tjferriss commented on Sep 5, 2023

47 remaining items

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

tjferriss commented on Oct 3, 2023

StevenKKC commented on Oct 3, 2023

tjferriss commented on Oct 3, 2023

StevenKKC commented on Oct 4, 2023

tjferriss commented on Oct 5, 2023

fedirjh commented on Oct 9, 2023

BugZero Checklist:

tjferriss commented on Oct 11, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions