Skip to content

[$500] IOU Distance - Save button in waypoint editor is not responsive #26286

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #25984

Action Performed:

  1. Go to staging.new.expensify,com
  2. Go to + > Request money > Distance
  3. Go to Start and select an address
  4. Go to Start again and clear the address field
  5. Click Save

Expected Result:

User is redirected to Distance page

Actual Result:

User is not redirected to Distance page. Save button is not responsive

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.59-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6182644_20230830_202346.mp4

Expensify/Expensify Issue URL:

Issue reported by: @b4s36t4

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016b55cf7fbb4a3cad
  • Upwork Job ID: 1706726189574373376
  • Last Price Increase: 2023-09-26
  • Automatic offers:
    • b4s36t4 | Contributor | 26890787

Activity

  1. OSBotify commented on Aug 30, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. StevenKKC commented on Aug 30, 2023

    @StevenKKC
    Contributor

    Proposal

    Please state again the problem we are trying to solve in this issue.

    IOU Distance - Save button in waypoint editor is not responsive.

    What is the cause of this issue?

    If we clear the address field and save, Transaction.removeWaypoint is called.

    // Allows letting you set a waypoint to an empty value
    if (waypointValue === '') {
    Transaction.removeWaypoint(transactionID, waypointIndex);
    }

    In Transaction.removeWaypoint, we call saveWaypoint with null of waypoint.
    saveWaypoint(transactionID, index, null);

    Therefore, the following code throws an error, and then app will be unresponsive.
    const recentWaypointAlreadyExists = _.find(recentWaypoints, (recentWaypoint) => recentWaypoint.address === waypoint.address);

    What changes do you think we should make to solve the problem?

    We can return if waypoint is null in Transaction.saveWaypoint.

    +   if (!waypoint) {
    +       return;
    +   }
        const recentWaypointAlreadyExists = _.find(recentWaypoints, (recentWaypoint) => recentWaypoint.address === waypoint.address);

    What alternative solutions have you investigated? (Optional)

    None.

  4. b4s36t4 commented on Aug 30, 2023

    @b4s36t4
    Contributor
  5. neil-marcellini commented on Aug 30, 2023

    @neil-marcellini
    Contributor

    I'm taking this over since it's a distance bug. Actually maybe the person who introduced this should take it if they are online.

  6. neil-marcellini commented on Aug 30, 2023

    @neil-marcellini
    Contributor

    I commented on the PR that caused this regression. We're discussing internally about having a contributor fix this in a PR that's in progress.

  7. hayata-suenaga commented on Aug 30, 2023

    @hayata-suenaga
    Contributor

    The cause was identified and being fixed in the PR Neil mentioned above

  8. 27 remaining items

  9. deleted a comment from melvin-bot on Sep 26, 2023
  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 26, 2023
  11. melvin-bot commented on Sep 26, 2023

    @melvin-bot

    📣 @b4s36t4 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  12. johncschuster commented on Sep 26, 2023

    @johncschuster
    Contributor

    @b4s36t4 can you please apply for the Reporter Role on Upwork? I'll take care of the reporting bonus after you've done that.

  13. b4s36t4 commented on Sep 26, 2023

    @b4s36t4
    Contributor

    @johncschuster above offer is for Contributor role mistakenly I have accepted it.

  14. b4s36t4 commented on Sep 26, 2023

    @b4s36t4
    Contributor

    What do I do?

  15. johncschuster commented on Sep 28, 2023

    @johncschuster
    Contributor

    @b4s36t4 No worries. I'll edit it on my end.

  16. johncschuster commented on Sep 28, 2023

    @johncschuster
    Contributor

    @b4s36t4 I've manually invited you to a different contract with the Bug Reporter rate. Can you accept that please?

  17. b4s36t4 commented on Oct 4, 2023

    @b4s36t4
    Contributor

    @johncschuster Accepted new offer. Thanks :)

  18. johncschuster commented on Oct 4, 2023

    @johncschuster
    Contributor

    Payment has been issued! Thanks, @b4s36t4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions