You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] IOU Distance - Save button in waypoint editor is not responsive #26286
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
📣 @b4s36t4 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Activity
OSBotify commentedon Aug 30, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 30, 2023
Triggered auto assignment to @Li357 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.StevenKKC commentedon Aug 30, 2023
Proposal
Please state again the problem we are trying to solve in this issue.
IOU Distance - Save button in waypoint editor is not responsive.
What is the cause of this issue?
If we clear the address field and save,
Transaction.removeWaypointis called.App/src/pages/iou/WaypointEditor.js
Lines 120 to 123 in 01d0d3b
In
Transaction.removeWaypoint, we callsaveWaypointwithnullofwaypoint.App/src/libs/actions/Transaction.js
Line 113 in 01d0d3b
Therefore, the following code throws an error, and then app will be unresponsive.
App/src/libs/actions/Transaction.js
Line 96 in 01d0d3b
What changes do you think we should make to solve the problem?
We can return if
waypointisnullinTransaction.saveWaypoint.What alternative solutions have you investigated? (Optional)
None.
b4s36t4 commentedon Aug 30, 2023
I have reported this bug earlier.
https://expensify.slack.com/archives/C049HHMV9SM/p1693286256793039
cc: @hayata-suenaga
neil-marcellini commentedon Aug 30, 2023
I'm taking this over since it's a distance bug. Actually maybe the person who introduced this should take it if they are online.
neil-marcellini commentedon Aug 30, 2023
I commented on the PR that caused this regression. We're discussing internally about having a contributor fix this in a PR that's in progress.
hayata-suenaga commentedon Aug 30, 2023
The cause was identified and being fixed in the PR Neil mentioned above
27 remaining items
melvin-bot commentedon Sep 26, 2023
📣 @b4s36t4 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
johncschuster commentedon Sep 26, 2023
@b4s36t4 can you please apply for the Reporter Role on Upwork? I'll take care of the reporting bonus after you've done that.
b4s36t4 commentedon Sep 26, 2023
@johncschuster above offer is for Contributor role mistakenly I have accepted it.
b4s36t4 commentedon Sep 26, 2023
What do I do?
johncschuster commentedon Sep 28, 2023
@b4s36t4 No worries. I'll edit it on my end.
johncschuster commentedon Sep 28, 2023
@b4s36t4 I've manually invited you to a different contract with the Bug Reporter rate. Can you accept that please?
b4s36t4 commentedon Oct 4, 2023
@johncschuster Accepted new offer. Thanks :)
johncschuster commentedon Oct 4, 2023
Payment has been issued! Thanks, @b4s36t4!