Skip to content

[HOLD for payment 2023-10-02] [$500] Request money - Currency search does not work with head or trail space #26375

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on FAB icon and select request money
  2. Click on currency
  3. Type any currency with head or trail space

Expected Result:

Should show currency suggestion if there is head or trail space

Actual Result:

Currency suggestion does not work with head or trail space

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.60-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1396.mp4
Screen.Recording.2023-08-21.At.10.20.14.Am.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692593642283219

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b5fade09bc8f8027
  • Upwork Job ID: 1702399813556031488
  • Last Price Increase: 2023-09-14
  • Automatic offers:
    • gadhiyamanan | Contributor | 26720044
    • gadhiyamanan | Reporter | 26720045

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 31, 2023
  2. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. gadhiyamanan commented on Aug 31, 2023

    @gadhiyamanan
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    currency search does not work with head or trail space

    What is the root cause of that problem?

    we are not trimming currency value while searching

    What changes do you think we should make in order to solve the problem?

    trim the search value here

    const searchRegex = new RegExp(Str.escapeForRegExp(searchValue), 'i');

    What alternative solutions did you explore? (Optional)

    NA

  5. CortneyOfstad commented on Sep 1, 2023

    @CortneyOfstad
    Contributor

    I'm not sure if this a bug or by design. My thoughts are if there is not supposed to be a space before the currency code, if you enter a space and begin typing, the correct result would be to not show the subsequent list underneath. However, interested to see others' thoughts on this. Going to get additional eyes.

  6. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. CortneyOfstad commented on Sep 1, 2023

    @CortneyOfstad
    Contributor

    @chiragsalian Interested to hear your thoughts on this — TIA!

  8. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    @CortneyOfstad, @chiragsalian Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. CortneyOfstad commented on Sep 5, 2023

    @CortneyOfstad
    Contributor

    Chirag was OoO for Labor Day, so not overdue 👍

  10. 40 remaining items

  11. mananjadhav commented on Oct 2, 2023

    @mananjadhav
    Collaborator

    I tried tracing the offending PR, I can see it existed since a long time (I think since the component creation). It went through a couple of refactors, I can't see if the trim got removed anywhere.

    I also don't think we need a regression test here, considering how seldom this piece of code changed. @chiragsalian wdyt?

    @CortneyOfstad Can you please post the payout summary, this is also eligible for the timeline bonus. I'll be raising my request on New Dot.

  12. chiragsalian commented on Oct 2, 2023

    @chiragsalian
    Contributor

    yeah imo regression testing for this is not needed.

  13. CortneyOfstad commented on Oct 3, 2023

    @CortneyOfstad
    Contributor

    Sorry was OoO yesterday, but payment breakdown is below!

    • External issue reporter — @gadhiyamanan paid $50 and contract ended in Upwork
    • Contributor that fixed the issue — @gadhiyamanan paid $500 + 50% bonus = $750 and contract ended in Upwork
    • Contributor+ that helped on the issue and/or PR — @mananjadhav is paid in NewDot and is eligible for $750
  14. gadhiyamanan commented on Oct 3, 2023

    @gadhiyamanan
    Contributor

    @CortneyOfstad this is eligible for $250 because it was reported before 30 aug (before the announcement) in slack
    Screenshot_20231003_200231_Slack.jpg

  15. CortneyOfstad commented on Oct 5, 2023

    @CortneyOfstad
    Contributor

    Sorry @gadhiyamanan — just sent out a proposal for the additional $200. Please let me know as soon as you accept. Thank you!

  16. gadhiyamanan commented on Oct 5, 2023

    @gadhiyamanan
    Contributor

    @CortneyOfstad offer accepted, thanks

  17. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $750 approved for payment based on BZ summary.

  18. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    @puneetlath, @mananjadhav, @CortneyOfstad, @chiragsalian, @gadhiyamanan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  19. CortneyOfstad commented on Oct 9, 2023

    @CortneyOfstad
    Contributor

    Payments have been completed, so closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions