You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-02] [$500] Request money - Currency search does not work with head or trail space #26375
I'm not sure if this a bug or by design. My thoughts are if there is not supposed to be a space before the currency code, if you enter a space and begin typing, the correct result would be to not show the subsequent list underneath. However, interested to see others' thoughts on this. Going to get additional eyes.
I tried tracing the offending PR, I can see it existed since a long time (I think since the component creation). It went through a couple of refactors, I can't see if the trim got removed anywhere.
I also don't think we need a regression test here, considering how seldom this piece of code changed. @chiragsalian wdyt?
@CortneyOfstad Can you please post the payout summary, this is also eligible for the timeline bonus. I'll be raising my request on New Dot.
Activity
melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)gadhiyamanan commentedon Aug 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
currency search does not work with head or trail space
What is the root cause of that problem?
we are not trimming currency value while searching
What changes do you think we should make in order to solve the problem?
trim the search value here
App/src/pages/iou/IOUCurrencySelection.js
Line 106 in 4237dd3
What alternative solutions did you explore? (Optional)
NA
CortneyOfstad commentedon Sep 1, 2023
I'm not sure if this a bug or by design. My thoughts are if there is not supposed to be a space before the currency code, if you enter a space and begin typing, the correct result would be to not show the subsequent list underneath. However, interested to see others' thoughts on this. Going to get additional eyes.
melvin-bot commentedon Sep 1, 2023
Triggered auto assignment to @chiragsalian (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.CortneyOfstad commentedon Sep 1, 2023
@chiragsalian Interested to hear your thoughts on this — TIA!
melvin-bot commentedon Sep 5, 2023
@CortneyOfstad, @chiragsalian Whoops! This issue is 2 days overdue. Let's get this updated quick!
CortneyOfstad commentedon Sep 5, 2023
Chirag was OoO for Labor Day, so not overdue 👍
40 remaining items
mananjadhav commentedon Oct 2, 2023
I tried tracing the offending PR, I can see it existed since a long time (I think since the component creation). It went through a couple of refactors, I can't see if the trim got removed anywhere.
I also don't think we need a regression test here, considering how seldom this piece of code changed. @chiragsalian wdyt?
@CortneyOfstad Can you please post the payout summary, this is also eligible for the timeline bonus. I'll be raising my request on New Dot.
chiragsalian commentedon Oct 2, 2023
yeah imo regression testing for this is not needed.
CortneyOfstad commentedon Oct 3, 2023
Sorry was OoO yesterday, but payment breakdown is below!
gadhiyamanan commentedon Oct 3, 2023
@CortneyOfstad this is eligible for $250 because it was reported before 30 aug (before the announcement) in slack

CortneyOfstad commentedon Oct 5, 2023
Sorry @gadhiyamanan — just sent out a proposal for the additional $200. Please let me know as soon as you accept. Thank you!
gadhiyamanan commentedon Oct 5, 2023
@CortneyOfstad offer accepted, thanks
JmillsExpensify commentedon Oct 5, 2023
$750 approved for payment based on BZ summary.
melvin-bot commentedon Oct 9, 2023
@puneetlath, @mananjadhav, @CortneyOfstad, @chiragsalian, @gadhiyamanan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
CortneyOfstad commentedon Oct 9, 2023
Payments have been completed, so closing!