You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-02] [$500] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page #26376
We're calling the OpenPublicProfilePage command API without any condition.
But we have multiple conditionals based on the loading start for the component.
This is how the current flow is
Click on Account -> Navigate to ProfilePage -> load variables related to component & Call the API -> props.personalDetails updated -> Again load the variable.
This transition causing the modal to re-render two quickly causing the interruption with the transition.
We already have the loading indicator but it isn't working because of few cases which we're not considering when we're doing the api call.
changed the title [-] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page[/-][+][$500] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page[/+]on Sep 8, 2023
The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused it (not that I could pinpoint at least), that's the original implementation from Add new Profile page #20144
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a simple visual bug, don't think an additional discussion is needed
Determine if we should create a regression test for this bug.
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? Yes
Is it an impactful bug? No
The bug has near zero impact, just an animation that isn't smooth, I think a regression test isn't needed here
Weird, the dates are totally off in that post v. the PR, which shows it was opened on Sept 20 and merged on Sept 21
@kevinksullivan, it's calculated from the moment a contributor is assigned to the job to the moment PR is merged. The dates are correct, but the calculation of days elapsed isn't
offer sent, lmk when you accept! I will plan to pay bonus as well
Activity
melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)b4s36t4 commentedon Aug 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page.
What is the root cause of that problem?
The RCA for this issue lies here in this snippet
App/src/pages/ProfilePage.js
Lines 102 to 106 in 96a0db1
We're calling the
OpenPublicProfilePagecommand API without any condition.But we have multiple conditionals based on the
loadingstart for the component.This is how the current flow is
Click on Account -> Navigate to
ProfilePage-> load variables related to component & Call the API ->props.personalDetailsupdated -> Again load the variable.This transition causing the modal to re-render two quickly causing the interruption with the transition.
We already have the loading indicator but it isn't working because of few cases which we're not considering when we're doing the api call.
App/src/pages/ProfilePage.js
Line 240 in 96a0db1
Here we're only showing loading state when there is no minimum details and loading state is true.
Although we have the loading state as true but we have minimum details for the particular user which is the reason we're not showing the loading.
What changes do you think we should make in order to solve the problem?
We should move the
useEffectto below lines and add the dependency ofhasMinimumDetailsand only call the API if we don't have minimum details.Doing this so ensures we're not causing the re-render unnecessarily and so the animation works perfectly.
What alternative solutions did you explore? (Optional)
NA
Result
Kapture.2023-08-31.at.17.15.39.mp4
PS: This is the smoothest transition I've encountered and fixed(on demo though) :xD
melvin-bot commentedon Sep 5, 2023
@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?
[-] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page[/-][+][$500] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page[/+]melvin-bot commentedon Sep 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0179ce98efccffa8c3
melvin-bot commentedon Sep 8, 2023
Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 8, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)36 remaining items
eVoloshchak commentedon Oct 2, 2023
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? Yes
Is it an impactful bug? No
The bug has near zero impact, just an animation that isn't smooth, I think a regression test isn't needed here
eVoloshchak commentedon Oct 2, 2023
I don't think that's correct, it was merged on a weekend, so it's definitely less than 3 business days
kevinksullivan commentedon Oct 3, 2023
Weird, the dates are totally off in that post v. the PR, which shows it was opened on Sept 20 and merged on Sept 21. Paying out bonus for this.
kevinksullivan commentedon Oct 3, 2023
@eVoloshchak offer sent, lmk when you accept! I will plan to pay bonus as well
kevinksullivan commentedon Oct 3, 2023
Paid @b4s36t4 and @MahmudjonToraqulov
eVoloshchak commentedon Oct 4, 2023
@kevinksullivan, it's calculated from the moment a contributor is assigned to the job to the moment PR is merged. The dates are correct, but the calculation of days elapsed isn't
Requested the payment via NewDot, thanks!
JmillsExpensify commentedon Oct 5, 2023
Can I get a payment summary on this issue?
kevinksullivan commentedon Oct 5, 2023
Payment summary:
JmillsExpensify commentedon Oct 5, 2023
$750 payment approved for @eVoloshchak based on BZ summary.
melvin-bot commentedon Oct 9, 2023
@eVoloshchak, @kevinksullivan, @neil-marcellini, @b4s36t4 Whoops! This issue is 2 days overdue. Let's get this updated quick!