Skip to content

[HOLD for payment 2023-10-02] [$500] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page #26376

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open website
  2. Click on plus icon > Split bill >Enter sum > Choose user(s) and click on Next btn > Click on Paid by and Split with's user's username

Expected Result:

There should be smooth animation for Paid by and Split with users on Split bill page

Actual Result:

There is no smooth animation for Paid by and Split with users on Split bill page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.60-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen-Capture.66.mp4
Recording.1397.mp4

Expensify/Expensify Issue URL:

Issue reported by: @MahmudjonToraqulov

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692713551555059

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0179ce98efccffa8c3
  • Upwork Job ID: 1700175437224157184
  • Last Price Increase: 2023-09-15
  • Automatic offers:
    • b4s36t4 | Contributor | 26739682
    • mahmudjontoraqulov | Reporter | 26739683

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 31, 2023
  2. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. b4s36t4 commented on Aug 31, 2023

    @b4s36t4
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page.

    What is the root cause of that problem?

    The RCA for this issue lies here in this snippet

    useEffect(() => {
    if (ValidationUtils.isValidAccountRoute(accountID)) {
    PersonalDetails.openPublicProfilePage(accountID);
    }
    }, [accountID]);
    .

    We're calling the OpenPublicProfilePage command API without any condition.

    But we have multiple conditionals based on the loading start for the component.
    This is how the current flow is

    Click on Account -> Navigate to ProfilePage -> load variables related to component & Call the API -> props.personalDetails updated -> Again load the variable.

    This transition causing the modal to re-render two quickly causing the interruption with the transition.

    We already have the loading indicator but it isn't working because of few cases which we're not considering when we're doing the api call.

    {!hasMinimumDetails && isLoading && <FullScreenLoadingIndicator style={styles.flex1} />}

    Here we're only showing loading state when there is no minimum details and loading state is true.

    Although we have the loading state as true but we have minimum details for the particular user which is the reason we're not showing the loading.

    What changes do you think we should make in order to solve the problem?

    We should move the useEffect to below lines and add the dependency of hasMinimumDetails and only call the API if we don't have minimum details.

    useEffect(() => {
        if (ValidationUtils.isValidAccountRoute(accountID) && !hasMinimumDetails) {
            PersonalDetails.openPublicProfilePage(accountID);
        }
    }, [accountID, hasMinimumDetails]);

    Doing this so ensures we're not causing the re-render unnecessarily and so the animation works perfectly.

    What alternative solutions did you explore? (Optional)

    NA

    Result

    Kapture.2023-08-31.at.17.15.39.mp4

    PS: This is the smoothest transition I've encountered and fixed(on demo though) :xD

  5. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 8, 2023
  7. changed the title [-] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page[/-] [+][$500] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page[/+] on Sep 8, 2023
  8. melvin-bot commented on Sep 8, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 8, 2023
  10. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

  11. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  12. 36 remaining items

  13. eVoloshchak commented on Oct 2, 2023

    @eVoloshchak
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused it (not that I could pinpoint at least), that's the original implementation from Add new Profile page #20144
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a simple visual bug, don't think an additional discussion is needed
    • Determine if we should create a regression test for this bug.
      Is it easy to test for this bug? Yes
      Is the bug related to an important user flow? Yes
      Is it an impactful bug? No
      The bug has near zero impact, just an animation that isn't smooth, I think a regression test isn't needed here
  14. eVoloshchak commented on Oct 2, 2023

    @eVoloshchak
    Contributor

    Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

    I don't think that's correct, it was merged on a weekend, so it's definitely less than 3 business days

  15. kevinksullivan commented on Oct 3, 2023

    @kevinksullivan
    Contributor

    Weird, the dates are totally off in that post v. the PR, which shows it was opened on Sept 20 and merged on Sept 21. Paying out bonus for this.

  16. kevinksullivan commented on Oct 3, 2023

    @kevinksullivan
    Contributor

    @eVoloshchak offer sent, lmk when you accept! I will plan to pay bonus as well

  17. kevinksullivan commented on Oct 3, 2023

    @kevinksullivan
    Contributor
  18. eVoloshchak commented on Oct 4, 2023

    @eVoloshchak
    Contributor

    Weird, the dates are totally off in that post v. the PR, which shows it was opened on Sept 20 and merged on Sept 21

    @kevinksullivan, it's calculated from the moment a contributor is assigned to the job to the moment PR is merged. The dates are correct, but the calculation of days elapsed isn't

    offer sent, lmk when you accept! I will plan to pay bonus as well

    Requested the payment via NewDot, thanks!

  19. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    Can I get a payment summary on this issue?

  20. kevinksullivan commented on Oct 5, 2023

    @kevinksullivan
    Contributor

    Payment summary:

  21. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @eVoloshchak based on BZ summary.

  22. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    @eVoloshchak, @kevinksullivan, @neil-marcellini, @b4s36t4 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions