You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-21] Overlay when RHP is opening is not over the entire page #26390
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
I will finish this for Rushat so we can close this. Its coming from this PR #22437, it was a new feature from perspective of navigation, the author fixed the regression so no need to comment on the PR.
I dont think we need regression test for this.
@rushatgabhane can you please request $500 for internal review in NewDot, you can use this issue to track the payment. Closing
Activity
melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 31, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c8489b64c7a71468
melvin-bot commentedon Aug 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Aug 31, 2023
Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.
melvin-bot commentedon Aug 31, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
laurenreidexpensify commentedon Sep 7, 2023
@mountiny can you pop an update here on this one, assume we're focused on this in #26385?
mountiny commentedon Sep 7, 2023
@laurenreidexpensify correct, pr is ready to be merged, just waiting for the merge freeze to be over
laurenreidexpensify commentedon Sep 12, 2023
Merge freeze is over now right?
13 remaining items
laurenreidexpensify commentedon Sep 24, 2023
@mountiny am assuming payment for this is $500 for C+ review, no reporting or C work?
mountiny commentedon Sep 25, 2023
@laurenreidexpensify I think that is right, $500 to @rushatgabhane for review and testing
rushatgabhane commentedon Sep 25, 2023
WIP⚠️
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
rushatgabhane commentedon Sep 25, 2023
Created a manual request - https://staging.new.expensify.com/r/4946760350922580
laurenreidexpensify commentedon Sep 28, 2023
@rushatgabhane have you had a moment to complete teh steps above? Thanks!
laurenreidexpensify commentedon Oct 3, 2023
@rushatgabhane bump ^^
melvin-bot commentedon Oct 6, 2023
@rushatgabhane, @mountiny, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mountiny commentedon Oct 6, 2023
I will finish this for Rushat so we can close this. Its coming from this PR #22437, it was a new feature from perspective of navigation, the author fixed the regression so no need to comment on the PR.
I dont think we need regression test for this.
@rushatgabhane can you please request $500 for internal review in NewDot, you can use this issue to track the payment. Closing
JmillsExpensify commentedon Oct 7, 2023
$500 payment approved for @rushatgabhane based on this comment.