Skip to content

[HOLD for payment 2023-09-21] Overlay when RHP is opening is not over the entire page #26390

Closed

Description

@mountiny

Problem

When the RHP i sanimating open now, the overlay is not covering the entire page so you can see it animate too

Solution

Make the overlay wider so users cannot see it to be animated.

overlayFade.mp4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c8489b64c7a71468
  • Upwork Job ID: 1697225734121099264
  • Last Price Increase: 2023-08-31

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 31, 2023
  2. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 31, 2023

    @melvin-bot
  4. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

  6. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  7. laurenreidexpensify commented on Sep 7, 2023

    @laurenreidexpensify
    Contributor

    @mountiny can you pop an update here on this one, assume we're focused on this in #26385?

  8. mountiny commented on Sep 7, 2023

    @mountiny
    ContributorAuthor

    @laurenreidexpensify correct, pr is ready to be merged, just waiting for the merge freeze to be over

  9. laurenreidexpensify commented on Sep 12, 2023

    @laurenreidexpensify
    Contributor

    Merge freeze is over now right?

  10. 13 remaining items

  11. laurenreidexpensify commented on Sep 24, 2023

    @laurenreidexpensify
    Contributor

    @mountiny am assuming payment for this is $500 for C+ review, no reporting or C work?

  12. mountiny commented on Sep 25, 2023

    @mountiny
    ContributorAuthor

    @laurenreidexpensify I think that is right, $500 to @rushatgabhane for review and testing

  13. rushatgabhane commented on Sep 25, 2023

    @rushatgabhane
    Member

    WIP ⚠️

    1. The PR that introduced the bug has been identified. Link to the PR:

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    4. Determine if we should create a regression test for this bug.

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

  14. rushatgabhane commented on Sep 25, 2023

    @rushatgabhane
    Member
  15. laurenreidexpensify commented on Sep 28, 2023

    @laurenreidexpensify
    Contributor

    @rushatgabhane have you had a moment to complete teh steps above? Thanks!

  16. laurenreidexpensify commented on Oct 3, 2023

    @laurenreidexpensify
    Contributor
  17. melvin-bot commented on Oct 6, 2023

    @melvin-bot

    @rushatgabhane, @mountiny, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  18. mountiny commented on Oct 6, 2023

    @mountiny
    ContributorAuthor

    I will finish this for Rushat so we can close this. Its coming from this PR #22437, it was a new feature from perspective of navigation, the author fixed the regression so no need to comment on the PR.

    I dont think we need regression test for this.

    @rushatgabhane can you please request $500 for internal review in NewDot, you can use this issue to track the payment. Closing

  19. JmillsExpensify commented on Oct 7, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @rushatgabhane based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions