Skip to content

[$1000] Request money - Tabs jump back and forth when swiping through tabs #26407

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #26022

Action Performed:

  1. Go to staging.new.expensify,com
  2. Go to + > Request money
  3. Swipe through the tabs in Request money page

Note: I believe the key to reproduce the issue is to swipe to another tab before the animation has finished.

Expected Result:

The tab does not jump back and forth

Actual Result:

The tab jumps from Scan > Distance > Scan > Manual when swiping from Scan to Manual

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.60-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6183894_Screen_Recording_20230831_175255_Chrome.mp4
Bug6183894_touch-enabled_web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015402cabc0571ff40
  • Upwork Job ID: 1697381434343821312
  • Last Price Increase: 2023-11-07

Activity

  1. OSBotify commented on Aug 31, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. Pluto0104 commented on Aug 31, 2023

    @Pluto0104
  4. b4s36t4 commented on Aug 31, 2023

    @b4s36t4
    Contributor

    @hannojg maybe you've worked on it? after the patch with material tab view?

  5. aldo-expensify commented on Aug 31, 2023

    @aldo-expensify
    Contributor

    @Pluto0104

    Thanks for the proposal: #26407 (comment)

    I'm trying it, but I still see the bug. I did this:

    image

    This makes me thing that there may be a bug in the external library, but I haven't been able to test that.

  6. aldo-expensify commented on Aug 31, 2023

    @aldo-expensify
    Contributor

    Lol, this is very broken in production, much worse than this:

    Screen.Recording.2023-08-31.at.2.10.07.PM.mov

    Considering that, I think we should remove the DeployBlocker label and investigate with lower priority

  7. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    Agree this is not a blocker since it happens in production too!

  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 31, 2023
  9. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. 75 remaining items

  11. s77rt commented on Nov 2, 2023

    @s77rt
    Member

    @aldo-expensify Should this be set back External?

  12. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 6, 2023
  13. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 6, 2023
  14. melvin-bot commented on Nov 6, 2023

    @melvin-bot

    Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

  15. removed
    InternalRequires API changes or must be handled by Expensify staff
    on Nov 6, 2023
  16. melvin-bot commented on Nov 7, 2023

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  17. aldo-expensify commented on Nov 8, 2023

    @aldo-expensify
    Contributor

    I found that this was reported on Oct 2021 in the external library repo: react-navigation/react-navigation#10072

    I don't think this will be fixed anytime soon in the library code. What would be the next step? Should we just close this issue? I think we should close it because I see it as a pretty minor thing (low ROI) and could be quite complex to fix.

  18. greg-schroeder commented on Nov 9, 2023

    @greg-schroeder
    Contributor

    All right - thanks Aldo. I'll close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions