Skip to content

[HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page #26413

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to https://staging.new.expensify.com/anything
  2. Click on the "Back to homepage link"

Expected Result:

You're redirected to NewDot home view

Actual Result:

Nothing happens when clicking on the link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.60-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6183997_Recording__255.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693486582141609

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cd141ca760b28102
  • Upwork Job ID: 1697348052242747392
  • Last Price Increase: 2023-08-31

Activity

  1. OSBotify commented on Aug 31, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. dhanashree-sawant commented on Aug 31, 2023

    @dhanashree-sawant

    Hello, I have raised a similar issue few hours back on slack :
    https://expensify.slack.com/archives/C049HHMV9SM/p1693486582141609
    In case my reporting time was before internal team, can we change the reported by to my name?

  4. ishpaul777 commented on Aug 31, 2023

    @ishpaul777
    Contributor

    Problem

    Chat - "Go back to Home page" unresponsive on invalid link page

    Root cause

    We are not passing a onLinkPress prop in FullPageNotFoundView in NotFoundPage.

    Changes

    pass a onLinkPress prop to FullPageNotFoundView in NotFoundPage.

    <ScreenWrapper>
               <FullPageNotFoundView shouldShow
                onLinkPress={() => {
                   Navigation.navigate(ROUTES.HOME);
               }}/>
    </ScreenWrapper>
  5. BhuvaneshPatil commented on Aug 31, 2023

    @BhuvaneshPatil
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Go back to Home page" unresponsive on invalid link page

    What is the root cause of that problem?

    default value for onLinkPress is - Navigation.dismissModal(), but in dismissModal, we are not checking for this case - SCREENS.NOT_FOUND which is set in AuthScreens component.
    And because of that we are getting error (falls into default) condition and not dismissing modal.
    Setting NOT_FOUND in AuthScreens -

    <RootStack.Screen
    name={SCREENS.NOT_FOUND}
    options={screenOptions.fullScreen}
    component={NotFoundPage}
    />

    What changes do you think we should make in order to solve the problem?

    We can add another condition in dismissModal() - switch block and handle it there.

    switch (lastRoute.name) {
    case NAVIGATORS.RIGHT_MODAL_NAVIGATOR:
    case NAVIGATORS.FULL_SCREEN_NAVIGATOR:
    case SCREENS.REPORT_ATTACHMENTS:
    // if we are not in the target report, we need to navigate to it after dismissing the modal
    if (targetReportID && targetReportID !== getTopmostReportId(rootState)) {
    const state = getStateFromPath(ROUTES.getReportRoute(targetReportID));
    const action = getActionFromState(state, linkingConfig.config);
    action.type = 'REPLACE';
    navigationRef.current.dispatch(action);
    } else {
    navigationRef.current.dispatch({...StackActions.pop(), target: rootState.key});
    }
    break;
    default: {
    Log.hmmm('[Navigation] dismissModal failed because there is no modal stack to dismiss');
    }

    case SCREENS.NOT_FOUND:
                navigationRef.current.navigate(ROUTES.HOME);
                break;

    What alternative solutions did you explore? (Optional)

  6. Pujan92 commented on Aug 31, 2023

    @Pujan92
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Go back to Home page not working

    What is the root cause of that problem?

    We are dismissing the modal for go back to home link but in case of it is not opened in modal it will gets failed.

    What changes do you think we should make in order to solve the problem?

    I think we need to update the default function in FullPageNotFoundView and BlockingView to use Navigation.navigate() or Navigation.goBack() to redirect with the fallback HOME route. Suggesting to use the same we updated for the back button press from dismissmodal to goback here

  7. c3024 commented on Aug 31, 2023

    @c3024
    Contributor

    All this code looks same in production. Why is it only reproducible in staging? Is it some react-navigation update that caused this?

  8. b4s36t4 commented on Aug 31, 2023

    @b4s36t4
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Chat - "Go back to Home page" unresponsive on invalid link page

    What is the root cause of that problem?

    This is a regression from #22437 in which we've removed FullScreenNavigator.

    Also we've moved the NotFoundPage to AuthScreens which is not wrapped anymore with FullScreenNavigator.

    What changes do you think we should make in order to solve the problem?

    case NAVIGATORS.RIGHT_MODAL_NAVIGATOR:
    case NAVIGATORS.FULL_SCREEN_NAVIGATOR:
    case SCREENS.REPORT_ATTACHMENTS:
    // if we are not in the target report, we need to navigate to it after dismissing the modal
    if (targetReportID && targetReportID !== getTopmostReportId(rootState)) {
    .

    Here we need to add the new case Screens.NOT_FOUND and remove Screen.FULL_SCREEN_NAVIGATOR.

    What alternative solutions did you explore? (Optional)

    NA

    cc: @mountiny

  9. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    This happens in production too. Demoting to NAB.

    Screen.Recording.2023-08-31.at.11.47.30.AM.mov
  10. 43 remaining items

  11. b4s36t4 commented on Sep 1, 2023

    @b4s36t4
    Contributor

    @luacmartins lame question, but do I get contributor bonus here? since the solution is from my proposal? 😅

  12. changed the title [-][HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page[/-] [+][HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page[/+] on Sep 1, 2023
  13. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-08. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
    • [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@eVoloshchak] Determine if we should create a regression test for this bug.
    • [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. puneetlath commented on Sep 5, 2023

    @puneetlath
    Contributor

    @eVoloshchak friendly reminder on the checklist here!

    @b4s36t4 yes definitely, we'll compensate you since we used your solution.

  16. eVoloshchak commented on Sep 10, 2023

    @eVoloshchak
    Contributor

    @eVoloshchak does not require payment (Eligible for Manual Requests)

    I didn't participate in this issue and didn't do the PR review, I'm not eligible for any payment

  17. puneetlath commented on Sep 10, 2023

    @puneetlath
    Contributor

    Ah ok, thanks for clarifying that @eVoloshchak.

    Looks like we just need to pay out @dhanashree-sawant for reporting and @b4s36t4 for providing the solution. Can you both apply to the Upwork job please: https://www.upwork.com/jobs/~01cd141ca760b28102

  18. b4s36t4 commented on Sep 10, 2023

    @b4s36t4
    Contributor

    @puneetlath Applied.

  19. puneetlath commented on Sep 10, 2023

    @puneetlath
    Contributor

    Thanks. Offers sent to you both.

  20. b4s36t4 commented on Sep 10, 2023

    @b4s36t4
    Contributor

    Done, accepted.

  21. dhanashree-sawant commented on Sep 11, 2023

    @dhanashree-sawant

    Thanks @puneetlath, I have accepted the offer.

  22. puneetlath commented on Sep 11, 2023

    @puneetlath
    Contributor

    All paid. Thanks y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions