You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page #26413
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
"Go back to Home page" unresponsive on invalid link page
What is the root cause of that problem?
default value for onLinkPress is - Navigation.dismissModal(), but in dismissModal, we are not checking for this case - SCREENS.NOT_FOUND which is set in AuthScreens component.
And because of that we are getting error (falls into default) condition and not dismissing modal.
Setting NOT_FOUND in AuthScreens -
Please re-state the problem that we are trying to solve in this issue.
Go back to Home page not working
What is the root cause of that problem?
We are dismissing the modal for go back to home link but in case of it is not opened in modal it will gets failed.
What changes do you think we should make in order to solve the problem?
I think we need to update the default function in FullPageNotFoundView and BlockingView to use Navigation.navigate() or Navigation.goBack() to redirect with the fallback HOME route. Suggesting to use the same we updated for the back button press from dismissmodal to goback here
changed the title [-][HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page[/-][+][HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page[/+]on Sep 1, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@eVoloshchakdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
OSBotify commentedon Aug 31, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @srikarparsi (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.dhanashree-sawant commentedon Aug 31, 2023
Hello, I have raised a similar issue few hours back on slack :
https://expensify.slack.com/archives/C049HHMV9SM/p1693486582141609
In case my reporting time was before internal team, can we change the reported by to my name?
ishpaul777 commentedon Aug 31, 2023
Problem
Chat - "Go back to Home page" unresponsive on invalid link page
Root cause
We are not passing a onLinkPress prop in FullPageNotFoundView in NotFoundPage.
Changes
pass a onLinkPress prop to FullPageNotFoundView in NotFoundPage.
BhuvaneshPatil commentedon Aug 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Go back to Home page" unresponsive on invalid link page
What is the root cause of that problem?
default value for
onLinkPressis -Navigation.dismissModal(), but in dismissModal, we are not checking for this case -SCREENS.NOT_FOUNDwhich is set inAuthScreenscomponent.And because of that we are getting error (falls into default) condition and not dismissing modal.
Setting NOT_FOUND in AuthScreens -
App/src/libs/Navigation/AppNavigator/AuthScreens.js
Lines 279 to 283 in 6c1f358
What changes do you think we should make in order to solve the problem?
We can add another condition in
dismissModal()- switch block and handle it there.App/src/libs/Navigation/Navigation.js
Lines 162 to 179 in 6c1f358
What alternative solutions did you explore? (Optional)
Pujan92 commentedon Aug 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Go back to Home page not working
What is the root cause of that problem?
We are dismissing the modal for go back to home link but in case of it is not opened in modal it will gets failed.
What changes do you think we should make in order to solve the problem?
I think we need to update the default function in
FullPageNotFoundViewandBlockingViewto useNavigation.navigate()orNavigation.goBack()to redirect with the fallback HOME route. Suggesting to use the same we updated for the back button press from dismissmodal to goback herec3024 commentedon Aug 31, 2023
All this code looks same in production. Why is it only reproducible in staging? Is it some react-navigation update that caused this?
b4s36t4 commentedon Aug 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - "Go back to Home page" unresponsive on invalid link page
What is the root cause of that problem?
This is a regression from #22437 in which we've removed
FullScreenNavigator.Also we've moved the
NotFoundPagetoAuthScreenswhich is not wrapped anymore withFullScreenNavigator.What changes do you think we should make in order to solve the problem?
App/src/libs/Navigation/Navigation.js
Lines 163 to 167 in 5f9bb2e
Here we need to add the new case
Screens.NOT_FOUNDand removeScreen.FULL_SCREEN_NAVIGATOR.What alternative solutions did you explore? (Optional)
NA
cc: @mountiny
luacmartins commentedon Aug 31, 2023
This happens in production too. Demoting to NAB.
Screen.Recording.2023-08-31.at.11.47.30.AM.mov
43 remaining items
b4s36t4 commentedon Sep 1, 2023
@luacmartins lame question, but do I get contributor bonus here? since the solution is from my proposal? 😅
[-][HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page[/-][+][HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page[/+]melvin-bot commentedon Sep 1, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 1, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
puneetlath commentedon Sep 5, 2023
@eVoloshchak friendly reminder on the checklist here!
@b4s36t4 yes definitely, we'll compensate you since we used your solution.
eVoloshchak commentedon Sep 10, 2023
I didn't participate in this issue and didn't do the PR review, I'm not eligible for any payment
puneetlath commentedon Sep 10, 2023
Ah ok, thanks for clarifying that @eVoloshchak.
Looks like we just need to pay out @dhanashree-sawant for reporting and @b4s36t4 for providing the solution. Can you both apply to the Upwork job please: https://www.upwork.com/jobs/~01cd141ca760b28102
b4s36t4 commentedon Sep 10, 2023
@puneetlath Applied.
puneetlath commentedon Sep 10, 2023
Thanks. Offers sent to you both.
b4s36t4 commentedon Sep 10, 2023
Done, accepted.
dhanashree-sawant commentedon Sep 11, 2023
Thanks @puneetlath, I have accepted the offer.
puneetlath commentedon Sep 11, 2023
All paid. Thanks y'all!