You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-18] [HOLD for payment 2023-09-18] [$500] iPad - Page layout is broken in the landscape position #26421
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
We actually don't support landscape mode either. Maybe for now we should just make sure to disable landscape mode on iPad (I think it's disabled on iOS already?)
Long-term I would rather support iPad and landscape but I agree it's not a priority yet
I just tested and it looks like portrait is messed up too, at least on a simulator. But if we're okay with just having this open in the background (I'd rather not fully close it) until we have bandwidth, that's fine by me
changed the title [-][HOLD for payment 2023-09-18] [$500] iPad - Page layout is broken in the landscape position[/-][+][HOLD for payment 2023-09-18] [HOLD for payment 2023-09-18] [$500] iPad - Page layout is broken in the landscape position[/+]on Sep 11, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.67-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-18. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@rushatgabhanedoes not require payment (Eligible for Manual Requests)
Activity
OSBotify commentedon Aug 31, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @dangrous (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.luacmartins commentedon Aug 31, 2023
This is not one of our officially supported platforms so I'll demote it to NAB
mountiny commentedon Aug 31, 2023
yeah this is from #22437 but this is not supported platform right now, curious that the rotation is not locked in
aimane-chnaif commentedon Sep 1, 2023
All iPad bugs were closed, even critical.
i.e. #16612
roryabraham commentedon Sep 1, 2023
We actually don't support landscape mode either. Maybe for now we should just make sure to disable landscape mode on iPad (I think it's disabled on iOS already?)
Long-term I would rather support iPad and landscape but I agree it's not a priority yet
dangrous commentedon Sep 1, 2023
I just tested and it looks like portrait is messed up too, at least on a simulator. But if we're okay with just having this open in the background (I'd rather not fully close it) until we have bandwidth, that's fine by me
mountiny commentedon Sep 1, 2023
@dangrous I think this is because the screen is so wide it thinks its wide screen and puts in that layout.
We should probably force the narrow layout in ipad and disable landscape, this can be external
49 remaining items
[-][HOLD for payment 2023-09-18] [$500] iPad - Page layout is broken in the landscape position[/-][+][HOLD for payment 2023-09-18] [HOLD for payment 2023-09-18] [$500] iPad - Page layout is broken in the landscape position[/+]melvin-bot commentedon Sep 11, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.67-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-18. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
abekkala commentedon Sep 14, 2023
PAYMENTS FOR SEPT 18
abekkala commentedon Sep 19, 2023
@shubham1206agra payment sent and contract ended. Thank you! 🎉

abekkala commentedon Sep 19, 2023
@rushatgabhane have you manually requested your payment in EChat yet?
abekkala commentedon Sep 25, 2023
@rushatgabhane can you confirm if you've requested payment yet?
rushatgabhane commentedon Sep 25, 2023
@abekkala requested payment https://staging.new.expensify.com/r/739012660970298
We can close this issue as it'll be tracked on newDot, thanks!
JmillsExpensify commentedon Oct 7, 2023
$750 payment approved for @rushatgabhane based on BZ summary.