[HOLD for payment 2024-04-09] [$500] [MEDIUM] IOU - Money request page displays skeleton in online #26424
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Launch app
- Tap profile icon
- Tap Preferences
- Toggle on force offline
- Navigate back to LHN
- Tap IOU report for request money received
- Note the IOU report page keeps loading
- Tap Pay elsewhere
- Navigate back to LHN and again visit IOU to note page keeps loading
- Navigate to LHN
- Tap profile
- Tap preferences
- Toggle off force offline
- Navigate back to LHN
- Tap IOU report
Expected Result:
Output of @mountiny & I discussing this one here for reference.
- We have the report total loaded in the iouReport data, so we should show the report total in the report where possible when offline.
-The iouActions we can't load would still show with a skeleton UI as we do today (we agreed just the one request preview component appearing as a skeleton is fine).
When a new request is added to the request when offline and appears at 50% opacity in the pending create state, so should the report total in the expanded header area.
Actual Result:
In online, in IOU report for request money, the page keeps on loading
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.60-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6184136_loading_redmi_secondaey_receivrr.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~012efb1896a46c34c4
- Upwork Job ID: 1707346943173816320
- Last Price Increase: 2024-02-13
- Automatic offers:
- abdulrahuman5196 | Reviewer | 0
- dukenv0307 | Contributor | 0
Activity
melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)trjExpensify commentedon Sep 1, 2023
When I come back online, they eventually load and the skeleton UI goes away, so that's contrary to the bug report. When we can't load the content, the skeleton UI is the correct pattern to use.
RPReplay_Final1693568080.MP4
I'm curious why the report total extended header in the iouReport isn't available to view offline in the first place though, and whether we can improve that in the spirit of offline-first?
CC: @mountiny @luacmartins @JmillsExpensify
luacmartins commentedon Sep 1, 2023
It seems like a regression. I agree they should be working offline.
mountiny commentedon Sep 1, 2023
Yep I think in offline it can work like that, online we probably still need to show the skeleton
trjExpensify commentedon Sep 4, 2023
Can you expand on that, @mountiny? Why do we need to show the skeleton for the report total when online?
mountiny commentedon Sep 4, 2023
No we dont have to, sorry we were probably talking about different things
trjExpensify commentedon Sep 4, 2023
Cool, so we agree with the below? Then next question, is this going to need backend changes?
Expected results
The report total in the expanded header area should be available to view when offline.
Actual Results
The report total doesn't load, and shows a skeleton UI in its place when offline.
mountiny commentedon Sep 4, 2023
What if you have exisitng IOU report and you sign out sign back in, you dont go to the IOU report so you dont have the report actions but you have the total.
You are offline, You request more, the total is updated and you see that offline made request but you dont see the previosu messages and there is no indication the report has more report actions while total is more. Is that fine as a feedback to the user while offline?
trjExpensify commentedon Sep 4, 2023
You might have to type that out again in steps for me to follow it completely sorry man. Let's park this and focus on the deploy for a sec.
252 remaining items
melvin-bot commentedon Apr 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 2, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mountiny commentedon Apr 2, 2024
$500 to @dukenv0307 and to @abdulrahuman5196
trjExpensify commentedon Apr 10, 2024
👋 checklist time please, @abdulrahuman5196!
In the meantime, payment summary will be as follows:
abdulrahuman5196 commentedon Apr 12, 2024
Not a regression.
Yes.
@trjExpensify Added checklist. And I am still getting paid via upwork. Kindly process on the same.
melvin-bot commentedon Apr 15, 2024
@trjExpensify, @mountiny, @abdulrahuman5196, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?
trjExpensify commentedon Apr 16, 2024
Paid you both! Closing!