[PAID] [$500] Web - Composer send button is enabled even when the input contains only space

@bernhardoj

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open any chat
Type multiple spaces and verify the send button is still disabled
Close the chat or navigate to another chat
Open back the chat

Expected Result:

The send button stays disabled because it contains only space

Actual Result:

The send button is enabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-26.at.16.06.42.mov

Recording.4142.mp4

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693037242762969

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0148ad3caa7badc613
Upwork Job ID: 1697749457182527488
Last Price Increase: 2023-09-01
Automatic offers:

fedirjh | Reviewer | 26518770
bernhardoj | Contributor | 26518772
bernhardoj | Reporter | 26518773

@strepanier03

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@bernhardoj

Proposal by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693037242762969

Proposal

Please re-state the problem that we are trying to solve in this issue.

The composer send button is enabled even when it contains only space.

What is the root cause of that problem?

We disable the send button if isCommentEmpty state is true. The initial value of isCommentEmpty comes from isCommentEmptyProp.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 131 in c169952

const [isCommentEmpty, setIsCommentEmpty] = useState(isCommentEmptyProp);

https://github.com/Expensify/App/blob/c16995257c738761206ea07645e863ee717ecbc0/src/pages/home/report/ReportActionCompose/ReportActionCompose.js#[…]8
Notice that we check using _.isEmpty which considers space only as not empty. This is different from what we do when typing something in the composer.
https://github.com/Expensify/App/blob/c16995257c738761206ea07645e863ee717ecbc0/src[…]ages/home/report/ReportActionCompose/ComposerWithSuggestions.js

What changes do you think we should make in order to solve the problem?

This issue happens after the ReportActionCompose refactor. Previously, when the composer mounted, we always called updateComment to make sure isCommentEmpty had a correct value, but this approach raised this issue.
Even though the issue is marked as not a bug, I still think it's a bug and we shouldn't use the old approach which is a workaround. To fully solve the issue, we should replace _.isEmpty with the regex we use when typing in the composer.

isCommentEmpty: {
    selector: (comment) => !comment || !!comment.match(/^(\s)*$/)
// comment could be undefined, so we also use !comment

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer send button is not disabled when typed text is only spaces

What is the root cause of that problem?

Send Button is only checking for disabled if field is empty or not.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Lines 452 to 455 in 64ff471

    
           isCommentEmpty: { 
        
               key: ({reportID}) => `${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`, 
        
               selector: (comment) => _.isEmpty(comment), 
        
           },

What changes do you think we should make in order to solve the problem?

We can trim the comment and then update isCommentEmpty. By this, it will remove the start and ending spaces of text, and then make the button enabled and disabled based on that.

isCommentEmpty: {
            key: ({reportID}) => `${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`,
            selector: (comment) => _.isEmpty(comment) || _.isEmpty(comment.trim()),
        },

What alternative solutions did you explore? (Optional)

N/A

@alifhaider

📣 @alifhaider! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email: alifhaider57@gmail.com
Upwork Profile Link: (https://www.upwork.com/freelancers/~014066482556c551be)

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Job added to Upwork: https://www.upwork.com/jobs/~0148ad3caa7badc613

@bernhardoj

@bernhardoj - You've been paid in Upwork. I left a note on the bonus payment but I thought we had two separate contracts for this job for you so I added the bonus to pay the reporting payment after the fact. Let me know if you have any questions.

@fedirjh - I'll keep my eyes open for an update on the checklist and move forward once there's one.

Thanks everyone!

@strepanier03

@strepanier03 got it. Thanks! I think you can close the Reporter contract then.

BugZero Checklist:

Link to the PR: Performance: chat input #25758
Link to comment: Performance: chat input #25758 (comment)
Link to discussion: N/A, I think a regression test could’ve helped catch this bug.
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Open any chat
Type space into the composer.
Verify the send button is disabled.
Switch to another chat
Open the chat back
Verify the send button is still disabled.

Do we agree 👍 or 👎

@strepanier03

@strepanier03 The offer was expired for me, could you please send me another offer 🙏🏼

@fedirjh

Sure thing @fedirjh, I'll do that now.

@fedirjh

@fedirjh - Sent!

Working on reg test GH now.

@bernhardoj

@bernhardoj - I'll work on closing that next week. For some reason both contracts linked here are for the same contract and paid already.

@strepanier03

@strepanier03 Accepted, Thank you.

@fedirjh

@fedirjh - I have finished paying you as well. Thanks for accepting that.

Thank you both for being part of our community and working so hard to help us achieve the New Expensify dream.

Navigation Menu

Repository navigation

[PAID] [$500] Web - Composer send button is enabled even when the input contains only space #26433

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

36 remaining items

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	isCommentEmpty: {
	key: ({reportID}) => `${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`,
	selector: (comment) => _.isEmpty(comment),
	},

[PAID] [$500] Web - Composer send button is enabled even when the input contains only space #26433

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 31, 2023

melvin-bot commented on Aug 31, 2023

Bug0 Triage Checklist (Main S/O)

kbecciv commented on Aug 31, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

alifhaider commented on Aug 31, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 31, 2023

alifhaider commented on Aug 31, 2023

melvin-bot commented on Aug 31, 2023

melvin-bot commented on Sep 1, 2023

36 remaining items

strepanier03 commented on Oct 6, 2023

bernhardoj commented on Oct 6, 2023

fedirjh commented on Oct 6, 2023

BugZero Checklist:

fedirjh commented on Oct 6, 2023

strepanier03 commented on Oct 6, 2023

strepanier03 commented on Oct 6, 2023

strepanier03 commented on Oct 6, 2023

fedirjh commented on Oct 9, 2023

strepanier03 commented on Oct 9, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions