Skip to content

Web - The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money. #26441

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the website
  2. Click the + icon from LHN
  3. Click request money
  4. Enter amount
  5. Select Workspace from the list if there is no workspace create one before requesting a money
  6. Confirm request money
  7. Open the IOU report
  8. Pay with "Pay Elsewhere"
  9. Open edit request
  10. Hover on the amount, description, merchant, and date
  11. Observe the result

Expected Result:

The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money.

Actual Result:

The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-09-01.12_22_45.AM.mp4
Recording.4145.mp4

Expensify/Expensify Issue URL:
Issue reported by: @misgana96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693516892936839

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 31, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. changed the title [-]Web - IOU report fields are not grey out after Pay with "Pay Elsewhere"[/-] [+]Web - The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money[/+] on Aug 31, 2023
  4. changed the title [-]Web - The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money[/-] [+]Web - The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money.[/+] on Aug 31, 2023
  5. Krishna2323 commented on Aug 31, 2023

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.
    Web - Workspace's badge is not appeared when hovering over it on thread

    What is the root cause of that problem?

    This is coming from this PR

    What changes do you think we should make in order to solve the problem?

    Option 1

    We need to add disabled={isSettled && !canEdit} to all MenuItemWithTopDescription element

    Option 2

    We can only show the disabled cursor without greying the text, like we do with complete tasks.
    shouldGreyOutWhenDisabled={false}

    Option 3

    If we don't want to grey out text and don't want to show the disabled cursor, we can pass focusable={canEdit}, so it doesn't add focus to task details if it has been paid.

    Focus

    Screen.Recording.2023-09-01.at.3.28.57.AM.mov
  6. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    I don't think this is a blocker. There's no functionality impacted here and it's a small cursor UI thing.

  7. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    IMO the way we have here is better, so I think we should do nothing, but I'll let @shawnborton chime in here.

  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 31, 2023
  9. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. 6 remaining items

  11. mallenexpensify commented on Sep 4, 2023

    @mallenexpensify
    Contributor

    Bumping this to Daily per Carlo's comment

    I don't think this is a blocker. There's no functionality impacted here and it's a small cursor UI thing.

    Also from Carlos

    IMO the way we have here is better, so I think we should do nothing, but I'll let @shawnborton chime in here.

    I'm not sure I 100% grasp the bug. I'm assuming it's that the cursor shows like this
    image

    when it should (maybe) show like this
    image

  12. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 5, 2023
  13. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  14. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  15. mallenexpensify commented on Sep 5, 2023

    @mallenexpensify
    Contributor

    @kevinksullivan I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx

  16. shawnborton commented on Sep 5, 2023

    @shawnborton
    Contributor

    I'm a little lost on this one but cc'ing @mountiny here - I think having these rows display as disabled was a mistake, and thus we want to revert them to appear like read-only push-to-page rows (with no caret) and thus we don't need a disabled cursor.

  17. mountiny commented on Sep 6, 2023

    @mountiny
    Contributor

    Yeah I dont understand this, we did have disabled and that was temporary and its fixed, now it looks normal, there is no hover effect, no change in cursor and no chevron so its clear you cannot clicked. This is intentional and not a bug

    Screen.Recording.2023-09-06.at.18.02.14.mov
  18. Krishna2323 commented on Sep 6, 2023

    @Krishna2323
    Contributor

    @mountiny, we also need set focusable={canEdit}, otherwise the task view details will be focusable even if they are not editable and we also need to change it on task view.

    Should I create a separate issue for this?

    Monosnap.screencast.2023-09-06.20-34-32.mp4
  19. mountiny commented on Sep 7, 2023

    @mountiny
    Contributor

    Should I create a separate issue for this?

    @Krishna2323 yeah this issue as far as I can see from the title is not about tasks, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions