You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web - The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money. #26441
Select Workspace from the list if there is no workspace create one before requesting a money
Confirm request money
Open the IOU report
Pay with "Pay Elsewhere"
Open edit request
Hover on the amount, description, merchant, and date
Observe the result
Expected Result:
The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money.
Actual Result:
The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.60.1 Reproducible in staging?: y Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Web - IOU report fields are not grey out after Pay with "Pay Elsewhere"[/-][+]Web - The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money[/+]on Aug 31, 2023
changed the title [-]Web - The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money[/-][+]Web - The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money.[/+]on Aug 31, 2023
What changes do you think we should make in order to solve the problem?
Option 1
We need to add disabled={isSettled && !canEdit} to all MenuItemWithTopDescription element
Option 2
We can only show the disabled cursor without greying the text, like we do with complete tasks. shouldGreyOutWhenDisabled={false}
Option 3
If we don't want to grey out text and don't want to show the disabled cursor, we can pass focusable={canEdit}, so it doesn't add focus to task details if it has been paid.
I'm a little lost on this one but cc'ing @mountiny here - I think having these rows display as disabled was a mistake, and thus we want to revert them to appear like read-only push-to-page rows (with no caret) and thus we don't need a disabled cursor.
Yeah I dont understand this, we did have disabled and that was temporary and its fixed, now it looks normal, there is no hover effect, no change in cursor and no chevron so its clear you cannot clicked. This is intentional and not a bug
@mountiny, we also need set focusable={canEdit}, otherwise the task view details will be focusable even if they are not editable and we also need to change it on task view.
Activity
OSBotify commentedon Aug 31, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.[-]Web - IOU report fields are not grey out after Pay with "Pay Elsewhere"[/-][+]Web - The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money[/+][-]Web - The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money[/-][+]Web - The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money.[/+]Krishna2323 commentedon Aug 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Workspace's badge is not appeared when hovering over it on thread
What is the root cause of that problem?
This is coming from this PR
What changes do you think we should make in order to solve the problem?
Option 1
We need to add
disabled={isSettled && !canEdit}to allMenuItemWithTopDescriptionelementOption 2
We can only show the disabled cursor without greying the text, like we do with complete tasks.
shouldGreyOutWhenDisabled={false}Option 3
If we don't want to grey out text and don't want to show the disabled cursor, we can pass
focusable={canEdit}, so it doesn't add focus to task details if it has been paid.Focus
Screen.Recording.2023-09-01.at.3.28.57.AM.mov
luacmartins commentedon Aug 31, 2023
I don't think this is a blocker. There's no functionality impacted here and it's a small cursor UI thing.
luacmartins commentedon Aug 31, 2023
IMO the way we have here is better, so I think we should do nothing, but I'll let @shawnborton chime in here.
melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.6 remaining items
mallenexpensify commentedon Sep 4, 2023
Bumping this to Daily per Carlo's comment
Also from Carlos
I'm not sure I 100% grasp the bug. I'm assuming it's that the cursor shows like this

when it should (maybe) show like this

melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)mallenexpensify commentedon Sep 5, 2023
@kevinksullivan I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx
shawnborton commentedon Sep 5, 2023
I'm a little lost on this one but cc'ing @mountiny here - I think having these rows display as disabled was a mistake, and thus we want to revert them to appear like read-only push-to-page rows (with no caret) and thus we don't need a disabled cursor.
mountiny commentedon Sep 6, 2023
Yeah I dont understand this, we did have disabled and that was temporary and its fixed, now it looks normal, there is no hover effect, no change in cursor and no chevron so its clear you cannot clicked. This is intentional and not a bug
Screen.Recording.2023-09-06.at.18.02.14.mov
Krishna2323 commentedon Sep 6, 2023
@mountiny, we also need set
focusable={canEdit}, otherwise the task view details will be focusable even if they are not editable and we also need to change it on task view.Should I create a separate issue for this?
Monosnap.screencast.2023-09-06.20-34-32.mp4
mountiny commentedon Sep 7, 2023
@Krishna2323 yeah this issue as far as I can see from the title is not about tasks, thanks!