You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-12] [HOLD for payment 2023-09-11] [$1000] [Distance] - App crashes when opening IOU thread and IOU shows a red dot #26585
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
App crashes when opening IOU thread and IOU shows a red dot
What is the root cause of that problem?
in the latest main red dot is already fixed.
URI is passing as number because because local import should be passed with without uri key.
why because it fetching local image means here file name is empty when the CreateDistanceRequest API called App/src/components/ReportActionItem/MoneyRequestPreview.js here expecting the filename
but in the API we have receiptFilename and filename is missing
What changes do you think we should make in order to solve the problem?
changed the title [-] Distance - App crashes when opening IOU thread and IOU shows a red dot[/-][+][$500] Distance - App crashes when opening IOU thread and IOU shows a red dot[/+]on Sep 3, 2023
@JmillsExpensify I also reviewed the PR. I had fully reviewed the PR by the time @situchan was assigned. I am sure @situchan didn't find any issues after my review. It is just that It was too late for me to do so I couldn't approve the PR and @hayata-suenaga asked someone to complete the checklist on Slack and thus @situchan reviewed it.
I was the primary C+ here. I should be equally eligible for C+ payment here.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: None, seems like backend caused this crash.
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Launch the New Expensify app
Go to any workspace chat
Go to FAB (➕) > Request money > Distance Tab.
Throttle the internet to 3G.
Create a distance request.
Immediately after the request is created (when it shows $0.00), click on the IOU to open the IOU thread and wait for a while.
@situchan offer sent via upwork. I didn't include the issue reporting, though feel free to update or I will pay that one when I pay/close the contract.
@hayata-suenaga Can you please comment on @parasharrajat's post above? I'm not sure why we'd pay $1,500 for both of C+, just like we didn't do that for Contributor either.
@situchan paid for reporting and C+. @Pujan92 paid for contributor work. @pradeepmdk paid for contributor work. @parasharrajat is paid via NewDot. Now that the regression test is created, I think we're all done here. Closing.
Activity
OSBotify commentedon Sep 2, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 2, 2023
Triggered auto assignment to @marcochavezf (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.pradeepmdk commentedon Sep 3, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when opening IOU thread and IOU shows a red dot
What is the root cause of that problem?
in the latest main red dot is already fixed.

URI is passing as number because because local import should be passed with without uri key.
why because it fetching local image means here file name is empty when the

CreateDistanceRequestAPI calledApp/src/components/ReportActionItem/MoneyRequestPreview.js here expecting the filename
but in the API we have
receiptFilenameandfilenameis missingWhat changes do you think we should make in order to solve the problem?
form BC add fileName in the api
or
App/src/components/ReportActionItem/MoneyRequestPreview.js
Line 226 in e088539
here we need add
props.transaction.filename || props.transaction.receiptFilenameAlternative Solution
here in ReportActionItemImage uri will doesn't support local assets file path.
so we need 'ReportActionItemImage' one more props if we are trying to load assets image means
and this function should return
getThumbnailAndImageURIs{thumbnail: null, image: null , assets: localImagepath};Or we can check the image as a string if string means we can assign with uri else without uri
I already added commented another PR #25841
please consider this as well
or else we can remove the local images from here
App/src/libs/ReceiptUtils.js
Line 40 in e088539
so that we can avoid the crash issue.
hayata-suenaga commentedon Sep 3, 2023
It's weekend and we need to fix this by Monday so I gonna make this external to get immediate proposals
[-] Distance - App crashes when opening IOU thread and IOU shows a red dot[/-][+][$500] Distance - App crashes when opening IOU thread and IOU shows a red dot[/+]melvin-bot commentedon Sep 3, 2023
Job added to Upwork: https://www.upwork.com/jobs/~014333c9073e9221c1
113 remaining items
situchan commentedon Sep 15, 2023
@JmillsExpensify yes, I am also eligible for reporting based on #26585 (comment)
parasharrajat commentedon Sep 15, 2023
@JmillsExpensify I also reviewed the PR. I had fully reviewed the PR by the time @situchan was assigned. I am sure @situchan didn't find any issues after my review. It is just that It was too late for me to do so I couldn't approve the PR and @hayata-suenaga asked someone to complete the checklist on Slack and thus @situchan reviewed it.
I was the primary C+ here. I should be equally eligible for C+ payment here.
parasharrajat commentedon Sep 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: None, seems like backend caused this crash.
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Do you agree 👍 or 👎 ?
JmillsExpensify commentedon Sep 18, 2023
Yes agreed.
JmillsExpensify commentedon Sep 18, 2023
@hayata-suenaga Can you please comment on @parasharrajat's post above? I'm not sure why we'd pay $1,500 for both of C+, just like we didn't do that for Contributor either.
parasharrajat commentedon Sep 18, 2023
I think it should be this way. This is what I have seen.
melvin-bot commentedon Sep 21, 2023
@JmillsExpensify, @Pujan92, @pradeepmdk, @parasharrajat, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!
hayata-suenaga commentedon Sep 25, 2023
waiting for payment
JmillsExpensify commentedon Sep 25, 2023
Updated payment summary:
Issue reporter: @situchan $50
Contributor: @Pujan92 $750 (incl. urgency bonus)
Contributor: @pradeepmdk $1,500 (incl. urgency bonus)
Contributor+: @situchan $1,000
Contributor+: @parasharrajat $1,500 (incl. urgency bonus; paid via NewDot)
JmillsExpensify commentedon Sep 25, 2023
@situchan paid for reporting and C+. @Pujan92 paid for contributor work. @pradeepmdk paid for contributor work. @parasharrajat is paid via NewDot. Now that the regression test is created, I think we're all done here. Closing.
parasharrajat commentedon Nov 28, 2023
Payment requested as per #26585 (comment)
JmillsExpensify commentedon Nov 29, 2023
$1,500 payment approved for @parasharrajat based on comment above.