Skip to content

[HOLD for payment 2023-09-12] [HOLD for payment 2023-09-11] [$1000] [Distance] - App crashes when opening IOU thread and IOU shows a red dot #26585

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #25707

Action Performed:

  1. Launch New Expensify app
  2. Go to workspace chat
  3. Go to + > Request money > Distance
  4. Create a distance request
  5. Right after the request is created (when it shows $0.00), click on the IOU to open IOU thread and wait for a while
  6. Relaunch New Expensify app
  7. Go to the created distance IOU

Expected Result:

In Step 5, app does not crash
In Step 7. the distance IOU does not have a red dot

Actual Result:

In Step 5, the app crashes
In Step 7. the distance IOU shows a red dot

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.62-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6186242_Screen_Recording_20230902_231428_New_Expensify.mp4

aaaaaaaa.txt

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team and also @situchan for a separate issue solved by the PR for this issue

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014333c9073e9221c1
  • Upwork Job ID: 1698167577340440576
  • Last Price Increase: 2023-09-03
  • Automatic offers:
    • pradeepmdk | Contributor | 26478625
    • Pujan92 | Contributor | 26480728

Activity

  1. OSBotify commented on Sep 2, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 2, 2023

    @melvin-bot

    Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. pradeepmdk commented on Sep 3, 2023

    @pradeepmdk
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    App crashes when opening IOU thread and IOU shows a red dot

    What is the root cause of that problem?

    in the latest main red dot is already fixed.
    URI is passing as number because because local import should be passed with without uri key.
    Screenshot 2023-09-03 at 5 14 12 AM

    why because it fetching local image means here file name is empty when the CreateDistanceRequest API called
    Screenshot 2023-09-03 at 6 21 03 AM
    App/src/components/ReportActionItem/MoneyRequestPreview.js here expecting the filename
    but in the API we have receiptFilename and filename is missing

    What changes do you think we should make in order to solve the problem?

    form BC add fileName in the api

    or

    images={[ReceiptUtils.getThumbnailAndImageURIs(props.transaction.receipt.source, props.transaction.filename)]}

    here we need add
    props.transaction.filename || props.transaction.receiptFilename

    Alternative Solution

    here in ReportActionItemImage uri will doesn't support local assets file path.

     return (
            <Image
                source={{uri: image}}
                style={[styles.w100, styles.h100]}
            />
        );
    

    so we need 'ReportActionItemImage' one more props if we are trying to load assets image means

     return (
            <Image
                source={assets ?  assets : {uri: image}}
                style={[styles.w100, styles.h100]}
            />
        );
    

    and this function should return getThumbnailAndImageURIs {thumbnail: null, image: null , assets: localImagepath};

    Or we can check the image as a string if string means we can assign with uri else without uri

    I already added commented another PR #25841

    please consider this as well

    or else we can remove the local images from here

    function getThumbnailAndImageURIs(path, filename) {

    so that we can avoid the crash issue.

  4. hayata-suenaga commented on Sep 3, 2023

    @hayata-suenaga
    Contributor

    It's weekend and we need to fix this by Monday so I gonna make this external to get immediate proposals

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Sep 3, 2023
  6. changed the title [-] Distance - App crashes when opening IOU thread and IOU shows a red dot[/-] [+][$500] Distance - App crashes when opening IOU thread and IOU shows a red dot[/+] on Sep 3, 2023
  7. melvin-bot commented on Sep 3, 2023

    @melvin-bot
  8. 113 remaining items

  9. situchan commented on Sep 15, 2023

    @situchan
    Contributor

    @JmillsExpensify yes, I am also eligible for reporting based on #26585 (comment)

  10. parasharrajat commented on Sep 15, 2023

    @parasharrajat
    Member

    @JmillsExpensify I also reviewed the PR. I had fully reviewed the PR by the time @situchan was assigned. I am sure @situchan didn't find any issues after my review. It is just that It was too late for me to do so I couldn't approve the PR and @hayata-suenaga asked someone to complete the checklist on Slack and thus @situchan reviewed it.

    I was the primary C+ here. I should be equally eligible for C+ payment here.

  11. parasharrajat commented on Sep 15, 2023

    @parasharrajat
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: None, seems like backend caused this crash.

    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA

    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA

    • [@parasharrajat] Determine if we should create a regression test for this bug. Yes

    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Steps

    1. Launch the New Expensify app
    2. Go to any workspace chat
    3. Go to FAB (➕) > Request money > Distance Tab.
    4. Throttle the internet to 3G.
    5. Create a distance request.
    6. Immediately after the request is created (when it shows $0.00), click on the IOU to open the IOU thread and wait for a while.
    7. The app should not crash.
    8. Relaunch/reload the app
    9. Go to the created distance IOU
    10. Verify there is no crash.

    Do you agree 👍 or 👎 ?

  12. JmillsExpensify commented on Sep 18, 2023

    @JmillsExpensify
    Contributor

    @situchan offer sent via upwork. I didn't include the issue reporting, though feel free to update or I will pay that one when I pay/close the contract.

    Yes agreed.

  13. JmillsExpensify commented on Sep 18, 2023

    @JmillsExpensify
    Contributor

    @hayata-suenaga Can you please comment on @parasharrajat's post above? I'm not sure why we'd pay $1,500 for both of C+, just like we didn't do that for Contributor either.

  14. parasharrajat commented on Sep 18, 2023

    @parasharrajat
    Member

    I think it should be this way. This is what I have seen.

    1. Primary C+ issue price + bonus if applicable.
    2. other c+ normal/standard payout.
  15. melvin-bot commented on Sep 21, 2023

    @melvin-bot

    @JmillsExpensify, @Pujan92, @pradeepmdk, @parasharrajat, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. hayata-suenaga commented on Sep 25, 2023

    @hayata-suenaga
    Contributor

    waiting for payment

  17. JmillsExpensify commented on Sep 25, 2023

    @JmillsExpensify
    Contributor

    Updated payment summary:

    Issue reporter: @situchan $50
    Contributor: @Pujan92 $750 (incl. urgency bonus)
    Contributor: @pradeepmdk $1,500 (incl. urgency bonus)
    Contributor+: @situchan $1,000
    Contributor+: @parasharrajat $1,500 (incl. urgency bonus; paid via NewDot)

  18. JmillsExpensify commented on Sep 25, 2023

    @JmillsExpensify
    Contributor

    @situchan paid for reporting and C+. @Pujan92 paid for contributor work. @pradeepmdk paid for contributor work. @parasharrajat is paid via NewDot. Now that the regression test is created, I think we're all done here. Closing.

  19. parasharrajat commented on Nov 28, 2023

    @parasharrajat
    Member

    Payment requested as per #26585 (comment)

  20. JmillsExpensify commented on Nov 29, 2023

    @JmillsExpensify
    Contributor

    $1,500 payment approved for @parasharrajat based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions