Skip to content

[NEED TO PAY STEVEN] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created #26722

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #26580

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open a workspace chat
  3. Send a Distance IOU to the workspace chat

Expected Result:

The requester avatar and name are shown as soon as the request is created

Actual Result:

The requester avatar and name are not shown for a while

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188417_20230905_021312.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0130c70f29cf0ac46d
  • Upwork Job ID: 1701423694582550528
  • Last Price Increase: 2023-09-12
  • Automatic offers:
    • situchan | Reviewer | 26698696
    • StevenKKC | Contributor | 26698698

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 4, 2023
  2. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. jliexpensify commented on Sep 5, 2023

    @jliexpensify
    Contributor

    @hayata-suenaga and @situchan , from the comment above:

    Issue found when executing PR #26580

  5. changed the title [-]Distance - The requester avatar and name are not shown for a while after request is created[/-] [+][REGRESSION?] Distance - The requester avatar and name are not shown for a while after request is created[/+] on Sep 5, 2023
  6. StevenKKC commented on Sep 5, 2023

    @StevenKKC
    Contributor

    Proposal

    Please state again the problem we are trying to solve in this issue.

    Distance - The requester avatar and name are not shown for a while after request is created.

    What is the cause of this issue?

    The root cause is that we does not pass correct payeeAccountID and payeeEmail to IOU.getMoneyRequestInformation.

    App/src/libs/actions/IOU.js

    Lines 512 to 524 in 6b1a667

    const {iouReport, chatReport, transaction, iouAction, createdChatReportActionID, createdIOUReportActionID, reportPreviewAction, onyxData} = getMoneyRequestInformation(
    report,
    participant,
    comment,
    amount,
    currency,
    created,
    merchant,
    null,
    null,
    null,
    transactionID,
    );

    Because we pass payeeAccountID and payeeEmail with null, iouReport's managerID is set to null, and then reportPreviewAction's actorAccountID is set to 0.
    managerID: payerAccountID,

    actorAccountID: hasReceipt ? currentUserAccountID : iouReport.managerID || 0,

    So the avatar and name are not shown until OpenReport returns correct report data.

    What changes do you think we should make to solve the problem?

    We should set correct payeeAccountID and payeeEmail in IOU.createDistanceRequest

    const { ... } = getMoneyRequestInformation(
            ...
            userAccountID,
            currentUserEmail,
            ...
        );

    What alternative solutions have you investigated? (Optional)

    None.

  7. changed the title [-][REGRESSION?] Distance - The requester avatar and name are not shown for a while after request is created[/-] [+][REGRESSION?] [Distance] - The requester avatar and name are not shown for a while after request is created[/+] on Sep 5, 2023
  8. hayata-suenaga commented on Sep 5, 2023

    @hayata-suenaga
    Contributor

    @StevenKKC where is getMoneyRequestInformation invoked?

  9. StevenKKC commented on Sep 5, 2023

    @StevenKKC
    Contributor

    @hayata-suenaga getMoneyRequestInformation is invoked in IOU.createDistanceRequest.

    App/src/libs/actions/IOU.js

    Lines 511 to 524 in cbda2b0

    function createDistanceRequest(report, participant, comment, created, transactionID, amount, currency, merchant) {
    const {iouReport, chatReport, transaction, iouAction, createdChatReportActionID, createdIOUReportActionID, reportPreviewAction, onyxData} = getMoneyRequestInformation(
    report,
    participant,
    comment,
    amount,
    currency,
    created,
    merchant,
    null,
    null,
    null,
    transactionID,
    );

  10. melvin-bot commented on Sep 11, 2023

    @melvin-bot

    @jliexpensify, @hayata-suenaga, @situchan Eep! 4 days overdue now. Issues have feelings too...

  11. 47 remaining items

  12. jliexpensify commented on Oct 2, 2023

    @jliexpensify
    Contributor

    Thanks for the bump Tim! Yep, was OOO and a whole bunch of issues hit the payment date. Sorting this out now.

  13. changed the title [-][HOLD for payment 2023-09-29] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/-] [+][SITU - WAITING ON CHECKLIST] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/+] on Oct 2, 2023
  14. jliexpensify commented on Oct 2, 2023

    @jliexpensify
    Contributor

    Paid and job closed. @situchan just waiting on you to complete the checklist, cheers!

  15. tgolen commented on Oct 5, 2023

    @tgolen
    Contributor

    bump @situchan to complete the checklist

  16. StevenKKC commented on Oct 5, 2023

    @StevenKKC
    Contributor

    @jliexpensify I am afraid to let you know that My Upwork account is suspended permanently so I couldn't withdraw money. I would be really appreciate it if you refund money and send to my friend's account.

  17. jliexpensify commented on Oct 6, 2023

    @jliexpensify
    Contributor

    @StevenKKC I'm sorry, but we cannot pay out your funds to another account, as this is a breach of Upworks T+C's and could cause Expensify to be suspended. Can you share some additional context/details on what's happening with your situation, and I'll bring this up with our team? Feel free to DM me if you like.

  18. jliexpensify commented on Oct 9, 2023

    @jliexpensify
    Contributor

    @StevenKKC our team has reached out to Upworks specifically regarding this issue and unfortunately, there is nothing that can be done from our side - we have to pay into your Upworks account. The advice we have been given is to ask you to continue working with Upworks to get your account restored. Thanks for your understanding!

    @situchan can you also complete the checklist please?

  19. StevenKKC commented on Oct 9, 2023

    @StevenKKC
    Contributor

    Yes, thank you for your consideration. I received the terrible news from Upwork support that my account has been permanently disabled. In this case what should I do?

  20. jliexpensify commented on Oct 9, 2023

    @jliexpensify
    Contributor

    @StevenKKC this is something you'll need to talk to Upworks about. As mentioned before, we're not able to pay via another means, sorry about that!

  21. situchan commented on Oct 9, 2023

    @situchan
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Modify MoneyRequestConfirmPage for Distance Request #25707
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25707/files#r1349870552
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug.
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    This was caught by Applause team so I don't think we need more regression test.

  22. jliexpensify commented on Oct 9, 2023

    @jliexpensify
    Contributor

    @StevenKKC an update from our team: I'm going to close this issue for now. Once you've resolved things with Upworks, please tag me and I will re-open and pay you.

  23. changed the title [-][SITU - WAITING ON CHECKLIST] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/-] [+][NEED TO PAY STEVEN] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/+] on Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions