You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[NEED TO PAY STEVEN] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created #26722
changed the title [-]Distance - The requester avatar and name are not shown for a while after request is created[/-][+][REGRESSION?] Distance - The requester avatar and name are not shown for a while after request is created[/+]on Sep 5, 2023
Because we pass payeeAccountID and payeeEmail with null, iouReport's managerID is set to null, and then reportPreviewAction's actorAccountID is set to 0.
changed the title [-][REGRESSION?] Distance - The requester avatar and name are not shown for a while after request is created[/-][+][REGRESSION?] [Distance] - The requester avatar and name are not shown for a while after request is created[/+]on Sep 5, 2023
changed the title [-][HOLD for payment 2023-09-29] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/-][+][SITU - WAITING ON CHECKLIST] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/+]on Oct 2, 2023
@jliexpensify I am afraid to let you know that My Upwork account is suspended permanently so I couldn't withdraw money. I would be really appreciate it if you refund money and send to my friend's account.
@StevenKKC I'm sorry, but we cannot pay out your funds to another account, as this is a breach of Upworks T+C's and could cause Expensify to be suspended. Can you share some additional context/details on what's happening with your situation, and I'll bring this up with our team? Feel free to DM me if you like.
@StevenKKC our team has reached out to Upworks specifically regarding this issue and unfortunately, there is nothing that can be done from our side - we have to pay into your Upworks account. The advice we have been given is to ask you to continue working with Upworks to get your account restored. Thanks for your understanding!
@situchan can you also complete the checklist please?
Yes, thank you for your consideration. I received the terrible news from Upwork support that my account has been permanently disabled. In this case what should I do?
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
This was caught by Applause team so I don't think we need more regression test.
@StevenKKC an update from our team: I'm going to close this issue for now. Once you've resolved things with Upworks, please tag me and I will re-open and pay you.
changed the title [-][SITU - WAITING ON CHECKLIST] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/-][+][NEED TO PAY STEVEN] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/+]on Oct 9, 2023
Activity
melvin-bot commentedon Sep 4, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 4, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)jliexpensify commentedon Sep 5, 2023
@hayata-suenaga and @situchan , from the comment above:
[-]Distance - The requester avatar and name are not shown for a while after request is created[/-][+][REGRESSION?] Distance - The requester avatar and name are not shown for a while after request is created[/+]StevenKKC commentedon Sep 5, 2023
Proposal
Please state again the problem we are trying to solve in this issue.
Distance - The requester avatar and name are not shown for a while after request is created.
What is the cause of this issue?
The root cause is that we does not pass correct
payeeAccountIDandpayeeEmailtoIOU.getMoneyRequestInformation.App/src/libs/actions/IOU.js
Lines 512 to 524 in 6b1a667
Because we pass
payeeAccountIDandpayeeEmailwithnull,iouReport'smanagerIDis set tonull, and thenreportPreviewAction'sactorAccountIDis set to0.App/src/libs/ReportUtils.js
Line 1935 in 6b1a667
App/src/libs/ReportUtils.js
Line 2207 in 6b1a667
So the avatar and name are not shown until
OpenReportreturns correct report data.What changes do you think we should make to solve the problem?
We should set correct
payeeAccountIDandpayeeEmailinIOU.createDistanceRequestWhat alternative solutions have you investigated? (Optional)
None.
[-][REGRESSION?] Distance - The requester avatar and name are not shown for a while after request is created[/-][+][REGRESSION?] [Distance] - The requester avatar and name are not shown for a while after request is created[/+]hayata-suenaga commentedon Sep 5, 2023
@StevenKKC where is
getMoneyRequestInformationinvoked?StevenKKC commentedon Sep 5, 2023
@hayata-suenaga
getMoneyRequestInformationis invoked inIOU.createDistanceRequest.App/src/libs/actions/IOU.js
Lines 511 to 524 in cbda2b0
melvin-bot commentedon Sep 11, 2023
@jliexpensify, @hayata-suenaga, @situchan Eep! 4 days overdue now. Issues have feelings too...
47 remaining items
jliexpensify commentedon Oct 2, 2023
Thanks for the bump Tim! Yep, was OOO and a whole bunch of issues hit the payment date. Sorting this out now.
[-][HOLD for payment 2023-09-29] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/-][+][SITU - WAITING ON CHECKLIST] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/+]jliexpensify commentedon Oct 2, 2023
Paid and job closed. @situchan just waiting on you to complete the checklist, cheers!
tgolen commentedon Oct 5, 2023
bump @situchan to complete the checklist
StevenKKC commentedon Oct 5, 2023
@jliexpensify I am afraid to let you know that My Upwork account is suspended permanently so I couldn't withdraw money. I would be really appreciate it if you refund money and send to my friend's account.
jliexpensify commentedon Oct 6, 2023
@StevenKKC I'm sorry, but we cannot pay out your funds to another account, as this is a breach of Upworks T+C's and could cause Expensify to be suspended. Can you share some additional context/details on what's happening with your situation, and I'll bring this up with our team? Feel free to DM me if you like.
jliexpensify commentedon Oct 9, 2023
@StevenKKC our team has reached out to Upworks specifically regarding this issue and unfortunately, there is nothing that can be done from our side - we have to pay into your Upworks account. The advice we have been given is to ask you to continue working with Upworks to get your account restored. Thanks for your understanding!
@situchan can you also complete the checklist please?
StevenKKC commentedon Oct 9, 2023
Yes, thank you for your consideration. I received the terrible news from Upwork support that my account has been permanently disabled. In this case what should I do?
jliexpensify commentedon Oct 9, 2023
@StevenKKC this is something you'll need to talk to Upworks about. As mentioned before, we're not able to pay via another means, sorry about that!
situchan commentedon Oct 9, 2023
MoneyRequestConfirmPagefor Distance Request #25707This was caught by Applause team so I don't think we need more regression test.
jliexpensify commentedon Oct 9, 2023
@StevenKKC an update from our team: I'm going to close this issue for now. Once you've resolved things with Upworks, please tag me and I will re-open and pay you.
[-][SITU - WAITING ON CHECKLIST] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/-][+][NEED TO PAY STEVEN] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created[/+]