You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-09] [$500] After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list) #26829
press cmd+j to open shortcut modal without page reload.
now you see list off all shortcuts in modal.
Expected Result:
only ESC and Shortcut(" CMD+J") keys should be shown
Actual Result:
All Shortcuts are shown here
Platforms: MacOS / Chrome / Safari
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.64-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
but When unsubscribing, we remove event listeners but not shortcuts from the variable documentedShortcuts. Even though I have unsubscribed, the shortcuts are still present in documentedShortcuts.
What changes do you think we should make in order to solve the problem?
When unsubscribed we can remove the values present in documentedShortcuts by displayname (key).
lodashUnset(documentedShortcuts,displayName);//ordocumentedShortcuts=_.omit(documentedShortcuts,displayName);//ordocumentedShortcuts[displayName]={}// here we can return null or {}//We can use the delete method also based on your request.
What alternative solutions did you explore? (Optional)
changed the title [-]All keyboard shortcut shows up in modal after Logout[/-][+]After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/+]on Sep 6, 2023
@Charan-hs@kavimuru I am confused at this issue. Here is what you've written:
Expected Result:
only ESC and Shortcut(" CMD+J") keys should be shown
Actual Result:
All Shortcuts are shown here
Should these 2 be reversed? i.e. when you're logged in, you see all the shortcuts, but when you're logged out, you only see 2 shortcuts. or are yousaying we should only ever see 2 shortcuts? (which doesn't sound right to me)
after signing out all shortcut list shows in modal, if page reloaded and then only ESC and Shortcut(" CMD+J") options be shown, here as far as i know showing only 2 options is intententional why would we show other options if shortcut does nothing when used?
Not reported here but i noticed, i believe can be handled with this issue.
2. when reloaded and first time open shortcut modal with CTRL + j only one option shown, closing and reopening modal shows 2 options.
when reloaded and first time open shortcut modal with CTRL + j only one option shown, closing and reopening modal shows 2 options.
I also noticed this in my testing!
After chatting to @kadiealexander I think I got confused initially, so ignore this comment! Going to mark this as external, and I think we should also fix the 2nd issue outlined above.
changed the title [-]After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/-][+][$500] After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/+]on Sep 7, 2023
changed the title [-][$500] After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/-][+][HOLD for payment 2023-10-09] [$500] After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/+]on Oct 2, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
[@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ntdiary] Determine if we should create a regression test for this bug.
[@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ntdiary] The PR that introduced the bug has been identified. Link to the PR: N/A
[@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
[@ntdiary] Determine if we should create a regression test for this bug. No need
[@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Not a regression, just a tiny feature polish, don't need a regression test. : )
Activity
melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kavimuru commentedon Sep 5, 2023
Proposal by @Charan-hs
Please re-state the problem that we are trying to solve in this issue.
All keyboard shortcut shows up in modal after Logout
What is the root cause of that problem?
When we are logged in or logged out we are unsubscribing the event handlers here.
App/src/libs/KeyboardShortcut/index.js
Lines 83 to 87 in fdcae9f
but When unsubscribing, we remove event listeners but not shortcuts from the variable
documentedShortcuts. Even though I have unsubscribed, the shortcuts are still present indocumentedShortcuts.What changes do you think we should make in order to solve the problem?
Here,
App/src/libs/KeyboardShortcut/index.js
Lines 83 to 87 in fdcae9f
When unsubscribed we can remove the values present in
documentedShortcutsbydisplayname(key).What alternative solutions did you explore? (Optional)
jliexpensify commentedon Sep 6, 2023
Able to repro!
[-]All keyboard shortcut shows up in modal after Logout[/-][+]After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/+]jliexpensify commentedon Sep 6, 2023
@Charan-hs @kavimuru I am confused at this issue. Here is what you've written:
Should these 2 be reversed? i.e. when you're logged in, you see all the shortcuts, but when you're logged out, you only see 2 shortcuts. or are yousaying we should only ever see 2 shortcuts? (which doesn't sound right to me)
ishpaul777 commentedon Sep 6, 2023
@jliexpensify, I think there are 2 bugs here -
Not reported here but i noticed, i believe can be handled with this issue.
2. when reloaded and first time open shortcut modal with CTRL + j only one option shown, closing and reopening modal shows 2 options.
Screen.Recording.2023-09-06.at.11.55.25.PM.mov
jliexpensify commentedon Sep 7, 2023
@ishpaul777 thanks for reporting this one:
I also noticed this in my testing!
After chatting to @kadiealexander I think I got confused initially, so ignore this comment! Going to mark this as external, and I think we should also fix the 2nd issue outlined above.
[-]After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/-][+][$500] After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/+]melvin-bot commentedon Sep 7, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0124cd08463cfd5f26
53 remaining items
[-][$500] After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/-][+][HOLD for payment 2023-10-09] [$500] After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)[/+]melvin-bot commentedon Oct 2, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 2, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 2, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jliexpensify commentedon Oct 9, 2023
Payment Summary:
Upworks Job
jliexpensify commentedon Oct 9, 2023
@ntdiary bump to complete the checklist please!
ntdiary commentedon Oct 9, 2023
Not a regression, just a tiny feature polish, don't need a regression test. : )
jliexpensify commentedon Oct 9, 2023
@Charan-hs - paying now. For future reference, there's no need to submit work for review. Thanks!
jliexpensify commentedon Oct 9, 2023
Everyone has been paid and job is closed!