Repository navigation
[SMARTSCAN] MEDIUM: Receipt Scan Failures Polish #26832
Description
👋 @Gonals there's a bit of a diff from the design doc on this one. Can you help clean this up post-SaaStr? Thanks!
-
1. The error messages should be in-line beneath the field in error
-
2. The title of the failed request should update from
Receipt scan in progress...toReceipt missing details -
3. A system message from Expensify should be added to the transaction thread when the receipt scan fails to notify the member
-
4. The RBR red dot should be on the request row for member only (not the expense report row or for the admin as well)
CC: @JmillsExpensify @shawnborton
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~017bd7a39e34a6a3cb
- Upwork Job ID: 1699189929552527360
- Last Price Increase: 2023-09-05
Activity
melvin-bot commentedon Sep 5, 2023
Current assignee @Gonals is eligible for the Engineering assigner, not assigning anyone new.
melvin-bot commentedon Sep 5, 2023
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
melvin-bot commentedon Sep 5, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017bd7a39e34a6a3cb
melvin-bot commentedon Sep 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (
Internal)shawnborton commentedon Sep 5, 2023
Another quick one - if there is no Amount, we should make the Amount label use our standard font size (15px) and float to the vertical center of the push row. This really should be a global component we share everywhere, I feel like we keep having inconsistencies here.
36 remaining items
Gonals commentedon Oct 30, 2023
There's actually a problem with that one. It looks posted by
_FAKE_instead ofnotifications@expensify.com. I believe it is caused by hownotifications@expensify.comwas created (closed from the get-go) and have a PR in review to (hopefully) fix it.dylanexpensify commentedon Oct 30, 2023
Ahhh useful to know, thanks @Gonals! Mind linking PR here for good measure? 🙇♂️
Gonals commentedon Oct 30, 2023
Yep! This is the one: https://github.com/Expensify/Auth/pull/9070
[-][Scan Receipt] [MEDIUM] Receipt Scan Failures Polish[/-][+][SMARTSCAN] MEDIUM: Receipt Scan Failures Polish[/+]dylanexpensify commentedon Nov 7, 2023
Checking in, did that Auth PR linked above fix the issue @Gonals?
melvin-bot commentedon Nov 23, 2023
This issue has not been updated in over 15 days. @trjExpensify, @Gonals, @sobitneupane eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
trjExpensify commentedon Nov 23, 2023
Yes, that's fixed. There's a separate issue to add the Expensify logo and give it a name. Closing.