Skip to content

[HOLD for payment 2023-10-10] [$500] Public room - Unable to copy link as an anonymous user #27039

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create new public room.
  2. Send a normal message and a link in the room.
  3. Open the room in incognito by copy pasting the URL.
  4. Right click on the sent link
  5. Click on 'copy url to clipboard'

Expected Result:

Just like the 'copy to clipboard' option, 'copy URL to clipboard' shouldn't require the user to sign in.

Actual Result:

It is required to sign-in to copy a URL to clipboard.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.66-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-29.At.11.05.05.Pm.mp4
Recording.1488.mp4

Expensify/Expensify Issue URL:

Issue reported by: @esh-g

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693330719748079

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01666b3569fccb8232
  • Upwork Job ID: 1701195487091564544
  • Last Price Increase: 2023-09-11
  • Automatic offers:
    • esh-g | Contributor | 26880395
    • esh-g | Reporter | 26880399

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 8, 2023
  2. dukenv0307 commented on Sep 8, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Unable to copy link as an anonymous user.

    What is the root cause of that problem?

    We set isAnonymousAction for these actions as false. So anonymous user unable to copy link

    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyURLToClipboard',

    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyEmailToClipboard',

    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyLink',

    What changes do you think we should make in order to solve the problem?

    If we decide to copy link, I think we should accept anonymous users can do all copy action by change isAnonymousAction for these action to true

    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyURLToClipboard',

    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyEmailToClipboard',

    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyLink',

    What alternative solutions did you explore? (Optional)

  3. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. esh-g commented on Sep 8, 2023

    @esh-g
    Contributor

    @izarutskaya I had posted a proposal in slack. Please post it here if possible.. Or let me know if I should do so

  6. izarutskaya commented on Sep 8, 2023

    @izarutskaya
    Author

    Proposal from @esh-g

    Please re-state the problem

    Unable to use copy URL to clipboard and copy email to clipboard as an anonymous user.

    What is the root cause of this problem?

    We have not set the isAnonymousAction to true for these actions in contextMenuAction.js

    {
    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyURLToClipboard',
    icon: Expensicons.Copy,

    {
    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyEmailToClipboard',

    What changes should be made to fix this?

    We should set the isAnonymousAction property for the listed items to be true since this action shouldn't require any kind of authentication. We even allow attachments to be downloaded by an anonymous user, therefore I think allowing the copying of URLs and emails is the right step.

  7. bfitzexpensify commented on Sep 11, 2023

    @bfitzexpensify
    Contributor

    Sending external

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 11, 2023
  9. changed the title [-]Public room - Unable to copy link as an anonymous user[/-] [+][$500] Public room - Unable to copy link as an anonymous user[/+] on Sep 11, 2023
  10. melvin-bot commented on Sep 11, 2023

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 11, 2023
  12. 45 remaining items

  13. bfitzexpensify commented on Oct 6, 2023

    @bfitzexpensify
    Contributor

    Payment due for this on Tuesday.

  14. sobitneupane commented on Oct 9, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #22321

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    I don't think this can be considered as regression. https://github.com/Expensify/App/pull/22321/files#r1349995627

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    N/A

    • [@sobitneupane] Determine if we should create a regression test for this bug.

    Yes.

    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    #27039 (comment)

  15. sobitneupane commented on Oct 9, 2023

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Create a new public room.
    2. Send a message as a url and an email
    3. Go to room details and copy the room url from QR code screen.
    4. Go to a guest tab and paste the url
    5. Make sure we are able to copy the link and email by right clicking on them.

    Do we agree 👍 or 👎

  16. bfitzexpensify commented on Oct 10, 2023

    @bfitzexpensify
    Contributor

    Payment summary:

    Reporter: @esh-g - $50 to be paid via Upwork
    Contributor: @esh-g - $750 to be paid via Upwork
    C+: @sobitneupane - $750 to be paid via manual request

  17. bfitzexpensify commented on Oct 13, 2023

    @bfitzexpensify
    Contributor

    Payments complete, regression steps proposed via https://github.com/Expensify/Expensify/issues/325765, think we're all done here

  18. sobitneupane commented on Oct 30, 2023

    @sobitneupane
    Contributor

    #27039 (comment)

    Requested payment on newDot.

  19. JmillsExpensify commented on Nov 3, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @sobitneupane based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions