You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [$500] Public room - Unable to copy link as an anonymous user #27039
We should set the isAnonymousAction property for the listed items to be true since this action shouldn't require any kind of authentication. We even allow attachments to be downloaded by an anonymous user, therefore I think allowing the copying of URLs and emails is the right step.
changed the title [-]Public room - Unable to copy link as an anonymous user[/-][+][$500] Public room - Unable to copy link as an anonymous user[/+]on Sep 11, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
[@sobitneupane] Determine if we should create a regression test for this bug.
Yes.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
dukenv0307 commentedon Sep 8, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to copy link as an anonymous user.
What is the root cause of that problem?
We set
isAnonymousActionfor these actions as false. So anonymous user unable to copy linkApp/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 146 to 147 in 6e17b64
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 159 to 160 in 6e17b64
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 222 to 223 in 6e17b64
What changes do you think we should make in order to solve the problem?
If we decide to copy link, I think we should accept anonymous users can do all copy action by change
isAnonymousActionfor these action totrueApp/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 146 to 147 in 6e17b64
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 159 to 160 in 6e17b64
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 222 to 223 in 6e17b64
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Sep 8, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 8, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)esh-g commentedon Sep 8, 2023
@izarutskaya I had posted a proposal in slack. Please post it here if possible.. Or let me know if I should do so
izarutskaya commentedon Sep 8, 2023
Proposal from @esh-g
Please re-state the problem
Unable to use
copy URL to clipboardandcopy email to clipboardas an anonymous user.What is the root cause of this problem?
We have not set the
isAnonymousActiontotruefor these actions incontextMenuAction.jsApp/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 145 to 148 in a8e2a6a
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 158 to 160 in a8e2a6a
What changes should be made to fix this?
We should set the
isAnonymousActionproperty for the listed items to betruesince this action shouldn't require any kind of authentication. We even allow attachments to be downloaded by an anonymous user, therefore I think allowing the copying ofURLsandemailsis the right step.bfitzexpensify commentedon Sep 11, 2023
Sending external
[-]Public room - Unable to copy link as an anonymous user[/-][+][$500] Public room - Unable to copy link as an anonymous user[/+]melvin-bot commentedon Sep 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01666b3569fccb8232
45 remaining items
bfitzexpensify commentedon Oct 6, 2023
Payment due for this on Tuesday.
sobitneupane commentedon Oct 9, 2023
#22321
I don't think this can be considered as regression. https://github.com/Expensify/App/pull/22321/files#r1349995627
N/A
Yes.
#27039 (comment)
sobitneupane commentedon Oct 9, 2023
Regression Test Proposal
Do we agree 👍 or 👎
bfitzexpensify commentedon Oct 10, 2023
Payment summary:
Reporter: @esh-g - $50 to be paid via Upwork
Contributor: @esh-g - $750 to be paid via Upwork
C+: @sobitneupane - $750 to be paid via manual request
bfitzexpensify commentedon Oct 13, 2023
Payments complete, regression steps proposed via https://github.com/Expensify/Expensify/issues/325765, think we're all done here
sobitneupane commentedon Oct 30, 2023
#27039 (comment)
Requested payment on newDot.
JmillsExpensify commentedon Nov 3, 2023
$750 payment approved for @sobitneupane based on this comment.