Skip to content

[HOLD for payment 2023-10-12] [$500] Address remaining design inconsistencies for distance requests #27052

Closed

Description

@JmillsExpensify

From a post by @shawnborton (cc @dannymcclain)
image (7)

Changed required:

  • Each push-to-page row has margin-bottom: 8px - let’s get rid of that so it’s a bit more compact and matches existing styles
  • the map image itself has a bunch of vertical margin (20px) and thus it feels quite far away from the push row below it which also has vertical margin. Let’s make the vertical margin on the map image something like 8px or 12px
  • The “To” field above the workspace has a height of 32px. Let’s remove the height and just have some margin-top, but no need for margin below as the workspace row (avatar + name) already has vertical margin. This change should be applied everywhere we have a “To” row
  • Let’s make the map preview image use the same border radius as other receipt previews, which I think is 16px
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a22578e8f0e37d00
  • Upwork Job ID: 1700221988509253632
  • Last Price Increase: 2023-09-15
  • Automatic offers:
    • situchan | Reviewer | 26849648
    • akinwale | Contributor | 26849649

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    on Sep 8, 2023
  2. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

  3. changed the title [-]Address remaining design inconsistencies for distance requests[/-] [+][$500] Address remaining design inconsistencies for distance requests[/+] on Sep 8, 2023
  4. melvin-bot commented on Sep 8, 2023

    @melvin-bot
  5. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    and removed on Sep 8, 2023
  7. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

  8. 53 remaining items

  9. situchan commented on Oct 8, 2023

    @situchan
    Contributor

    3 business days of delay was from internal review.
    Here's proof:

    Screen.Recording.2023-10-08.at.8.13.18.PM.mov
  10. JmillsExpensify commented on Oct 10, 2023

    @JmillsExpensify
    ContributorAuthor

    @joelbettner Can to confirm these more recent comments?

  11. joelbettner commented on Oct 11, 2023

    @joelbettner

    @JmillsExpensify Yep, it took me a while to get around to reviewing. I've been completely inundated with auto assigned issues and reviews all the while trying to get higher priority code written for other projects.

  12. JmillsExpensify commented on Oct 12, 2023

    @JmillsExpensify
    ContributorAuthor

    Payment summary:

    Ok great thanks! I've updated the summary.

  13. JmillsExpensify commented on Oct 12, 2023

    @JmillsExpensify
    ContributorAuthor

    Still waiting on the BZ checklist from @situchan though in the meantime, I've paid out @akinwale.

  14. situchan commented on Oct 12, 2023

    @situchan
    Contributor

    This is just design inconsistency, not bug. I don't think regression test applies here.

  15. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    @JmillsExpensify, @akinwale, @dannymcclain, @joelbettner, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. joelbettner commented on Oct 16, 2023

    @joelbettner

    @JmillsExpensify I think we can close this issue, yes?

  17. situchan commented on Oct 16, 2023

    @situchan
    Contributor

    Awaiting payment

  18. JmillsExpensify commented on Oct 17, 2023

    @JmillsExpensify
    ContributorAuthor

    All paid out and no regression test suggested. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions