You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-12] [$500] Address remaining design inconsistencies for distance requests #27052
Each push-to-page row has margin-bottom: 8px - let’s get rid of that so it’s a bit more compact and matches existing styles
the map image itself has a bunch of vertical margin (20px) and thus it feels quite far away from the push row below it which also has vertical margin. Let’s make the vertical margin on the map image something like 8px or 12px
The “To” field above the workspace has a height of 32px. Let’s remove the height and just have some margin-top, but no need for margin below as the workspace row (avatar + name) already has vertical margin. This change should be applied everywhere we have a “To” row
Let’s make the map preview image use the same border radius as other receipt previews, which I think is 16px
changed the title [-]Address remaining design inconsistencies for distance requests[/-][+][$500] Address remaining design inconsistencies for distance requests[/+]on Sep 8, 2023
@JmillsExpensify Yep, it took me a while to get around to reviewing. I've been completely inundated with auto assigned issues and reviews all the while trying to get higher priority code written for other projects.
Activity
melvin-bot commentedon Sep 8, 2023
Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.
[-]Address remaining design inconsistencies for distance requests[/-][+][$500] Address remaining design inconsistencies for distance requests[/+]melvin-bot commentedon Sep 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a22578e8f0e37d00
melvin-bot commentedon Sep 8, 2023
Triggered auto assignment to @dannymcclain (
Design), see these Stack Overflow questions for more details.melvin-bot commentedon Sep 8, 2023
Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.
53 remaining items
situchan commentedon Oct 8, 2023
3 business days of delay was from internal review.
Here's proof:
Screen.Recording.2023-10-08.at.8.13.18.PM.mov
JmillsExpensify commentedon Oct 10, 2023
@joelbettner Can to confirm these more recent comments?
joelbettner commentedon Oct 11, 2023
@JmillsExpensify Yep, it took me a while to get around to reviewing. I've been completely inundated with auto assigned issues and reviews all the while trying to get higher priority code written for other projects.
JmillsExpensify commentedon Oct 12, 2023
Ok great thanks! I've updated the summary.
JmillsExpensify commentedon Oct 12, 2023
Still waiting on the BZ checklist from @situchan though in the meantime, I've paid out @akinwale.
situchan commentedon Oct 12, 2023
This is just design inconsistency, not bug. I don't think regression test applies here.
melvin-bot commentedon Oct 16, 2023
@JmillsExpensify, @akinwale, @dannymcclain, @joelbettner, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
joelbettner commentedon Oct 16, 2023
@JmillsExpensify I think we can close this issue, yes?
situchan commentedon Oct 16, 2023
Awaiting payment
JmillsExpensify commentedon Oct 17, 2023
All paid out and no regression test suggested. Closing.