[HOLD - should be resolved by #23755][$500] [Distance] - User is able to request money from an archived workspace using link

@hichamcc

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Request money -> distance
Fill start and finish points
Select a workspace
Copy link
Delete that workspace
Past the copied link

Expected Result:

Users should not have the ability to request money from an archived workspace

Actual Result:

The User is able to request money from an archived workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.66.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

distance-archive.webm

Recording.4370.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hichamcc
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693924665226099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0144d881c5d2a1b34f
Upwork Job ID: 1700942638080782336
Last Price Increase: 2023-09-10

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Distance] user is able to request money from an archived workspace using link

What is the root cause of that problem?

App/src/components/MoneyRequestConfirmationList.js

Line 361 in 911fe99

const shouldDisableButton = selectedParticipants.length === 0;

This is the condition to disable the Request button. We don't check if the policy is archive or not

What changes do you think we should make in order to solve the problem?

In MoneyRequestConfirmationList, we should add a condition to check if workspace is deleted. If that we should disable button and display a error message like this

To do that, in herehttps://github.com/Expensify/App/blob/911fe99c56116f1a36c38fb596251bbce5fc1b33/src/components/MoneyRequestConfirmationList.js#L361
we should update the condition like that

const shouldDisableButton = selectedParticipants.length === 0 || (props.isDistanceRequest && ReportUtils.isArchivedRoom(selectedParticipants[0]));

and in here,

App/src/components/MoneyRequestConfirmationList.js

Line 264 in 911fe99

isDisabled: ReportUtils.isOptimisticPersonalDetail(participant.accountID),

add an error message

brickRoadIndicator: (props.isDistanceRequest && ReportUtils.isArchivedRoom(selectedParticipants[0])) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : null,
allReportErrors:  (props.isDistanceRequest && ReportUtils.isArchivedRoom(selectedParticipants[0])) ? ['Please select a valid participant']  : null,   // need to use translation here

The completed code change will be implemented in the PR phrase

What alternative solutions did you explore? (Optional)

If the selected workspace is deleted, we will redirect to the distance request page. To do that,

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Line 75 in 911fe99

useEffect(() => {

Add condition and logic to redirect to distance page

if (isDistanceRequest && ReportUtils.isArchivedRoom(participants[0])) {
            Navigation.goBack(ROUTES.getMoneyRequestRoute(iouType.current, reportID.current), true);
        }

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Distance] user is able to request money from an archived workspace using a deep link

What is the root cause of that problem?

We have logic to check some conditions to return to the money request page. Here we have not checked whether the workspace is archived or not.

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 94 to 97 in f5fa30b

    
           if (_.isEmpty(props.iou.participants) || (props.iou.amount === 0 && !props.iou.receiptPath) || shouldReset) { 
        
               Navigation.goBack(ROUTES.getMoneyRequestRoute(iouType.current, reportID.current), true); 
        
           }

That's why we can open the confirm request page even though the WS has been deleted

What changes do you think we should make in order to solve the problem?

We can add a condition to check if the room is archived or not to leave the money request page.

if (_.isEmpty(props.iou.participants) || (props.iou.amount === 0 && !props.iou.receiptPath && !isDistanceRequest) || shouldReset || ReportUtils.isArchivedRoom(props.report)) {

What alternative solutions did you explore? (Optional)

In addition, if we do not want to return to the money request page, we can show not found page by grawp content with FullPageNotFoundView

Job added to Upwork: https://www.upwork.com/jobs/~0144d881c5d2a1b34f

@johncschuster

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@garrettmknight

Triggered auto assignment to @garrettmknight (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mollfpr

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

Still holding on #23755

Moving daily to retest - there was a regression on the issue we were holding on so it still might be an issue.

@garrettmknight

@garrettmknight, @mollfpr Huh... This is 4 days overdue. Who can take care of this?

Haven't had a chance to retest today - will do tomorrow.

@hichamcc

This has been fixed, once you reload the distance request you're required to select a new workspace.

@hichamcc accept the offer and I'll pay the reporting bonus.

Upwork job for my reference: https://www.upwork.com/en-gb/ab/applicants/1719789138652127232/hired

Done

Paid, closing

Navigation Menu

Repository navigation

[HOLD - should be resolved by #23755][$500] [Distance] - User is able to request money from an archived workspace using link #27113

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Bug0 Triage Checklist (Main S/O)

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development


	if (_.isEmpty(props.iou.participants) \|\| (props.iou.amount === 0 && !props.iou.receiptPath) \|\| shouldReset) {
	Navigation.goBack(ROUTES.getMoneyRequestRoute(iouType.current, reportID.current), true);
	}

[HOLD - should be resolved by #23755][$500] [Distance] - User is able to request money from an archived workspace using link #27113

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

DylanDylann commented on Sep 10, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

namhihi237 commented on Sep 10, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 10, 2023

melvin-bot commented on Sep 10, 2023

melvin-bot commented on Sep 10, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Sep 10, 2023

melvin-bot commented on Sep 10, 2023

13 remaining items

garrettmknight commented on Oct 25, 2023

garrettmknight commented on Oct 25, 2023

melvin-bot commented on Oct 31, 2023

garrettmknight commented on Oct 31, 2023

garrettmknight commented on Nov 1, 2023

hichamcc commented on Nov 1, 2023

garrettmknight commented on Nov 1, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions