You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-29] [$500] Android - Emoji selected from emoji picker can't be deleted from emoji picker #27189
changed the title [-]Android - Emoji selected from emoji picker can't be deleted from emoji picker[/-][+][$500] Android - Emoji selected from emoji picker can't be deleted from emoji picker[/+]on Sep 11, 2023
What changes do you think we should make in order to solve the problem?
We need to pass props.emojiReactions as emojiReactions prop to AddReactionBubble from BaseQuickEmojiReactions & then use it in the onSelectEmoji method as the second parameter.
Please re-state the problem that we are trying to solve in this issue.
The emoji cannot be removed by selecting the same emoji in the emoji picker.
What is the root cause of that problem?
In order to toggle the emoji, it needs existingReactions as the second param here.
However in here, we're not calling onEmojiSelected with the existingReactions (which already exists in BaseQuickEmojiReactions and is alreaady used here)
What changes do you think we should make in order to solve the problem?
We cannot add the emojiReactions as the props to AddReactionBubble because that will mean all the AddReactionBubble will rerender any time the emojiReactions changes. Also it will likely cause regressions/warnings since the AddReactionBubble is used in other places as well, some of which already handles the emoji toggle well without any second param inside AddReactionBubble, like here.
What alternative solutions did you explore? (Optional)
changed the title [-][$500] Android - Emoji selected from emoji picker can't be deleted from emoji picker[/-][+][HOLD for payment 2023-09-29] [$500] Android - Emoji selected from emoji picker can't be deleted from emoji picker[/+]on Sep 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@burczu] The PR that introduced the bug has been identified. Link to the PR:
[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss / @anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@burczu] The PR that introduced the bug has been identified. Link to the PR: Didn't find - it looks like it worked this way from the beginning.
[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss / @anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]Android - Emoji selected from emoji picker can't be deleted from emoji picker[/-][+][$500] Android - Emoji selected from emoji picker can't be deleted from emoji picker[/+]melvin-bot commentedon Sep 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01d573b7341ac1e471
melvin-bot commentedon Sep 11, 2023
Triggered auto assignment to @tjferriss (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 11, 2023
Triggered auto assignment to @anmurali (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 11, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (
External)Krishna2323 commentedon Sep 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Emoji selected from emoji picker can't be deleted from emoji picker.
What is the root cause of that problem?
We are not passing existing emojiReactions to AddReactionBubble.js which runs onSelectEmoji that requires new emoji object & existing emoji reactions.
toggleEmojiAndCloseMenu passes as onSelectEmoji to QuickEmojiReactions & MiniQuickEmojiReactions:
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 62 to 65 in 84f3ede
AddReactionBubble calling onSelectEmoji without emojiReactions (existing ones):
App/src/components/Reactions/AddReactionBubble.js
Lines 62 to 71 in b82bc07
What changes do you think we should make in order to solve the problem?
We need to pass props.emojiReactions as emojiReactions prop to AddReactionBubble from BaseQuickEmojiReactions & then use it in the onSelectEmoji method as the second parameter.
App/src/components/Reactions/QuickEmojiReactions/BaseQuickEmojiReactions.js
Lines 62 to 88 in 84f3ede
dukenv0307 commentedon Sep 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The emoji cannot be removed by selecting the same emoji in the emoji picker.
What is the root cause of that problem?
In order to toggle the emoji, it needs
existingReactionsas the second param here.However in here, we're not calling
onEmojiSelectedwith the existingReactions (which already exists inBaseQuickEmojiReactionsand is alreaady used here)What changes do you think we should make in order to solve the problem?
We need to change this line to
We cannot add the
emojiReactionsas the props toAddReactionBubblebecause that will mean all theAddReactionBubblewill rerender any time theemojiReactionschanges. Also it will likely cause regressions/warnings since theAddReactionBubbleis used in other places as well, some of which already handles the emoji toggle well without any second param insideAddReactionBubble, like here.What alternative solutions did you explore? (Optional)
NA
19 remaining items
[-][$500] Android - Emoji selected from emoji picker can't be deleted from emoji picker[/-][+][HOLD for payment 2023-09-29] [$500] Android - Emoji selected from emoji picker can't be deleted from emoji picker[/+]melvin-bot commentedon Sep 22, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
tjferriss commentedon Sep 25, 2023
Payment Summary:
burczu commentedon Sep 26, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 2, 2023
@burczu, @tjferriss, @anmurali, @stitesExpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
tjferriss commentedon Oct 2, 2023
@dukenv0307 @Krishna2323 have been paid via Upworks.